From: Julien Grall <julien@xen.org>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v3 14/16] tools/xenstore: split out environment specific live update code
Date: Mon, 19 Jun 2023 18:55:09 +0100 [thread overview]
Message-ID: <94daf68e-f623-acf0-5139-fdcb736a367e@xen.org> (raw)
In-Reply-To: <20230530085418.5417-15-jgross@suse.com>
Hi Juergen,
On 30/05/2023 09:54, Juergen Gross wrote:
> -static struct live_update *lu_status;
> -
> -struct lu_dump_state {
> - void *buf;
> - unsigned int size;
> -#ifndef __MINIOS__
> - int fd;
> - char *filename;
> -#endif
> -};
> -
> -static int lu_destroy(void *data)
> -{
> -#ifdef __MINIOS__
> - if (lu_status->dump_state)
> - munmap(lu_status->dump_state, lu_status->dump_size);
> -#endif
> - lu_status = NULL;
> -
> - return 0;
> -}
I think moving all lu_destroy() out of xenstored_control.c is a mistake
because we now need to remember that any common change in lu_begin() may
need an update in the two implementation of lu_destroy().
Even if this seems pointless for a few lines, it would be best to split
lu_destroy() in two parts: one common and one per lu backend.
The rest of the changes look good to me.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2023-06-19 17:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 8:54 [PATCH v3 00/16] tools/xenstore: more cleanups Juergen Gross
2023-05-30 8:54 ` [PATCH v3 01/16] tools/xenstore: verify command line parameters better Juergen Gross
2023-05-30 8:54 ` [PATCH v3 02/16] tools/xenstore: do some cleanup of hashtable.c Juergen Gross
2023-05-30 8:54 ` [PATCH v3 03/16] tools/xenstore: modify interface of create_hashtable() Juergen Gross
2023-06-09 17:52 ` Julien Grall
2023-05-30 8:54 ` [PATCH v3 04/16] tools/xenstore: rename hashtable_insert() and let it return 0 on success Juergen Gross
2023-06-09 17:56 ` Julien Grall
2023-05-30 8:54 ` [PATCH v3 05/16] tools/xenstore: make some write limit functions static Juergen Gross
2023-06-09 18:00 ` Julien Grall
2023-05-30 8:54 ` [PATCH v3 06/16] tools/xenstore: switch write limiting to use millisecond time base Juergen Gross
2023-06-09 18:02 ` Julien Grall
2023-05-30 8:54 ` [PATCH v3 07/16] tools/xenstore: remove stale TODO file Juergen Gross
2023-05-30 8:54 ` [PATCH v3 08/16] tools/xenstore: remove unused events list Juergen Gross
2023-05-30 8:54 ` [PATCH v3 09/16] tools/xenstore: remove support of file backed data base Juergen Gross
2023-06-09 18:04 ` Julien Grall
2023-05-30 8:54 ` [PATCH v3 10/16] tools/libs/store: use xen_list.h instead of xenstore/list.h Juergen Gross
2023-06-09 18:09 ` Julien Grall
2023-06-12 7:02 ` Juergen Gross
2023-06-12 10:34 ` Julien Grall
2023-06-12 10:37 ` Juergen Gross
2023-06-12 10:39 ` Julien Grall
2023-05-30 8:54 ` [PATCH v3 11/16] tools/libs/store: make libxenstore independent of utils.h Juergen Gross
2023-06-09 18:10 ` Julien Grall
2023-05-30 8:54 ` [PATCH v3 12/16] tools/xenstore: remove no longer needed functions from xs_lib.c Juergen Gross
2023-06-15 21:00 ` Julien Grall
2023-05-30 8:54 ` [PATCH v3 13/16] tools/xenstore: replace xs_lib.c with a header Juergen Gross
2023-06-15 21:03 ` Julien Grall
2023-05-30 8:54 ` [PATCH v3 14/16] tools/xenstore: split out environment specific live update code Juergen Gross
2023-06-19 17:55 ` Julien Grall [this message]
2023-06-20 8:22 ` Juergen Gross
2023-05-30 8:54 ` [PATCH v3 15/16] tools/xenstore: split out rest of live update control code Juergen Gross
2023-06-19 18:03 ` Julien Grall
2023-05-30 8:54 ` [PATCH v3 16/16] tools/xenstore: remove unused stuff from list.h Juergen Gross
2023-06-19 18:04 ` Julien Grall
2023-06-09 18:46 ` [PATCH v3 00/16] tools/xenstore: more cleanups Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94daf68e-f623-acf0-5139-fdcb736a367e@xen.org \
--to=julien@xen.org \
--cc=anthony.perard@citrix.com \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).