xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: net: xen-netfront: Simplify the calculation of variables
@ 2021-02-02 10:17 Jiapeng Chong
  2021-02-04 11:09 ` Jürgen Groß
  2021-02-04 19:40 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2021-02-02 10:17 UTC (permalink / raw)
  To: boris.ostrovsky
  Cc: jgross, sstabellini, davem, kuba, ast, daniel, hawk,
	john.fastabend, andrii, kafai, songliubraving, yhs, kpsingh,
	xen-devel, netdev, linux-kernel, bpf, Jiapeng Chong

Fix the following coccicheck warnings:

./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is
equivalent to !A || B.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/net/xen-netfront.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index b01848e..5158841 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1813,7 +1813,7 @@ static int setup_netfront(struct xenbus_device *dev,
 	 *  a) feature-split-event-channels == 0
 	 *  b) feature-split-event-channels == 1 but failed to setup
 	 */
-	if (!feature_split_evtchn || (feature_split_evtchn && err))
+	if (!feature_split_evtchn || err)
 		err = setup_netfront_single(queue);
 
 	if (err)
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drivers: net: xen-netfront: Simplify the calculation of variables
  2021-02-02 10:17 [PATCH] drivers: net: xen-netfront: Simplify the calculation of variables Jiapeng Chong
@ 2021-02-04 11:09 ` Jürgen Groß
  2021-02-04 19:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Jürgen Groß @ 2021-02-04 11:09 UTC (permalink / raw)
  To: Jiapeng Chong, boris.ostrovsky
  Cc: sstabellini, davem, kuba, ast, daniel, hawk, john.fastabend,
	andrii, kafai, songliubraving, yhs, kpsingh, xen-devel, netdev,
	linux-kernel, bpf


[-- Attachment #1.1.1: Type: text/plain, Size: 366 bytes --]

On 02.02.21 11:17, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
> 
> ./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is
> equivalent to !A || B.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drivers: net: xen-netfront: Simplify the calculation of variables
  2021-02-02 10:17 [PATCH] drivers: net: xen-netfront: Simplify the calculation of variables Jiapeng Chong
  2021-02-04 11:09 ` Jürgen Groß
@ 2021-02-04 19:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-02-04 19:40 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: boris.ostrovsky, jgross, sstabellini, davem, kuba, ast, daniel,
	hawk, john.fastabend, andrii, kafai, songliubraving, yhs,
	kpsingh, xen-devel, netdev, linux-kernel, bpf

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue,  2 Feb 2021 18:17:49 +0800 you wrote:
> Fix the following coccicheck warnings:
> 
> ./drivers/net/xen-netfront.c:1816:52-54: WARNING !A || A && B is
> equivalent to !A || B.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> 
> [...]

Here is the summary with links:
  - drivers: net: xen-netfront: Simplify the calculation of variables
    https://git.kernel.org/netdev/net-next/c/e93fac3b5161

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-04 19:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02 10:17 [PATCH] drivers: net: xen-netfront: Simplify the calculation of variables Jiapeng Chong
2021-02-04 11:09 ` Jürgen Groß
2021-02-04 19:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).