From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74376C433DF for ; Tue, 2 Jun 2020 10:43:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4712020679 for ; Tue, 2 Jun 2020 10:43:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4712020679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jg4O1-0004wV-4h; Tue, 02 Jun 2020 10:43:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jg4O0-0004wQ-AW for xen-devel@lists.xenproject.org; Tue, 02 Jun 2020 10:43:12 +0000 X-Inumbo-ID: da8af3b2-a4bd-11ea-9947-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id da8af3b2-a4bd-11ea-9947-bc764e2007e4; Tue, 02 Jun 2020 10:43:11 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A3E56AC96; Tue, 2 Jun 2020 10:43:12 +0000 (UTC) Subject: Re: [PATCH v10 08/12] xen: add /buildinfo/config entry to hypervisor filesystem To: Andrew Cooper , xen-devel@lists.xenproject.org References: <20200519072106.26894-1-jgross@suse.com> <20200519072106.26894-9-jgross@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <95e4a29c-85e1-b7ed-ee7e-5517a094bd6a@suse.com> Date: Tue, 2 Jun 2020 12:43:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Ian Jackson , George Dunlap , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 02.06.20 11:03, Andrew Cooper wrote: > On 19/05/2020 08:21, Juergen Gross wrote: >> diff --git a/xen/common/Makefile b/xen/common/Makefile >> index bf7d0e25a3..3d61239fbf 100644 >> --- a/xen/common/Makefile >> +++ b/xen/common/Makefile >> @@ -1,6 +1,7 @@ >> obj-$(CONFIG_ARGO) += argo.o >> obj-y += bitmap.o >> obj-y += bsearch.o >> +obj-$(CONFIG_HYPFS_CONFIG) += config_data.o >> obj-$(CONFIG_CORE_PARKING) += core_parking.o >> obj-y += cpu.o >> obj-$(CONFIG_DEBUG_TRACE) += debugtrace.o >> @@ -73,3 +74,14 @@ obj-$(CONFIG_UBSAN) += ubsan/ >> >> obj-$(CONFIG_NEEDS_LIBELF) += libelf/ >> obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/ >> + >> +config.gz: ../.config >> + gzip -c $< >$@ > > I had to disable HYPFS in the XenServer build.  Inside RPM, this fails with Disabling CONFIG_HYPFS_CONFIG should work, too. > > make[3]: *** No rule to make target `../.config', needed by > `config.gz'.  Stop. > make[3]: *** Waiting for unfinished jobs.... > > This needs to be an expression involving $(KCONFIG_CONFIG) because > .config is only the default, and it surely needs a $(XEN_ROOT) in there? Will send a patch. Oh, in fact I'll send two patches, as I guess pv-shim doesn't want to have CONFIG_HYPFS set. Juergen