From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Paul Durrant <paul.durrant@citrix.com>,
Christian Lindig <christian.lindig@citrix.com>,
Jan Beulich <jbeulich@suse.com>, David Scott <dave@recoil.org>,
Anthony PERARD <anthony.perard@citrix.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [Xen-devel] [PATCH v4 1/2] sysctl/libxl: choose a sane default for HAP
Date: Tue, 10 Sep 2019 16:40:39 +0100 [thread overview]
Message-ID: <962de8fd-6803-8f90-9690-232544032fa3@citrix.com> (raw)
In-Reply-To: <20190910152538.36921-1-roger.pau@citrix.com>
On 10/09/2019 16:25, Roger Pau Monne wrote:
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> index e544ef84da..a5e77c943a 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -107,6 +107,7 @@ type physinfo_cap_flag =
> | CAP_HVM
> | CAP_PV
> | CAP_DirectIO
> + | CAP_hap
HAP is an initialism just like HVM, so definitely should be capitalised.
IMO, DirectIO being not all caps is a bug, but its in the API now.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-10 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 15:25 [Xen-devel] [PATCH v4 1/2] sysctl/libxl: choose a sane default for HAP Roger Pau Monne
2019-09-10 15:25 ` [Xen-devel] [PATCH v4 2/2] sysctl: report shadow paging capability Roger Pau Monne
2019-09-10 15:40 ` Jan Beulich
2019-09-12 9:51 ` Andrew Cooper
2019-09-12 10:45 ` Ian Jackson
2019-09-10 15:27 ` [Xen-devel] [PATCH v4 1/2] sysctl/libxl: choose a sane default for HAP Christian Lindig
2019-09-10 15:40 ` Andrew Cooper [this message]
2019-09-10 15:44 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=962de8fd-6803-8f90-9690-232544032fa3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=anthony.perard@citrix.com \
--cc=christian.lindig@citrix.com \
--cc=dave@recoil.org \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=paul.durrant@citrix.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).