From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 296EDC433DB for ; Thu, 21 Jan 2021 18:48:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B44A8230F9 for ; Thu, 21 Jan 2021 18:48:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B44A8230F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.72357.130223 (Exim 4.92) (envelope-from ) id 1l2ezn-0004gD-KW; Thu, 21 Jan 2021 18:47:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 72357.130223; Thu, 21 Jan 2021 18:47:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l2ezn-0004g6-HP; Thu, 21 Jan 2021 18:47:51 +0000 Received: by outflank-mailman (input) for mailman id 72357; Thu, 21 Jan 2021 18:47:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l2ezl-0004g1-Gj for xen-devel@lists.xenproject.org; Thu, 21 Jan 2021 18:47:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l2ezl-0006kD-5i; Thu, 21 Jan 2021 18:47:49 +0000 Received: from [54.239.6.186] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l2ezk-0004JK-U5; Thu, 21 Jan 2021 18:47:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=dWRi3WLcGjV76iDWJJEYVgUQ6Fo73BQtnot0oLynres=; b=oeDYNG+aA7zGSOs+kjP+uVWuV1 6Y1/prkzn3eQxzfrfv2qsw5rhVmvzx5eCHGhDEHZTVK33+LrT4jLNTFzTDyE3C2um9xCeIuSdn3PI 8tlga0LegUHi4OMZKTo98e2BV8qhIioRhroLEh3Bbdj4dUMmd8pC8Vrs9Q4fmmFBrodI=; Subject: Re: [PATCH] xen/arm: Fix compilation error when early printk is enabled To: Jan Beulich Cc: Stefano Stabellini , Volodymyr Babchuk , bertrand.marquis@arm.com, wei.chen@arm.com, xen-devel@lists.xenproject.org, Michal Orzel References: <20210121093041.21537-1-michal.orzel@arm.com> <6f317514-110a-9c5c-8732-60c0a1f58d31@suse.com> <44567b70-9464-9a4a-5cc9-28505a512c99@xen.org> <16424ccd-372a-4090-e54e-b71689f33e4e@suse.com> From: Julien Grall Message-ID: <96e5720d-81ae-061e-d378-7cae6ad04415@xen.org> Date: Thu, 21 Jan 2021 18:47:47 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <16424ccd-372a-4090-e54e-b71689f33e4e@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 21/01/2021 10:24, Jan Beulich wrote: > On 21.01.2021 10:56, Julien Grall wrote: >> Hi Jan, >> >> On 21/01/2021 09:43, Jan Beulich wrote: >>> On 21.01.2021 10:30, Michal Orzel wrote: >>>> Fix compilation error when enabling early printk, introduced >>>> by commit aa4b9d1ee6538b5cbe218d4d3fcdf9548130a063: >>>> ``` >>>> debug.S: Assembler messages: >>>> debug.S:31: Error: constant expression expected at operand 2 -- `ldr x15,=((0x00400000+(0)*PAGE_SIZE)+(0x1c090000&~PAGE_MASK))` >>>> debug.S:38: Error: constant expression expected at operand 2 -- `ldr x15,=((0x00400000+(0)*PAGE_SIZE)+(0x1c090000&~PAGE_MASK))` >>>> ``` >>>> >>>> The fix is to include header which now contains >>>> definitions for page/size/mask etc. >>>> >>>> Signed-off-by: Michal Orzel >>> >>> I'm sorry for the breakage, but I wonder how I should have noticed >>> the issue. In all the Arm .config-s I'm routinely building I can't >>> even see ... >>> >>>> --- a/xen/include/asm-arm/early_printk.h >>>> +++ b/xen/include/asm-arm/early_printk.h >>>> @@ -10,6 +10,7 @@ >>>> #ifndef __ARM_EARLY_PRINTK_H__ >>>> #define __ARM_EARLY_PRINTK_H__ >>>> >>>> +#include >>>> >>>> #ifdef CONFIG_EARLY_PRINTK >>> >>> ... a respective Kconfig setting, i.e. it's not like I simply >>> failed to enable it. >> >> EARLY_PRINTK is defined in arch/arm/Kconfig.debug and is selected when >> you specify the UART to use. >> >> Assuming you are only build testing, you could add the following for >> testing EARLY_PRINTK: >> >> CONFIG_DEBUG=y >> CONFIG_EARLY_UART_CHOICE_8250=y >> CONFIG_EARLY_UART_8250=y >> CONFIG_EARLY_PRINTK=y >> CONFIG_EARLY_UART_BASE_ADDRESS= >> CONFIG_EARLY_UART_8250_REG_SHIFT=0 >> CONFIG_EARLY_PRINTK_INC="debug-8250.inc" > > Ah yes, this works, thanks. The "optional" on the choice isn't > very helpful I suppose, because when going from an existing > .config one would neither find a setting presently turned off > in that .config, nor will there be a prompt. Do you have a suggestion how the "choice" can appear in the .config? > I suppose any page-aligned base address is fine to use for my > build-testing-only purposes? The base address doesn't need to be page-aligned (some HW have multiple UARTs in the same 4K region). Cheers, -- Julien Grall