From: Julien Grall <julien.grall@arm.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Jennifer Herbert <jennifer.herbert@citrix.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 06/15] xen: trace IRQ enabling/disabling
Date: Fri, 9 Jun 2017 11:51:36 +0100 [thread overview]
Message-ID: <978237fc-b9dd-d304-8132-956d1d6331e6@arm.com> (raw)
In-Reply-To: <1496848924.9462.1.camel@citrix.com>
On 07/06/17 16:22, Dario Faggioli wrote:
> On Wed, 2017-06-07 at 12:16 +0100, Julien Grall wrote:
>> Hi Dario,
>>
> Hi,
>
>> On 01/06/17 18:34, Dario Faggioli wrote:
>>> diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c
>>> index 2a06406..33b903e 100644
>>> --- a/xen/common/spinlock.c
>>> +++ b/xen/common/spinlock.c
>>> @@ -150,7 +150,9 @@ void _spin_lock(spinlock_t *lock)
>>> void _spin_lock_irq(spinlock_t *lock)
>>> {
>>> ASSERT(local_irq_is_enabled());
>>> - local_irq_disable();
>>> + _local_irq_disable();
>>> + if ( unlikely(tb_init_done) )
>>
>> __trace_var already contain a "if ( !tb_init_done )". It sounds
>> pointless to do it twice, and also I think it is not obvious to
>> understand the meaning of the check (i.e what is tb_init_done).
>>
>> Would it be possible to hide this check and avoid check tb_init_done
>> twice?
>>
> I totally agree. And in fact, in another patch, I remove the
> tb_init_done check in __trace_var(). Reason behind this is that all the
> callers of __trace_var() (the main one being trace_var()), already
> checks for tb_init_done themselves.
>
> In fact, the explicit check in the caller, is the (only) basis on which
> one decides to call either trace_var() or __trace_var().
>
> This here is one of the call sites where I think the check is better
> done in the caller.
I admit, it is a bit confusing to require the caller to check
tb_init_done. It adds more code and IHMO counterintuitive.
>
>>> diff --git a/xen/include/asm-arm/arm32/system.h b/xen/include/asm-
>>> arm/arm32/system.h
>>> index c617b40..20871ad 100644
>>> --- a/xen/include/asm-arm/arm32/system.h
>>> +++ b/xen/include/asm-arm/arm32/system.h
>>> @@ -4,6 +4,8 @@
>>>
>>> #include <asm/arm32/cmpxchg.h>
>>>
>>> +#include <xen/trace.h>
>>> +
>>> #define local_irq_disable() asm volatile ( "cpsid i @
>>> local_irq_disable\n" : : : "cc" )
>>> #define local_irq_enable() asm volatile ( "cpsie i @
>>> local_irq_enable\n" : : : "cc" )
>>>
>>> @@ -41,6 +43,16 @@ static inline int local_irq_is_enabled(void)
>>> #define local_abort_enable() __asm__("cpsie a @ __sta\n" : : :
>>> "memory", "cc")
>>> #define local_abort_disable() __asm__("cpsid a @ __sta\n" : : :
>>> "memory", "cc")
>>>
>>> +/* We do not support tracing (at all) yet */
>>
>> I know that some bits are missing for ARM, but the patch #5
>> contradicts
>> this comment as you have CONFIG_TRACE=y by default.
>>
> No sure what you mean. Tracing is de facto on by default right now,
> despite it not being implemented for ARM. So what I'm doing is
> basically keeping things as they are.
>
> If you think it should be off by default, well, let's talk about it...
> but I'm not sure this is really what you are saying/asking.
I mean that CONFIG_TRACE=y by default gives the impression that tracing
is supported on ARM. This is not the case, hence your comment. So I
think it should be off my default until we get the support. BTW, it is
only a couple of simple patches but they never made upstreamed :/
>>> +#define trace_irq_disable_ret() do { } while ( 0 )
>>> +#define trace_irq_enable_ret() do { } while ( 0 )
>>> +#define trace_irq_save_ret(_x) do { } while ( 0 )
>>> +#define trace_irq_restore_ret(_x) do { } while ( 0 )
>>> +#define _local_irq_disable() local_irq_disable()
>>> +#define _local_irq_enable() local_irq_enable()
>>> +#define _local_irq_save(_x) local_irq_save(_x)
>>> +#define _local_irq_restore(_x) local_irq_restore(_x)
>>> +
>>
>> This does not need to be duplicated in both asm-
>> arm/arm{32,64}/system.h.
>> You could directly implement them in asm-arm/system.h.
>>
> Ok, thanks.
>
>> Also, I would prefer if you stay consistent with x86. I.e non-
>> underscore
>> versions are calling the underscore versions and not the invert.
>>
> Well, I know it is counterintuitive, but it's the easiest way of
> getting over this, i.e., without the need of a lot of stubs, and
> touching as few existing code as possible.
Can you detail here? The only things I was asking is to do:
#define _local_irq_disable() ......
#define local_irq_disable() _local_irq_disable.
The callers would still use local_irq_disable() and the code would be
consistent with x86.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-09 10:51 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 17:33 [PATCH 00/15] xen/tools: add tracing to various Xen subsystems Dario Faggioli
2017-06-01 17:33 ` [PATCH 01/15] xen: in do_softirq() sample smp_processor_id() once and for all Dario Faggioli
2017-06-07 14:38 ` Jan Beulich
2017-06-08 14:12 ` George Dunlap
2017-06-08 14:20 ` George Dunlap
2017-06-08 14:42 ` Jan Beulich
2017-06-01 17:33 ` [PATCH 02/15] xen: tracing: avoid checking tb_init_done multiple times Dario Faggioli
2017-06-01 17:53 ` Andrew Cooper
2017-06-01 23:08 ` Dario Faggioli
2017-06-07 14:46 ` Jan Beulich
2017-06-07 15:55 ` Dario Faggioli
2017-06-07 16:06 ` Jan Beulich
2017-06-08 14:34 ` George Dunlap
2017-06-08 14:37 ` George Dunlap
2017-06-01 17:33 ` [PATCH 03/15] xen/tools: tracing: several improvements on IRQs tracing Dario Faggioli
2017-06-01 18:02 ` Andrew Cooper
2017-06-01 23:12 ` Dario Faggioli
2017-06-07 15:05 ` Jan Beulich
2017-06-07 15:45 ` Dario Faggioli
2017-06-07 15:58 ` Jan Beulich
2017-06-08 14:53 ` George Dunlap
2017-06-08 15:34 ` Jan Beulich
2017-06-08 14:59 ` George Dunlap
2017-06-01 17:34 ` [PATCH 04/15] tools: xenalyze: fix dumping of PM_IDLE events Dario Faggioli
2017-06-08 15:06 ` George Dunlap
2017-06-01 17:34 ` [PATCH 05/15] xen: make it possible to disable tracing in Kconfig Dario Faggioli
2017-06-01 18:43 ` Andrew Cooper
2017-06-07 11:01 ` Julien Grall
2017-06-07 15:14 ` Jan Beulich
2017-06-08 15:16 ` George Dunlap
2017-06-08 15:35 ` Jan Beulich
2017-06-08 15:37 ` George Dunlap
2017-06-08 15:44 ` Jan Beulich
2017-06-08 15:17 ` George Dunlap
2017-06-01 17:34 ` [PATCH 06/15] xen: trace IRQ enabling/disabling Dario Faggioli
2017-06-01 19:08 ` Andrew Cooper
2017-06-01 23:42 ` Dario Faggioli
2017-06-08 15:51 ` George Dunlap
2017-06-08 16:05 ` Jan Beulich
2017-06-07 11:16 ` Julien Grall
2017-06-07 15:22 ` Dario Faggioli
2017-06-09 10:51 ` Julien Grall [this message]
2017-06-09 10:53 ` Julien Grall
2017-06-09 10:55 ` George Dunlap
2017-06-09 11:00 ` Julien Grall
2017-06-08 16:01 ` George Dunlap
2017-06-08 16:11 ` Dario Faggioli
2017-06-09 10:41 ` Jan Beulich
2017-06-01 17:34 ` [PATCH 07/15] tools: tracing: handle IRQs on/off events in xentrace and xenalyze Dario Faggioli
2017-06-13 15:58 ` George Dunlap
2017-06-01 17:34 ` [PATCH 08/15] xen: trace RCU behavior Dario Faggioli
2017-06-09 10:48 ` Jan Beulich
2017-06-13 16:05 ` George Dunlap
2017-06-01 17:34 ` [PATCH 09/15] tools: tracing: handle RCU events in xentrace and xenalyze Dario Faggioli
2017-06-13 16:12 ` George Dunlap
2017-06-01 17:34 ` [PATCH 10/15] xen: trace softirqs Dario Faggioli
2017-06-09 10:51 ` Jan Beulich
2017-06-01 17:34 ` [PATCH 11/15] tools: tracing: handle RCU events in xentrace and xenalyze Dario Faggioli
2017-06-01 17:35 ` [PATCH 12/15] xen: trace tasklets Dario Faggioli
2017-06-09 10:59 ` Jan Beulich
2017-06-09 11:17 ` Dario Faggioli
2017-06-09 11:29 ` Jan Beulich
2017-06-01 17:35 ` [PATCH 13/15] tools: tracing: handle tasklets events in xentrace and xenalyze Dario Faggioli
2017-06-01 17:35 ` [PATCH 14/15] xen: trace timers Dario Faggioli
2017-06-01 17:35 ` [PATCH 15/15] tools: tracing: handle timers events in xentrace and xenalyze Dario Faggioli
2017-06-07 14:13 ` [PATCH 00/15] xen/tools: add tracing to various Xen subsystems Konrad Rzeszutek Wilk
2017-06-08 16:45 ` Dario Faggioli
2017-06-13 16:34 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=978237fc-b9dd-d304-8132-956d1d6331e6@arm.com \
--to=julien.grall@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jennifer.herbert@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).