From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
"Julien Grall" <jgrall@amazon.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Ian Jackson" <ian.jackson@eu.citrix.com>, "Wei Liu" <wl@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [RESEND][PATCH v2 6/7] xen/guest_access: Consolidate guest access helpers in xen/guest_access.h
Date: Fri, 14 Aug 2020 20:14:38 +0100 [thread overview]
Message-ID: <9850d74b-7ec1-7c11-7093-2cc0b69ec2af@xen.org> (raw)
In-Reply-To: <17a7da1c-78eb-a86b-85f1-2372af93476e@suse.com>
Hi Jan,
On 31/07/2020 12:45, Jan Beulich wrote:
> On 30.07.2020 20:18, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Most of the helpers to access guest memory are implemented the same way
>> on Arm and x86. The only differences are:
>> - guest_handle_{from, to}_param(): while on x86 XEN_GUEST_HANDLE()
>> and XEN_GUEST_HANDLE_PARAM() are the same, they are not on Arm. It
>> is still fine to use the Arm implementation on x86.
>
> Is the description stale? I don't think there's any guest_handle_from_param()
> anymore.
Yes, I forgot you removed it. I will update the commit message.
>
>> - __clear_guest_offset(): Interestingly the prototype does not match
>> between the x86 and Arm. However, the Arm one is bogus. So the x86
>> implementation can be used.
>> - guest_handle{,_subrange}_okay(): They are validly differing
>> because Arm is only supporting auto-translated guest and therefore
>> handles are always valid.
>>
>> In the past, the ia64 and ppc64 port use a different model to access
>> guest parameter. They have been long gone now.
>>
>> Given Xen currently only support 2 archictures, it is too soon to have a
>> directory asm-generic as it is not possible to differentiate it with the
>> existing directory xen/. If/When there is a 3rd port, we can decide to
>> create the new directory if that new port decide to use a different way
>> to access guest parameter.
>>
>> For now, consolidate it in xen/guest_access.h.
>>
>> While it would be possible to adjust the coding style at the same, this
>> is left for a follow-up patch so 'diff' can be used to check the
>> consolidation was done correctly.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>
> Apart from the above
> Acked-by: Jan Beulich <jbeulich@suse.com>
Thanks!
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2020-08-14 19:15 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 18:18 [RESEND][PATCH v2 0/7] xen: Consolidate asm-*/guest_access.h in xen/guest_access.h Julien Grall
2020-07-30 18:18 ` [RESEND][PATCH v2 1/7] xen/guest_access: Add emacs magics Julien Grall
2020-07-31 13:04 ` Bertrand Marquis
2020-08-14 18:36 ` Julien Grall
2020-09-22 10:05 ` Volodymyr Babchuk
2020-07-30 18:18 ` [RESEND][PATCH v2 2/7] xen/arm: kernel: Re-order the includes Julien Grall
2020-07-30 19:36 ` Stefano Stabellini
2020-07-31 12:58 ` Bertrand Marquis
2020-07-30 18:18 ` [RESEND][PATCH v2 3/7] xen/arm: decode: " Julien Grall
2020-07-30 19:37 ` Stefano Stabellini
2020-08-14 18:40 ` Julien Grall
2020-07-30 18:18 ` [RESEND][PATCH v2 4/7] xen/arm: guestcopy: " Julien Grall
2020-07-30 19:37 ` Stefano Stabellini
2020-07-31 12:53 ` Bertrand Marquis
2020-07-31 12:56 ` Bertrand Marquis
2020-08-14 18:50 ` Julien Grall
2020-07-30 18:18 ` [RESEND][PATCH v2 5/7] xen: include xen/guest_access.h rather than asm/guest_access.h Julien Grall
2020-07-30 19:37 ` Stefano Stabellini
2020-07-31 11:36 ` Jan Beulich
2020-08-14 19:07 ` Julien Grall
2020-08-18 8:50 ` Jan Beulich
2020-08-18 8:58 ` Julien Grall
2020-08-18 9:05 ` Bertrand Marquis
2020-08-18 9:23 ` Julien Grall
2020-08-18 9:29 ` Bertrand Marquis
2020-08-18 11:32 ` Jan Beulich
2020-08-18 13:14 ` Julien Grall
2020-08-18 16:04 ` Jan Beulich
2020-08-18 16:20 ` Julien Grall
2020-08-18 16:23 ` Jan Beulich
2020-08-18 16:34 ` Julien Grall
2020-07-31 12:45 ` Bertrand Marquis
2020-07-31 12:45 ` Bertrand Marquis
2020-09-18 18:39 ` Julien Grall
2020-09-21 15:32 ` Paul Durrant
2020-07-30 18:18 ` [RESEND][PATCH v2 6/7] xen/guest_access: Consolidate guest access helpers in xen/guest_access.h Julien Grall
2020-07-30 19:37 ` Stefano Stabellini
2020-08-14 19:10 ` Julien Grall
2020-07-31 11:45 ` Jan Beulich
2020-08-14 19:14 ` Julien Grall [this message]
2020-07-30 18:18 ` [RESEND][PATCH v2 7/7] xen/guest_access: Fix coding style " Julien Grall
2020-07-30 19:38 ` Stefano Stabellini
2020-07-31 11:41 ` Jan Beulich
2020-08-14 19:18 ` Julien Grall
2020-08-18 8:52 ` Jan Beulich
2020-08-18 9:03 ` Julien Grall
2020-07-31 12:46 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9850d74b-7ec1-7c11-7093-2cc0b69ec2af@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgrall@amazon.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).