From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 289C4C433DB for ; Mon, 29 Mar 2021 09:23:32 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D12AC61934 for ; Mon, 29 Mar 2021 09:23:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D12AC61934 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.102896.196423 (Exim 4.92) (envelope-from ) id 1lQo76-0003NK-Mo; Mon, 29 Mar 2021 09:23:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 102896.196423; Mon, 29 Mar 2021 09:23:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQo76-0003ND-JW; Mon, 29 Mar 2021 09:23:12 +0000 Received: by outflank-mailman (input) for mailman id 102896; Mon, 29 Mar 2021 09:23:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQo75-0003N8-Jd for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 09:23:11 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 19ae104a-046d-4999-80d7-5804b1253dbb; Mon, 29 Mar 2021 09:23:10 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C19E5B3C6; Mon, 29 Mar 2021 09:23:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19ae104a-046d-4999-80d7-5804b1253dbb X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617009789; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VcBuQRcfoLaKj/rPC16xUMpz+pqVC9dTsmVWLgRfSjs=; b=RHfeSWAQvj09PGdgSBGuFA9Yi59wQK5jj9tFRpM0TpiBPIT4TQnT6eETo2xcJ1uLyrI6yN ZCMiUEGjQdDa76/M/o0UMC5HT5Ix16QgxdthnD6XiQV873QtBtH5qGhrhgRgrCDFlVd9oS nH8HYhA6k1atv8ppgPWpRrI47yYCc0s= Subject: Re: [PATCH v2 3/3] x86/hpet: Restore old configuration if Legacy Replacement mode doesn't help To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , =?UTF-8?B?RnLDqWTDqXJpYyBQaWVycmV0?= , Xen-devel References: <20210326185947.23243-1-andrew.cooper3@citrix.com> <20210326185947.23243-4-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <9916882e-c31b-4943-13b5-702380325ae1@suse.com> Date: Mon, 29 Mar 2021 11:23:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210326185947.23243-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 26.03.2021 19:59, Andrew Cooper wrote: > If Legacy Replacement mode doesn't help in check_timer(), restore the old > configuration before falling back to other workarounds. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Ian Jackson > CC: Marek Marczykowski-Górecki > CC: Frédéric Pierret > > v2: > * New. > > For 4.15: Attempt to unbreak AMD Ryzen 1800X systems. > > I'm tempted to fold this into the previous patch, but its presented here in > isolation for ease of review. Both combined Reviewed-by: Jan Beulich (i.e. I think they strictly should be folded). Just as a (further) consideration: While I continue to think that undoing immediately is what we want, I wonder whether every further fallback attempt wouldn't want to also be accompanied by trying if it _combined_ with legacy replacement mode actually helps if alone it didn't. Perhaps we want to cross that bridge only if we get a respective report ... Jan