From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9FFBC433EF for ; Sun, 7 Nov 2021 17:08:49 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57D8061354 for ; Sun, 7 Nov 2021 17:08:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 57D8061354 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.222834.385217 (Exim 4.92) (envelope-from ) id 1mjleZ-0003D5-Rt; Sun, 07 Nov 2021 17:08:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 222834.385217; Sun, 07 Nov 2021 17:08:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mjleZ-0003Cy-Ou; Sun, 07 Nov 2021 17:08:23 +0000 Received: by outflank-mailman (input) for mailman id 222834; Sun, 07 Nov 2021 17:08:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mjleY-0003Cs-BZ for xen-devel@lists.xenproject.org; Sun, 07 Nov 2021 17:08:22 +0000 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [2607:f8b0:4864:20::22a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e4b61b3-3fed-11ec-a9d2-d9f7a1cc8784; Sun, 07 Nov 2021 18:08:20 +0100 (CET) Received: by mail-oi1-x22a.google.com with SMTP id u2so23850756oiu.12 for ; Sun, 07 Nov 2021 09:08:20 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id i18sm3076850oik.6.2021.11.07.09.08.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Nov 2021 09:08:18 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 4e4b61b3-3fed-11ec-a9d2-d9f7a1cc8784 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tdjg7OFm02RxoZkWdNYUJLWTVIAPxTK8o9TtiXrumos=; b=TxOMGGlgYCG6dkxhcHrWleMH5bQzzwXZ9FgwNICO938yYvOADrHCJxaIH+GmktBmdj VF/g/5abCbj1SCo77l//+Q8ZaEKZ59DzYbLYNazQAh1d/LI9QSnOgttApF1NrD9BSZdp gXEIPq4X5WBftSdrWeIB1XoHAUTyRVaiGJM3hjDVKwLTIaIl/5BV9x60u06nn/MoayP2 XKdxX9rsONJssDlEkPGWyc5+2eLAU/A93X+4aNShdnC/nVsO9kvbYnMJEh3NiFo/gq2s n/ryBqjSn/iug4O0nxdm910/aVIInOrXjz5uU8hb+PebuTd+WVfeeVeSdkkUcfpq82Ph 3xyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tdjg7OFm02RxoZkWdNYUJLWTVIAPxTK8o9TtiXrumos=; b=loeUjSdhahkA2Oav57QEVZ2vvARIcce/npACZWEndFPu8nYExAZqFtrGnLkbiazxSy Xj2+JY4vqMY3BCl3Wjds0s9GX/mxjfWqaR3RAQFfpDBk8d7N5dYJFKXmqmJEkqqNFmJS yFe3BM00q2bnJu4LXn682sfWjEYoX5nVBOrI94bzHp9+RFTaity8nDsCttEHKWIF4egh DVOQfy6ic2E835xI/hvhIQplmU5aJ8rNrtNfNKusUCloBobbhQKZWSdb/KUl0HDU+REF GAaWTOCGmoHqIePTMX0XgWWOpgLJjcoEpxGfq4p2hDdxJx+gKhsqVUV3NCNt/UAfRAal FOeA== X-Gm-Message-State: AOAM531atwfa3O+oiXyziOuAp+/v7XGNGx8JUA5phDZsAFCZH0nZGHkG BFAV1p4VHxMYimXqNN0SSy0= X-Google-Smtp-Source: ABdhPJwtuSZgtmAkEs0Dks9+MnuUhljSkzaFgRaxP+iMBCUUKLEs54Fh1SgZ30w0yfdl8sLFhcnMyg== X-Received: by 2002:a05:6808:158a:: with SMTP id t10mr3003509oiw.24.1636304899015; Sun, 07 Nov 2021 09:08:19 -0800 (PST) Sender: Guenter Roeck Subject: Re: [PATCH v2 27/45] mfd: ntxec: Use devm_register_power_handler() To: Dmitry Osipenko , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= Cc: Thierry Reding , Jonathan Hunter , Lee Jones , "Rafael J . Wysocki" , Mark Brown , Andrew Morton , Russell King , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Nick Hu , Greentime Hu , Vincent Chen , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Linus Walleij , Chen-Yu Tsai , Tony Lindgren , Liam Girdwood , Philipp Zabel , Vladimir Zapolskiy , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Pavel Machek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, linux-omap@vger.kernel.org, openbmc@lists.ozlabs.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org References: <20211027211715.12671-1-digetx@gmail.com> <20211027211715.12671-28-digetx@gmail.com> From: Guenter Roeck Message-ID: <9a22c22d-94b1-f519-27a2-ae0b8bbf6e99@roeck-us.net> Date: Sun, 7 Nov 2021 09:08:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 11/7/21 8:53 AM, Dmitry Osipenko wrote: > 06.11.2021 23:54, Jonathan Neuschäfer пишет: >> Hi, >> >> On Thu, Oct 28, 2021 at 12:16:57AM +0300, Dmitry Osipenko wrote: >>> Use devm_register_power_handler() that replaces global pm_power_off >>> variable and allows to register multiple power-off handlers. It also >>> provides restart-handler support, i.e. all in one API. >>> >>> Signed-off-by: Dmitry Osipenko >>> --- >> >> When I boot with (most of) this patchset applied, I get the warning at >> kernel/reboot.c:187: >> >> /* >> * Handler must have unique priority. Otherwise call order is >> * determined by registration order, which is unreliable. >> */ >> WARN_ON(!atomic_notifier_has_unique_priority(&restart_handler_list, nb)); >> >> As the NTXEC driver doesn't specify a priority, I think this is an issue >> to be fixed elsewhere. >> >> Other than that, it works and looks good, as far as I can tell. >> >> >> For this patch: >> >> Reviewed-by: Jonathan Neuschäfer >> Tested-by: Jonathan Neuschäfer > > Thank you. You have conflicting restart handlers, apparently NTXEC > driver should have higher priority than the watchdog driver. It should > be a common problem for the watchdog drivers, I will lower watchdog's > default priority to fix it. > The watchdog subsystem already uses "0" as default priority, which was intended as priority of last resort for restart handlers. I do not see a reason to change that. Guenter