From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D1BC433B4 for ; Tue, 18 May 2021 03:58:50 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23430611AD for ; Tue, 18 May 2021 03:58:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23430611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.128579.241368 (Exim 4.92) (envelope-from ) id 1liqsE-0006Dd-9Y; Tue, 18 May 2021 03:58:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 128579.241368; Tue, 18 May 2021 03:58:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1liqsE-0006DW-4k; Tue, 18 May 2021 03:58:26 +0000 Received: by outflank-mailman (input) for mailman id 128579; Tue, 18 May 2021 03:58:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1liqsC-0006DQ-KG for xen-devel@lists.xenproject.org; Tue, 18 May 2021 03:58:24 +0000 Received: from mail-oi1-x22d.google.com (unknown [2607:f8b0:4864:20::22d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a30a1820-66a7-4c1b-a7b5-cf6f638c39e7; Tue, 18 May 2021 03:58:23 +0000 (UTC) Received: by mail-oi1-x22d.google.com with SMTP id u144so8514437oie.6 for ; Mon, 17 May 2021 20:58:23 -0700 (PDT) Received: from [192.168.99.80] (142-79-211-230.starry-inc.net. [142.79.211.230]) by smtp.gmail.com with ESMTPSA id e22sm3578062otl.74.2021.05.17.20.58.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 May 2021 20:58:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a30a1820-66a7-4c1b-a7b5-cf6f638c39e7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=aFBMoqSfZ2tjkO3rtPY9w47poNJ9sXu+3W96WXkUC0s=; b=nsno12JfrqerkfpE8sQT+RQdrmQOKRgo5QtWNSMgtRUp4ywL9YW3i7Hfiim7GLZJhu sCjV5k1ftysZLQCwTvzbw1prKDsG7YoQXmgTkS8w/xS59D1WvBEcNpr0X8zkcJX0ssJe wExgGr+wNi5tLg2EUzEBPkv1os6yIkOq0s1xEgWfXAG0SdfGFBGGIDiSvldQvSPO2zr1 W8gdpgbySZT+v5ceJaOizp5O00cQqDf8M3vlahkVBdyLEHC4G0juZ/jYN00oriHQdy6D iW7iRAGWEV4ol6TVty70t3XsTVGxZfJSbQCcUREdGx4C4Zo1B2rjOSDBea+jd9msVOa4 GSDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=aFBMoqSfZ2tjkO3rtPY9w47poNJ9sXu+3W96WXkUC0s=; b=DzdCShWjXQn9htW0XU3+DtKwm5lJLvzxTfouT4LbVLNNoOsUwytyiUMKD6/CAPcQq4 ZnYPyAF3RPmrUu7Eukl5glChOpo4R3IjwZ5OJy1nZhyjieLTekceVfPqeKqaowrqYUKC F8mDXJA4jbRxu7Rt/rxpSdWcd/aQiQxar/O5RN1PWTNa1CXPl6R8yB7MmuMeRMAnP402 tlMyzKazIokYHDE9VtegcdqMGuA46QZg9wjYSrWLPU+0nstAT4WbD41fJIv9Nze9IzjC KrmwGZNW/fhl0FMjvq9T0wW/I809z3/tyo3/c3qSRNLJdDEWuA+zL31E++aewOSFEmbn wFLQ== X-Gm-Message-State: AOAM530fXv7+UsiQ831cyLCPvHtRtGssLUaEcSddePBDHog1NFXEKVVx mcVLvlHkmxINsP4pEWBNX0sGHBaFB6oH2Q== X-Google-Smtp-Source: ABdhPJw7VedbAGRfDlbn81vO0pJOcGWUFfarg28s2qv+sJ0ZXg2pZfTanVK9BSeKm7xUHY5KAZe9NQ== X-Received: by 2002:a05:6808:4d3:: with SMTP id a19mr1914349oie.40.1621310302845; Mon, 17 May 2021 20:58:22 -0700 (PDT) Subject: Re: [PATCH v3 3/5] xen: Fix build when !CONFIG_GRANT_TABLE To: Jan Beulich Cc: Bobby Eshleman , Alistair Francis , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <834f7995ae80a3b37b6d508d1c989b4ee391f61b.1621017334.git.connojdavis@gmail.com> From: Connor Davis Message-ID: <9b231486-bdf8-d6a7-c9c6-126d5bc207f8@gmail.com> Date: Mon, 17 May 2021 21:58:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 5/17/21 5:22 AM, Jan Beulich wrote: > On 14.05.2021 20:53, Connor Davis wrote: >> Move struct grant_table; in grant_table.h above >> ifdef CONFIG_GRANT_TABLE. This fixes the following: >> >> /build/xen/include/xen/grant_table.h:84:50: error: 'struct grant_table' >> declared inside parameter list will not be visible outside of this >> definition or declaration [-Werror] >> 84 | static inline int mem_sharing_gref_to_gfn(struct grant_table *gt, >> | > There must be more to this, as e.g. the PV shim does get built with > !GRANT_TABLE. Nevertheless, ... > Can you elaborate? I tested all defconfigs with and without grant tables enabled on x86 and ARM and they all build fine. >> Signed-off-by: Connor Davis > ... since the potential of breaking the build is obvious enough, > Acked-by: Jan Beulich > > Jan Thanks, Connor