From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06E80C2B9F8 for ; Tue, 25 May 2021 11:14:08 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE56F6140A for ; Tue, 25 May 2021 11:14:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE56F6140A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.132166.246630 (Exim 4.92) (envelope-from ) id 1llV0a-0001sa-Hc; Tue, 25 May 2021 11:14:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 132166.246630; Tue, 25 May 2021 11:14:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1llV0a-0001sT-EQ; Tue, 25 May 2021 11:14:00 +0000 Received: by outflank-mailman (input) for mailman id 132166; Tue, 25 May 2021 11:13:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1llV0Z-0001sN-8i for xen-devel@lists.xenproject.org; Tue, 25 May 2021 11:13:59 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 78aa0667-91da-408f-a020-b12d293453ee; Tue, 25 May 2021 11:13:58 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 606F4AEA6; Tue, 25 May 2021 11:13:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78aa0667-91da-408f-a020-b12d293453ee X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1621941237; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rv207fLaLWRJKi9gCOwrDZlK6sibJ4OFHXI9bbsEKFQ=; b=S37P6LAf0YxBNH5mUXNJEGRt3kEYs2VbCzq4W72pj6cny2HFdgC4X2/0N0m8QYHjsuvYCt t/BvAu1gTanJJDbmrvl9ts9JMUgme9Duu0kgPJBkkfVkzb7xJiRdV9fplTEazS0UIleagF wMUj6zM5Cph6InvMSo80pqyqAG4QMqU= From: Jan Beulich Subject: =?UTF-8?Q?Ping=c2=b2=3a_=5bPATCH=5d_x86=3a_fix_build_race_when_gene?= =?UTF-8?Q?rating_temporary_object_files_=28take_2=29?= To: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Ian Jackson Cc: "xen-devel@lists.xenproject.org" References: Message-ID: <9c132221-74ba-8f18-3c89-3fbbdb3c58b5@suse.com> Date: Tue, 25 May 2021 13:13:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.04.2021 11:54, Jan Beulich wrote: > The original commit wasn't quite sufficient: Emptying DEPS is helpful > only when nothing will get added to it subsequently. xen/Rules.mk will, > after including the local Makefile, amend DEPS by dependencies for > objects living in sub-directories though. For the purpose of suppressing > dependencies of the makefiles on the .*.d2 files (and thus to avoid > their re-generation) it is, however, not necessary at all to play with > DEPS. Instead we can override DEPS_INCLUDE (which generally is a late- > expansion variable). > > Fixes: 761bb575ce97 ("x86: fix build race when generating temporary object files") > Signed-off-by: Jan Beulich Ping (again)? I'll give it till Wednesday, and if I don't hear back, I'll commit without any acks. Ian, I'm also including you here because iirc the .*.d2 thing was an invention of yours, so you may have an opinion. Jan > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -314,5 +314,5 @@ clean:: > # Suppress loading of DEPS files for internal, temporary target files. This > # then also suppresses re-generation of the respective .*.d2 files. > ifeq ($(filter-out .xen%.o,$(notdir $(MAKECMDGOALS))),) > -DEPS:= > +DEPS_INCLUDE:= > endif >