xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH XTF] tests: add fep test
Date: Mon, 20 Jun 2016 14:43:47 +0100	[thread overview]
Message-ID: <9f7f768a-93c0-167d-365a-5e6be546f8c4@citrix.com> (raw)
In-Reply-To: <1466173280-23797-1-git-send-email-wei.liu2@citrix.com>

On 17/06/16 15:21, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

LGTM, although a couple of comments.

> ---
>  tests/fep/Makefile | 12 ++++++++++++
>  tests/fep/main.c   | 31 +++++++++++++++++++++++++++++++

Please add this to the test index in docs/all-tests.dox

>  2 files changed, 43 insertions(+)
>  create mode 100644 tests/fep/Makefile
>  create mode 100644 tests/fep/main.c
>
> diff --git a/tests/fep/Makefile b/tests/fep/Makefile
> new file mode 100644
> index 0000000..8702123
> --- /dev/null
> +++ b/tests/fep/Makefile
> @@ -0,0 +1,12 @@
> +MAKEFLAGS += -r
> +ROOT := $(abspath $(CURDIR)/../..)
> +
> +include $(ROOT)/build/common.mk
> +
> +NAME      := fep
> +CATEGORY  := utility
> +TEST-ENVS := $(HVM_ENVIRONMENTS)

This really doesn't need to be all HVM environments.  FEP is a property
of the HVM container, not of the running mode of the domain.  hvm32
would be fine here, and the most simple option.

> +
> +obj-perenv += main.o
> +
> +include $(ROOT)/build/gen.mk
> diff --git a/tests/fep/main.c b/tests/fep/main.c
> new file mode 100644
> index 0000000..34a93c0
> --- /dev/null
> +++ b/tests/fep/main.c
> @@ -0,0 +1,31 @@
> +/**
> + * @file tests/fep/main.c
> + * @ref test-fep
> + *
> + * @page test-fep FEP
> + *
> + * Returns SUCCESS if FEP is available, FAILURE if not.

This is the content one will find from the test index, and as such,
should be the most complete.  At the very least, I would add a sentence
explaining what FEP is.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-20 13:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17 14:21 Wei Liu
2016-06-20 13:43 ` Andrew Cooper [this message]
2016-06-20 14:31   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f7f768a-93c0-167d-365a-5e6be546f8c4@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH XTF] tests: add fep test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).