From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>,
<x86@kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 1/4] x86/xen: remove 32-bit Xen PV guest support
Date: Fri, 3 Jul 2020 00:24:06 +0100 [thread overview]
Message-ID: <9f8cc440-82f0-d6d8-945d-19c48f69a6b0@citrix.com> (raw)
In-Reply-To: <6d0b517a-6c53-61d3-117b-40e33e013037@oracle.com>
On 02/07/2020 23:59, Boris Ostrovsky wrote:
> On 7/1/20 7:06 AM, Juergen Gross wrote:
>>
>> -#ifdef CONFIG_X86_PAE
>> -static void xen_set_pte_atomic(pte_t *ptep, pte_t pte)
>> -{
>> - trace_xen_mmu_set_pte_atomic(ptep, pte);
>> - __xen_set_pte(ptep, pte);
>
> Probably not for this series but I wonder whether __xen_set_pte() should
> continue to use hypercall now that we are 64-bit only.
The hypercall path is a SYSCALL (and SYSRET out).
The "writeable" PTE path is a #PF, followed by an x86 instruction
emulation, which then reaches the same logic as the hypercall path (and
an IRET out).
~Andrew
next prev parent reply other threads:[~2020-07-02 23:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 11:06 [PATCH v2 0/4] Remove 32-bit Xen PV guest support Juergen Gross
2020-07-01 11:06 ` [PATCH v2 1/4] x86/xen: remove " Juergen Gross
2020-07-01 16:33 ` Brian Gerst
2020-07-02 22:59 ` Boris Ostrovsky
2020-07-02 23:24 ` Andrew Cooper [this message]
2020-07-02 23:27 ` Boris Ostrovsky
2020-07-03 5:15 ` Jürgen Groß
2020-07-01 11:06 ` [PATCH v2 2/4] x86/paravirt: remove 32-bit support from PARAVIRT_XXL Juergen Gross
2020-07-01 11:06 ` [PATCH v2 3/4] x86/paravirt: cleanup paravirt macros Juergen Gross
2020-07-01 11:06 ` [PATCH v2 4/4] x86/paravirt: use CONFIG_PARAVIRT_XXL instead of CONFIG_PARAVIRT Juergen Gross
2020-07-02 8:18 ` [PATCH v2 0/4] Remove 32-bit Xen PV guest support Peter Zijlstra
2020-07-02 14:48 ` Brian Gerst
2020-07-02 15:45 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f8cc440-82f0-d6d8-945d-19c48f69a6b0@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).