From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5538C433ED for ; Tue, 13 Apr 2021 18:19:44 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B5C46052B for ; Tue, 13 Apr 2021 18:19:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B5C46052B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.110091.210136 (Exim 4.92) (envelope-from ) id 1lWNdG-00087U-Jq; Tue, 13 Apr 2021 18:19:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 110091.210136; Tue, 13 Apr 2021 18:19:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWNdG-00087N-Gt; Tue, 13 Apr 2021 18:19:26 +0000 Received: by outflank-mailman (input) for mailman id 110091; Tue, 13 Apr 2021 18:19:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWNdF-00087I-0c for xen-devel@lists.xenproject.org; Tue, 13 Apr 2021 18:19:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWNdD-00018u-GE; Tue, 13 Apr 2021 18:19:23 +0000 Received: from [54.239.6.186] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lWNdD-0003QO-83; Tue, 13 Apr 2021 18:19:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=uHo4OxMK6flwM207WY7VYnJ0W6uAPtprU6t4eOqXek8=; b=FV0JnJisldGm5Wiw1uBa5bMKUm AvkVvbphaUUS+nW1HwoFJuYtR62Uke181sGjymVvcHBdJyYw1c18/dQgLmXztZrJR8iPkfugwRJYO tJ4Anm5szKL65xE/D8Pmkc5tGOIHGOG0yS17PRWdHd4HBti+K3LphIEaxVfQxPW5+heM=; Subject: Re: [PATCH 11/11] Arm/optee: don't open-code xzalloc_flex_struct() To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Stefano Stabellini , Volodymyr Babchuk References: From: Julien Grall Message-ID: <9f95c37b-dc4a-d2cf-01c1-98d2108fae88@xen.org> Date: Tue, 13 Apr 2021 19:19:21 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 08/04/2021 13:23, Jan Beulich wrote: > There is a difference in generated code: xzalloc_bytes() forces > SMP_CACHE_BYTES alignment. I think we not only don't need this here, but > actually don't want it. So I think moving to xmalloc_flex_struct() is a pretty good move. But I am actually a bit confused with the argument used. Could you provide some details why you think forcing the array to be aligned to the maximum cache line supported (128 bytes on Arm) is wrong? Cheers, -- Julien Grall