From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tian, Kevin" <kevin.tian@intel.com>
Subject: Re: [PATCH] dmar: Fix double free in error paths
 following c/s a8bc99b
Date: Mon, 20 Jul 2015 01:31:47 +0000
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D1262CC75A@SHSMSX101.ccr.corp.intel.com>
References: <1437047823-24686-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1437047823-24686-1-git-send-email-andrew.cooper3@citrix.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>, "Zhang,
	Yang Z" <yang.z.zhang@intel.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

> From: Andrew Cooper [mailto:andrew.cooper3@citrix.com]
> Sent: Thursday, July 16, 2015 7:57 PM
> 
> Several error paths would end up freeing scope->devices twice.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> CC: Yang Zhang <yang.z.zhang@intel.com>
> CC: Kevin Tian <kevin.tian@intel.com>

Acked-by: Kevin Tian <kevin.tian@intel.com>

> ---
>  xen/drivers/passthrough/vtd/dmar.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c
> index 8ed1e24..2672688 100644
> --- a/xen/drivers/passthrough/vtd/dmar.c
> +++ b/xen/drivers/passthrough/vtd/dmar.c
> @@ -88,6 +88,7 @@ static void scope_devices_free(struct dmar_scope *scope)
> 
>      scope->devices_cnt = 0;
>      xfree(scope->devices);
> +    scope->devices = NULL;
>  }
> 
>  static void __init disable_all_dmar_units(void)
> --
> 1.7.10.4