From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tian, Kevin" <kevin.tian@intel.com>
Subject: Re: [PATCH v2] VT-d: add iommu=igfx option to
 workaround graphics issues
Date: Fri, 31 Jul 2015 01:26:48 +0000
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D142AB6F79@SHSMSX101.ccr.corp.intel.com>
References: <55ACD1940200007800092EF8@mail.emea.novell.com>
	<1437843452-12126-1-git-send-email-lantw44@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1437843452-12126-1-git-send-email-lantw44@gmail.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ting-Wei Lan <lantw44@gmail.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>, Julien Grall <julien.grall@citrix.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
List-Id: xen-devel@lists.xenproject.org

> From: Ting-Wei Lan [mailto:lantw44@gmail.com]
> Sent: Sunday, July 26, 2015 12:58 AM
> 
> When using Linux >= 3.19 (commit 47591df) as dom0 on some Intel Ironlake
> devices, It is possible to encounter graphics issues that make screen
> unreadable or crash the system. It was reported in freedesktop bugzilla:
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=90037
> 
> As we still cannot find a proper fix for this problem, this patch adds
> iommu=igfx option to control whether Intel graphics IOMMU is enabled on
> these devices. Running Xen with iommu=no-igfx is similar to running
> Linux with intel_iommu=igfx_off, which disables IOMMU for Intel Ironlake
> GPU. This can be used by users to manually workaround the problem before
> a fix is available for i915 driver.
> 
> Signed-off-by: Ting-Wei Lan <lantw44@gmail.com>
> ---
> Changed since v1:
>   * Replace igfx_off with igfx
> 
> This patch is currently only build-tested because I don't have access to
> the hardware that have graphics issues this week. I will test this new
> patch next week.
> 
>  docs/misc/xen-command-line.markdown  | 12 +++++++++++-
>  xen/drivers/passthrough/iommu.c      |  3 +++
>  xen/drivers/passthrough/vtd/quirks.c |  2 +-
>  xen/include/xen/iommu.h              |  2 +-
>  4 files changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/misc/xen-command-line.markdown
> b/docs/misc/xen-command-line.markdown
> index 13f03ad..6262be6 100644
> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -793,7 +793,7 @@ debug hypervisor only).
>  > Default: `new` unless directed-EOI is supported
> 
>  ### iommu
> -> `= List of [ <boolean> | force | required | intremap | qinval | snoop | sharept |
> dom0-passthrough | dom0-strict | amd-iommu-perdev-intremap | workaround_bios_bug
> | verbose | debug ]`
> +> `= List of [ <boolean> | force | required | intremap | qinval | snoop | sharept |
> dom0-passthrough | dom0-strict | amd-iommu-perdev-intremap | workaround_bios_bug
> | igfx | verbose | debug ]`
> 
>  > Sub-options:
> 
> @@ -867,6 +867,16 @@ debug hypervisor only).
>  >> ignored (normally IOMMU setup fails if any of the devices listed by a DRHD
>  >> entry aren't PCI discoverable).
> 
> +> `igfx` (VT-d)
> +
> +> Default: `true`
> +
> +>> Enable IOMMU for Intel Calpella/Ironlake devices. This option does not
> +>> affect grahpics IOMMU on other devices. The intended usage of this option
> +>> is `no-igfx`, which is silimar to Linux `intel_iommu=igfx_off` option used
> +>> to workaround graphics issues. If adding `no-igfx` fixes anything, you
> +>> should file a bug reporting the problem.
> +

For above description let's make it general, i.e Enable IOMMU for Intel Processor
Graphics devices. You can list Calpella/Ironlake as the example, but not the only
target. :-)

Thanks
Kevin