From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tian, Kevin" Subject: Re: [PATCH v2 1/2] IOMMU/spinlock: Fix a bug found in AMD IOMMU initialization. Date: Wed, 9 Mar 2016 05:19:24 +0000 Message-ID: References: <1457492889-36625-1-git-send-email-quan.xu@intel.com> <1457492889-36625-2-git-send-email-quan.xu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1457492889-36625-2-git-send-email-quan.xu@intel.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: "xen-devel@lists.xen.org" Cc: "Xu, Quan" , Dario Faggioli , Suravee Suthikulpanit , Jan Beulich List-Id: xen-devel@lists.xenproject.org PiBGcm9tOiBRdWFuIFh1DQo+IFNlbnQ6IFdlZG5lc2RheSwgTWFyY2ggMDksIDIwMTYgMTE6MDgg QU0NCg0KSGksIFF1YW4sIHNvcnJ5IHRoYXQgSSBzdGlsbCBkaWRuJ3QgcXVpdGUgZ2V0IGJlbG93 IGRlc2NyaXB0aW9uLg0KDQo+IA0KPiBXaGVuIGlvbW11X3NldHVwKCkgaXMgY2FsbGVkIGluIF9f c3RhcnRfeGVuKCksIGludGVycnVwdHMgaGF2ZQ0KPiBhbHJlYWR5IGJlZW4gZW5hYmxlZCwgYW5k IG5vdGhpbmcgZGlzYWJsZXMgKHdpdGhvdXQgcmVlbmFibGluZykNCj4gdGhlbSBhZ2FpbiBpbiB0 aGUgcGF0aCB0aGF0IGxlYWRzIHRvIGNhbGxpbmcNCj4gc2V0X2lvbW11X2ludGVycnVwdF9oYW5k bGVyKCkuIFRoZXJlJ3MgdGhlcmVmb3JlIG5vIHJpc2sgb2YgdGhlbQ0KPiBiZWluZyBkaXNhYmxl ZCBhbmQgbmVlZGluZyByZW1haW5pbmcgc28sIGFuZCBoZW5jZSBubyBuZWVkIGZvcg0KDQpubyBy aXNrIG9mIHRoZW0gYmVpbmcgJ2VuYWJsZWQnIHNpbmNlIG5vIG9uZSBkaXNhYmxlcyB0aGVtIGFn YWluPw0KDQo+IHNhdmluZyBhbmQgcmVzdG9yaW5nIHRoZSBmbGFncy4gVGhpcyBtZWFucyB0aGF0 LCBldmVuIGlmIGludGVycnVwdA0KPiB3b3VsZCBuZWVkIHRvIGJlIGRpc2FibGVkIHdoZW4gdGFr aW5nIHBjaWRldnNfbG9jaywgc3Bpbl9sb2NrX2lycSgpDQo+IGFuZCBzcGluX3VubG9ja19pcnEo KSBjb3VsZCBiZSB1c2VkLg0KDQpJIGRpZG4ndCBzZWUgaG93IHRoaXMgZXhwbGFuYXRpb24gcmVs YXRlcyB0byBiZWxvdyBjaGFuZ2UuIFlvdSBhcmUNCmNoYW5naW5nIGZyb20gc3Bpbl9sb2NrX2ly cXNhdmUgdG8gc3Bpbl9sb2NrLiBCdXQgaGVyZSB5b3UgZXhwbGFpbnMNCnRoZSByZWFzb24gdG8g c3Bpbl9sb2NrX2lycS4uLg0KDQo+IA0KPiBJbnNpZGUgc2V0X2lvbW11X2ludGVycnVwdF9oYW5k bGVyKCksIHBjaWRldnNfbG9jayBzZXJpYWxpemVzIGNhbGxzDQo+IHRvIHBjaV9nZXRfcGRldigp LCB3aGljaCBkb2VzIG5vdCByZXF1aXJlIGludGVycnVwdHMgdG8gYmUgZGlzYWJsZWQNCj4gZHVy aW5nIGl0cyBleGVjdXRpb24uIEluIGZhY3QsIHBjaWRldnNfbG9jayBpcyBhbHdheXMgKGV4Y2Vw dCBmb3INCj4gdGhpcyBjYXNlKSB0YWtlbiB3aXRob3V0IGRpc2FibGluZyBpbnRlcnJ1cHRzLCBh bmQgZGlzYWJsaW5nIHRoZW0gaW4NCj4gdGhpcyBjYXNlIHdvdWxkIG1ha2UgdGhlIEJVR19PTigp IGluIGNoZWNrX2xvY2soKSB0cmlnZ2VyLCBpZiBpdA0KPiB3YXNuJ3QgZm9yIHRoZSBmYWN0IHRo YXQgc3BpbmxvY2sgZGVidWdnaW5nIGNoZWNrcyBhcmUgc3RpbGwNCj4gZGlzYWJsZWQsIGR1cmlu ZyBpbml0aWFsaXphdGlvbiwgd2hlbiBpb21tdV9zZXR1cCgpICh3aGljaCB0aGVuIGVuZA0KPiB1 cCBjYWxsaW5nIHNldF9pb21tdV9pbnRlcnJ1cHRfaGFuZGxlcigpKSBpcyBjYWxsZWQuDQoNClRo ZSBrZXkgcHJvYmxlbSBpcyB0aGF0IHdlIG5lZWQgY29uc2lzdGVudCBsb2NrIHVzYWdlIGluIGFs bCBwbGFjZXMgDQooZWl0aGVyIGFsbCBpbiBJUlEtc2FmZSBvciBhbGwgaW4gSVJRLXVuc2FmZSks IHJlZ2FyZGxlc3Mgb2Ygd2hldGhlciANCmNoZWNrX2xvY2sgaXMgYWN0aXZhdGVkIG9yIG5vdCAo d2hpY2ggaXMganVzdCBhIGRlYnVnIG1ldGhvZCB0byBoZWxwDQppZGVudGlmeSBzdWNoIGluY29u c2lzdGVuY3kgcHJvYmxlbSkuIEkgdGhpbmsgaXQgc2hvdWxkIGJlIGNsZWFyIA0KZW5vdWdoIHRv IHN0YXRlIHRoYXQgcGNpX2dldF9wZGV2IGRvZXNuJ3QgcmVxdWlyZSBob2xkaW5nIGxvY2sgd2l0 aA0KaW50ZXJydXB0IGRpc2FibGVkIChzbyB3ZSBzaG91bGQgdXNlIHNwaW5fbG9jayBpbiB0aGlz IEFNRCBjYXNlKSwNCmFuZCBhZGQgdGhlIGZhY3QgdGhhdCB3aGVuIHRoaXMgZnVuY3Rpb24gaXMg aW52b2tlZCB0aGUgaW50ZXJydXB0DQppcyBpbmRlZWQgZW5hYmxlZC4NCg0KDQo+IA0KPiBJbiBv cmRlciB0byBmaXggdGhpcywgd2UgY2FuIHVzZSBqdXN0IHBsYWluIHNwaW5fbG9jaygpIGFuZCBz cGluX3VubG9jaygpLA0KPiBpbnN0ZWFkIG9mIHNwaW5fbG9ja19pcnFzYXZlKCkgYW5kIHNwaW5f dW5sb2NrX2lycXJlc3RvcmUoKS4NCg0KV2hhdCBhYm91dCByZXZpc2UgbGlrZSBiZWxvdz8NCi0t DQoNCnBjaWRldnNfbG9jayBzaG91bGQgYmUgaGVsZCB3aXRoIGludGVycnVwdCBlbmFibGVkLiBI b3dldmVyIHRoZXJlDQpyZW1haW5zIGFuIGV4Y2VwdGlvbiBpbiBBTUQgSU9NTVUgY29kZSwgd2hl cmUgdGhlIGxvY2sgaXMNCmFjcXVpcmVkIHdpdGggaW50ZXJydXB0IGRpc2FibGVkLiBUaGlzIGlu Y29uc2lzdGVuY3kgY2FuIGxlYWQgdG8gDQpkZWFkbG9jay4gDQoNClRoZSBmaXggaXMgc3RyYWln aHRmb3J3YXJkIHRvIHVzZSBzcGluX2xvY2sgaW5zdGVhZC4gQWxzbyBpbnRlcnJ1cHQNCmhhcyBi ZWVuIGVuYWJsZWQgd2hlbiB0aGlzIGZ1bmN0aW9uIGlzIGludm9rZWQsIHNvIHdlJ3JlIHN1cmUN CmNvbnNpc3RlbmN5IGFyb3VuZCBwY2lkZXZzX2xvY2sgY2FuIGJlIGd1YXJhbnRlZWQgYWZ0ZXIg dGhpcyBmaXguDQotLQ0KDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBRdWFuIFh1IDxxdWFuLnh1QGlu dGVsLmNvbT4NCj4gUmV2aWV3ZWQtYnk6IERhcmlvIEZhZ2dpb2xpIDxkYXJpby5mYWdnaW9saUBj aXRyaXguY29tPg0KPiBDQzogU3VyYXZlZSBTdXRoaWt1bHBhbml0IDxzdXJhdmVlLnN1dGhpa3Vs cGFuaXRAYW1kLmNvbT4NCj4gQ0M6IERhcmlvIEZhZ2dpb2xpIDxkYXJpby5mYWdnaW9saUBjaXRy aXguY29tPg0KPiBDQzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiAtLS0NCj4g IHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9pbml0LmMgfCA1ICsrLS0tDQo+ICAx IGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlm ZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9pbml0LmMNCj4gYi94 ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfaW5pdC5jDQo+IGluZGV4IGQ5MGEyZDIu LmE0MDA0OTcgMTAwNjQ0DQo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21t dV9pbml0LmMNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2luaXQu Yw0KPiBAQCAtNzc4LDcgKzc3OCw2IEBAIHN0YXRpYyBib29sX3QgX19pbml0IHNldF9pb21tdV9p bnRlcnJ1cHRfaGFuZGxlcihzdHJ1Y3QNCj4gYW1kX2lvbW11ICppb21tdSkNCj4gIHsNCj4gICAg ICBpbnQgaXJxLCByZXQ7DQo+ICAgICAgaHdfaXJxX2NvbnRyb2xsZXIgKmhhbmRsZXI7DQo+IC0g ICAgdW5zaWduZWQgbG9uZyBmbGFnczsNCj4gICAgICB1MTYgY29udHJvbDsNCj4gDQo+ICAgICAg aXJxID0gY3JlYXRlX2lycShOVU1BX05PX05PREUpOw0KPiBAQCAtNzg4LDEwICs3ODcsMTAgQEAg c3RhdGljIGJvb2xfdCBfX2luaXQgc2V0X2lvbW11X2ludGVycnVwdF9oYW5kbGVyKHN0cnVjdA0K PiBhbWRfaW9tbXUgKmlvbW11KQ0KPiAgICAgICAgICByZXR1cm4gMDsNCj4gICAgICB9DQo+IA0K PiAtICAgIHNwaW5fbG9ja19pcnFzYXZlKCZwY2lkZXZzX2xvY2ssIGZsYWdzKTsNCj4gKyAgICBz cGluX2xvY2soJnBjaWRldnNfbG9jayk7DQo+ICAgICAgaW9tbXUtPm1zaS5kZXYgPSBwY2lfZ2V0 X3BkZXYoaW9tbXUtPnNlZywgUENJX0JVUyhpb21tdS0+YmRmKSwNCj4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBQQ0lfREVWRk4yKGlvbW11LT5iZGYpKTsNCj4gLSAgICBzcGlu X3VubG9ja19pcnFyZXN0b3JlKCZwY2lkZXZzX2xvY2ssIGZsYWdzKTsNCj4gKyAgICBzcGluX3Vu bG9jaygmcGNpZGV2c19sb2NrKTsNCj4gICAgICBpZiAoICFpb21tdS0+bXNpLmRldiApDQo+ICAg ICAgew0KPiAgICAgICAgICBBTURfSU9NTVVfREVCVUcoIklPTU1VOiBubyBwZGV2IGZvciAlMDR4 OiUwMng6JTAyeC4ldVxuIiwNCj4gLS0NCj4gMS45LjENCj4gDQo+IA0KPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KPiBYZW4tZGV2ZWwgbWFpbGluZyBs aXN0DQo+IFhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnDQo+IGh0dHA6Ly9saXN0cy54ZW4ub3JnL3hl bi1kZXZlbA0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K WGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlz dHMueGVuLm9yZy94ZW4tZGV2ZWwK