From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Xu, Quan" <quan.xu@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "dario.faggioli@citrix.com" <dario.faggioli@citrix.com>,
"Wu, Feng" <feng.wu@intel.com>,
"jbeulich@suse.com" <jbeulich@suse.com>
Subject: Re: [PATCH v7 1/2] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed
Date: Thu, 17 Mar 2016 07:45:09 +0000 [thread overview]
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D15F7EC807@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1458198767-61293-2-git-send-email-quan.xu@intel.com>
> From: Xu, Quan
> Sent: Thursday, March 17, 2016 3:13 PM
> diff --git a/xen/drivers/passthrough/vtd/qinval.c b/xen/drivers/passthrough/vtd/qinval.c
> index b81b0bd..37a15fb 100644
> --- a/xen/drivers/passthrough/vtd/qinval.c
> +++ b/xen/drivers/passthrough/vtd/qinval.c
> @@ -28,6 +28,11 @@
> #include "vtd.h"
> #include "extern.h"
>
> +static unsigned int __read_mostly vtd_qi_timeout = 1;
> +integer_param("vtd_qi_timeout", vtd_qi_timeout);
> +
> +#define IOMMU_QI_TIMEOUT (vtd_qi_timeout * MILLISECS(1))
> +
> static void print_qi_regs(struct iommu *iommu)
> {
> u64 val;
> @@ -130,10 +135,14 @@ static void queue_invalidate_iotlb(struct iommu *iommu,
> spin_unlock_irqrestore(&iommu->register_lock, flags);
> }
>
> +/*
> + * NB. We must check all kinds of error and all the way up the
> + * call trees.
> + */
This comment is meaningless put in the code. It just reflects what
you need do to push the whole patch series, but it's obvious
a straightforward requirement.
> static int queue_invalidate_wait(struct iommu *iommu,
> u8 iflag, u8 sw, u8 fn)
> {
Thanks
Kevin
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-17 7:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 7:12 [PATCH v7 0/2] VT-d Device-TLB flush issue Quan Xu
2016-03-17 7:12 ` [PATCH v7 1/2] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed Quan Xu
2016-03-17 7:45 ` Tian, Kevin [this message]
2016-03-17 8:11 ` Xu, Quan
2016-03-17 8:13 ` Jan Beulich
2016-03-17 8:17 ` Xu, Quan
2016-03-17 7:12 ` [PATCH v7 2/2] VT-d: Fix vt-d Device-TLB flush timeout issue Quan Xu
2016-03-17 8:17 ` Tian, Kevin
2016-03-17 9:43 ` Jan Beulich
2016-03-17 11:13 ` Tian, Kevin
2016-03-17 11:30 ` Xu, Quan
2016-03-17 11:32 ` Tian, Kevin
2016-03-17 11:33 ` Jan Beulich
2016-03-18 12:21 ` Xu, Quan
2016-03-21 3:27 ` Tian, Kevin
2016-03-23 2:12 ` Xu, Quan
2016-03-23 3:29 ` Xu, Quan
2016-03-23 5:36 ` Tian, Kevin
2016-03-23 5:39 ` Xu, Quan
2016-03-18 11:18 ` Jan Beulich
2016-03-18 11:31 ` Xu, Quan
2016-03-18 13:35 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AADFC41AFE54684AB9EE6CBC0274A5D15F7EC807@SHSMSX101.ccr.corp.intel.com \
--to=kevin.tian@intel.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=jbeulich@suse.com \
--cc=quan.xu@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).