xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Henry Wang <Henry.Wang@arm.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Oleksandr <olekstysh@gmail.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Julien Grall" <julien@xen.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>
Subject: RE: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
Date: Sat, 22 Oct 2022 00:50:21 +0000	[thread overview]
Message-ID: <AS8PR08MB7991E3C3897AF89E969F6412922C9@AS8PR08MB7991.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <0F295AC7-1D2C-4F5D-A421-9440CEB2B5FA@arm.com>

Hi Bertrand,

> -----Original Message-----
> From: Bertrand Marquis <Bertrand.Marquis@arm.com>
> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
> 
> Hi,
> 
> > On 21 Oct 2022, at 15:40, Henry Wang <Henry.Wang@arm.com> wrote:
> >
> > (+ Arm maintainers)
> >
> > Hi Oleksandr,
> >
> >> -----Original Message-----
> >> From: Oleksandr <olekstysh@gmail.com>
> >> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
> >> Hello all.
> >> On 19.07.22 13:40, Jan Beulich wrote:
> >>> On 19.07.2022 12:32, Volodymyr Babchuk wrote:
> >>>> Jan Beulich <jbeulich@suse.com> writes:
> >>>>
> >>>>> On 18.07.2022 23:15, Volodymyr Babchuk wrote:
> >>>>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to
> >>>>>> iounmap(), but not added corresponding include.
> >>>>>>
> >>>>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
> >>>>> I don't think there's any active issue with the "missing" include:
> >>>>> That's only a problem once Arm has vPCI code enabled? In which
> >>>>> case I don't think a Fixes: tag is warranted.
> >>>> Fair enough. May I ask committer to drop this tag?
> >>> I had taken respective note already, in case I end up committing this.
> >>> But this is the last patch of the series, so I can only guess whether
> >>> it might be okay to go in ahead of the other three patches.
> >>>
> >>> Jan
> >>
> >>
> >> I am wondering, where this patch could be 4.17 material?
> >>
> >> The patch series seem to get stuck, but the current patch just adds a
> >> missing include to fix a build on Arm, so it is completely independent.
> >> I agree, there is no issue with the current code base as vPCI is
> >> disabled on Arm, so nothing to fix right now. But as PCI
> >> passthrough/vPCI on Arm is in the development stage, the developers
> >> enable that support in their builds. I think the risk is rather low than
> >> high.
> >
> > It seems reasonable to me, but I am curious about what Arm maintainers
> > and PCI maintainers think. From the history discussion in this thread I
> > think it is pretty safe to include this in 4.17. Thanks for the ping.
> 
> I think this can safely go in for 4.17.
> 
> Cheers
> Bertrand

Thanks for the feedback :) Feel free to add my:

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry


> 
> >
> > Kind regards,
> > Henry
> >
> >
> >>
> >>
> >>
> >> --
> >> Regards,
> >>
> >> Oleksandr Tyshchenko
> 



  reply	other threads:[~2022-10-22  0:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 21:15 [PATCH v2 0/4] vpci: first series in preparation for vpci on ARM Volodymyr Babchuk
2022-07-18 21:15 ` [PATCH v2 1/4] pci: add rwlock to pcidevs_lock machinery Volodymyr Babchuk
2022-07-19  6:20   ` Wei Chen
2022-07-20 18:43     ` Volodymyr Babchuk
2022-07-18 21:15 ` [PATCH v2 2/4] vpci: restrict unhandled read/write operations for guests Volodymyr Babchuk
2022-07-18 21:15 ` [PATCH v2 3/4] vpci: use pcidevs locking to protect MMIO handlers Volodymyr Babchuk
2022-08-01 11:40   ` Jan Beulich
2022-08-09 20:33     ` Volodymyr Babchuk
2022-08-10  6:46       ` Jan Beulich
2022-07-18 21:15 ` [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM Volodymyr Babchuk
2022-07-19  6:07   ` Jan Beulich
2022-07-19 10:32     ` Volodymyr Babchuk
2022-07-19 10:40       ` Jan Beulich
2022-10-21 14:32         ` Oleksandr
2022-10-21 14:40           ` Henry Wang
2022-10-21 14:56             ` Bertrand Marquis
2022-10-22  0:50               ` Henry Wang [this message]
2022-10-24  6:34                 ` Jan Beulich
2022-10-27  8:28   ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8PR08MB7991E3C3897AF89E969F6412922C9@AS8PR08MB7991.eurprd08.prod.outlook.com \
    --to=henry.wang@arm.com \
    --cc=Bertrand.Marquis@arm.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=olekstysh@gmail.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).