From: Linus Torvalds <torvalds@linux-foundation.org>
To: Borislav Petkov <bp@alien8.de>
Cc: KVM list <kvm@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>, X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
xen-devel <Xen-devel@lists.xen.org>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early
Date: Sun, 3 Apr 2016 08:51:50 -0500 [thread overview]
Message-ID: <CA+55aFw19X7PO2xd1PpUav1rSyCqUqWgi9+SA7TgjaWMaxexHQ__19543.0750296966$1459691586$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <20160403080737.GA19007@pd.tnic>
On Sun, Apr 3, 2016 at 3:07 AM, Borislav Petkov <bp@alien8.de> wrote:
>
> I'm wondering whether making it try to EFAULT correctly is the right
> thing to do... We're certainly more conservative if we panic and not
> allow some silently failed attempt at recovery which looks successful,
> to continue.
No, please don't fail at early boot.
Early boot is just about the *worst* situation to try to debug odd
failures, exactly since things like printk may not be reliable, and
things won't get logged etc.
So particularly during early boot we should try as hard as possible
not to crash - even if it means not being able to log about a problem.
At least that way you have a hopefully working machine and can *maybe*
debug things.
Linus
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-03 13:51 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1459605520.git.luto@kernel.org>
2016-04-02 14:01 ` [PATCH v5 1/9] x86/head: Pass a real pt_regs and trapnr to early_fixup_exception Andy Lutomirski
2016-04-13 11:43 ` [tip:x86/asm] x86/head: Pass a real pt_regs and trapnr to early_fixup_exception() tip-bot for Andy Lutomirski
2016-04-02 14:01 ` [PATCH v5 2/9] x86/head: Move the early NMI fixup into C Andy Lutomirski
2016-04-02 14:01 ` [PATCH v5 3/9] x86/head: Move early exception panic code into early_fixup_exception Andy Lutomirski
2016-04-02 18:39 ` Borislav Petkov
[not found] ` <20160402183919.GA2538@pd.tnic>
2016-04-02 20:13 ` Andy Lutomirski
[not found] ` <CALCETrUJVDpzNQMsY=_jWNOMer+TdW2p4wES4OBCfYU7gq3fbg@mail.gmail.com>
2016-04-02 20:47 ` Borislav Petkov
[not found] ` <20160402204752.GC2538@pd.tnic>
2016-04-02 20:58 ` Andy Lutomirski
[not found] ` <CALCETrXHR3T3PJwOWRFHTMK5WjhDyTJfaJtkiHd+g7evnqp54A@mail.gmail.com>
2016-04-04 11:52 ` Jan Kara
[not found] ` <20160404115206.GG8372@quack.suse.cz>
2016-04-04 12:46 ` Peter Zijlstra
2016-04-04 15:32 ` Andy Lutomirski
[not found] ` <CALCETrVriftUPNZ8pCQ1x9TWDHnRx8fWUvJgCQToPEOxqMLb3w@mail.gmail.com>
2016-04-04 15:36 ` Arjan van de Ven
2016-04-04 16:00 ` Peter Zijlstra
[not found] ` <20160404160042.GB3448@twins.programming.kicks-ass.net>
2016-04-04 19:38 ` Borislav Petkov
[not found] ` <20160404193803.GK351@pd.tnic>
2016-04-04 21:31 ` Andy Lutomirski
[not found] ` <CALCETrVvFTrK1pVmjnfWwwq+5P6+1ghMjh4Wwqm05d=00ejYSw@mail.gmail.com>
2016-04-04 21:40 ` Borislav Petkov
2016-04-13 11:44 ` [tip:x86/asm] x86/head: Move early exception panic code into early_fixup_exception() tip-bot for Andy Lutomirski
2016-04-02 14:01 ` [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early Andy Lutomirski
2016-04-02 14:01 ` [PATCH v5 5/9] x86/paravirt: Add _safe to the read_msr and write_msr PV hooks Andy Lutomirski
2016-04-03 8:41 ` Borislav Petkov
[not found] ` <20160403084129.GB19007@pd.tnic>
2016-04-03 13:23 ` Andy Lutomirski
[not found] ` <CALCETrUcqTx00pKYEt49QSKKBKVEx-Uv0D6dzE1-Em6Q-wkSpQ@mail.gmail.com>
2016-04-03 14:07 ` Borislav Petkov
2016-04-13 11:44 ` [tip:x86/asm] x86/paravirt: Add _safe to the read_ms()r and write_msr() PV callbacks tip-bot for Andy Lutomirski
2016-04-02 14:01 ` [PATCH v5 6/9] x86/msr: Carry on after a non-"safe" MSR access fails Andy Lutomirski
2016-04-02 14:01 ` [PATCH v5 7/9] x86/paravirt: Add paravirt_{read, write}_msr Andy Lutomirski
2016-04-02 14:01 ` [PATCH v5 8/9] x86/paravirt: Make "unsafe" MSR accesses unsafe even if PARAVIRT=y Andy Lutomirski
2016-04-13 11:46 ` [tip:x86/asm] " tip-bot for Andy Lutomirski
2016-04-02 14:01 ` [PATCH v5 9/9] x86/msr: Set the return value to zero when native_rdmsr_safe fails Andy Lutomirski
2016-04-02 14:24 ` [PATCH v5 0/9] Improve non-"safe" MSR access failure handling Linus Torvalds
[not found] ` <CA+55aFwi2E0A9e7krCG9dkTq7vMZnxsBwtF6_hw6QO0EVObf=g@mail.gmail.com>
2016-04-02 15:13 ` Andy Lutomirski
[not found] ` <CALCETrWP33SR5TCA-baZi8xBrHpWe=wzkuvUM=y4x_MPt1XgYg@mail.gmail.com>
2016-04-02 15:21 ` Linus Torvalds
2016-04-04 16:23 ` Borislav Petkov
[not found] ` <880eebc5dcd2ad9f310d41345f82061ea500e9fa.1459605520.git.luto@kernel.org>
2016-04-04 16:33 ` [PATCH v5 7/9] x86/paravirt: Add paravirt_{read, write}_msr David Vrabel
[not found] ` <5702974A.1030003@citrix.com>
2016-04-04 16:40 ` Andy Lutomirski
2016-04-13 11:45 ` [tip:x86/asm] x86/paravirt: Add paravirt_{read, write}_msr() tip-bot for Andy Lutomirski
2016-04-05 15:38 ` [PATCH v5 0/9] Improve non-"safe" MSR access failure handling Boris Ostrovsky
[not found] ` <20fc047d926150cb08cb9b9f2923519b07ec1a15.1459605520.git.luto@kernel.org>
2016-04-02 18:52 ` [PATCH v5 4/9] x86/traps: Enable all exception handler callbacks early Borislav Petkov
[not found] ` <20160402185227.GB2538@pd.tnic>
2016-04-02 20:16 ` Andy Lutomirski
[not found] ` <CALCETrV7PxgmhU_yXjJSugY88T8Do=vBDuG54fOFSyLp7nGcJA@mail.gmail.com>
2016-04-02 20:52 ` Borislav Petkov
[not found] ` <20160402205248.GD2538@pd.tnic>
2016-04-03 8:07 ` Borislav Petkov
[not found] ` <20160403080737.GA19007@pd.tnic>
2016-04-03 13:22 ` Andy Lutomirski
2016-04-03 13:51 ` Linus Torvalds [this message]
[not found] ` <CA+55aFw19X7PO2xd1PpUav1rSyCqUqWgi9+SA7TgjaWMaxexHQ@mail.gmail.com>
2016-04-03 13:55 ` Andy Lutomirski
[not found] ` <CALCETrX_x+tV4m3SwgCfXg9y5gia8eMhhTdUnHuXpXhnULkHRw@mail.gmail.com>
2016-04-03 14:10 ` Borislav Petkov
2016-04-03 14:17 ` Linus Torvalds
[not found] ` <20160403141041.GE19007@pd.tnic>
2016-04-04 15:47 ` Andy Lutomirski
2016-04-13 11:44 ` [tip:x86/asm] " tip-bot for Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFw19X7PO2xd1PpUav1rSyCqUqWgi9+SA7TgjaWMaxexHQ__19543.0750296966$1459691586$gmane$org@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=Xen-devel@lists.xen.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).