From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Condrea Subject: Re: [PATCH 01/19] xen: Create a new file xen_pvdev.c Date: Mon, 18 Jul 2016 19:54:32 +0300 Message-ID: References: <578CEE62.7010700@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1111904723339092511==" Return-path: In-Reply-To: <578CEE62.7010700@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Eric Blake Cc: Stefano Stabellini , "wei.liu2" , stefanb , qemu-devel , xen-devel , "anthony.perard" , Quan Xu , Daniel De Graaf List-Id: xen-devel@lists.xenproject.org --===============1111904723339092511== Content-Type: multipart/alternative; boundary=047d7b5d60008537280537ebd26d --047d7b5d60008537280537ebd26d Content-Type: text/plain; charset=UTF-8 Eric, this is the link to the original patch which is well formatted: http://marc.info/?l=xen-devel&m=146815138831762&w=2 I think that the formatting and s-o-b was broken in the reply from Quan. On Jul 18, 2016 17:57, "Eric Blake" wrote: > On 07/17/2016 01:41 AM, Quan Xu wrote: > > > > [Quan:]: comment starts with [Quan:] > > > > This line doesn't belong in a commit message; it's fine to put it after > the --- separator though, if it aids mailing list reviewers. > > > > > The purpose of the new file is to store generic functions shared by > frontendand backends such as xenstore operations, xendevs. > > > > s/frontendand/front end and/ > > Please wrap your commit message lines. Since 'git log' displays logs > with indentation, wrapping around 72 characters is ideal. > > > Signed-off-by: Quan Xu > > Signed-off-by: Emil Condrea > > These are not valid S-o-b, therefore this patch cannot be applied as-is. > > > > -int xenstore_read_int(const char *base, const char *node, int *ival) > > -{ > > - char *val; > > - int rc = -1; > > - > > - val = xenstore_read_str(base, node); > > [Quan:]: IMO, it is better to initialize val when declares. the same > comment for the other 'val' > > - if (val && 1 == sscanf(val, "%d", ival)) { > > This is not a valid patch. Are you replying to a patch that someone > else posted? If so, your quoting style is VERY difficult to read. > Please consider using a leading > before every line that you are quoting > (rather than pasting it verbatim as if you had written it), and include > a blank line both before and after every line that you insert, to call > visual attention to what is your reply vs. what you are quoting. > > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > > --047d7b5d60008537280537ebd26d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Eric, this is the link to the original patch which is well f= ormatted: http://marc.info/?l=3Dxen-devel&m=3D146815138831762&w= =3D2

I think that the formatting and s-o-b was broken in the repl= y from Quan.

On Jul 18, 2016 17:57, "Eric Blake" &l= t;eblake@redhat.com> wrote:

On 07/17/2016 01:41 AM,= Quan Xu wrote:
>
> [Quan:]: comment starts with [Quan:]
>

This line doesn't belong in a commit message; it's fine to put it a= fter
the --- separator though, if it aids mailing list reviewers.

>
> The purpose of the new file is to store generic functions shared by fr= ontendand backends such as xenstore operations, xendevs.
>

s/frontendand/front end and/

Please wrap your commit message lines.=C2=A0 Since 'git log' displa= ys logs
with indentation, wrapping around 72 characters is ideal.

> Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
> Signed-off-by: Emil Condrea <emilcondrea@xxxxxxxxx>

These are not valid S-o-b, therefore this patch cannot be applied as-is.

> -int xenstore_read_int(const char *base, const char *node, int *ival)<= br> > -{
> -=C2=A0 =C2=A0 char *val;
> -=C2=A0 =C2=A0 int rc =3D -1;
> -
> -=C2=A0 =C2=A0 val =3D xenstore_read_str(base, node);
> [Quan:]:=C2=A0 IMO, it is better to initialize val when declares.=C2= =A0 the same comment for the other 'val'
> -=C2=A0 =C2=A0 if (val && 1 =3D=3D sscanf(val, "%d",= ival)) {

This is not a valid patch.=C2=A0 Are you replying to a patch that someone else posted? If so, your quoting style is VERY difficult to read.
Please consider using a leading > before every line that you are quoting=
(rather than pasting it verbatim as if you had written it), and include
a blank line both before and after every line that you insert, to call
visual attention to what is your reply vs. what you are quoting.

--
Eric Blake=C2=A0 =C2=A0eblake redhat com=C2=A0 =C2=A0 +1-919-301-3266
Libvirt virtualization library http://libvirt.org

--047d7b5d60008537280537ebd26d-- --===============1111904723339092511== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============1111904723339092511==--