From mboxrd@z Thu Jan  1 00:00:00 1970
From: Emil Condrea <emilcondrea@gmail.com>
Subject: Re: [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for
 HVM virtual machine(QEMU Part)
Date: Sun, 31 Jul 2016 12:57:59 +0300
Message-ID: <CAAULxKJjeNDoa76aafU5G05mrBs-QqXMJhiSZQ3QX+ZjZpTrSA__33428.6901321777$1469959187$gmane$org@mail.gmail.com>
References: <1468151270-12984-1-git-send-email-emilcondrea@gmail.com>
 <20160725140941.GL1835@perard.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4486410386218729938=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20160725140941.GL1835@perard.uk.xensource.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, "wei.liu2" <wei.liu2@citrix.com>, stefanb <stefanb@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "Xu,
 Quan" <quan.xu@intel.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

--===============4486410386218729938==
Content-Type: multipart/alternative; boundary=001a1147c5a8f5f0550538eb85fd

--001a1147c5a8f5f0550538eb85fd
Content-Type: text/plain; charset=UTF-8

Thanks Anthony for the feedback.
I will send v10 containing fixes for patches 1 to 12 + additional patches
for
fixing code style issues for moved code.

On Mon, Jul 25, 2016 at 5:09 PM, Anthony PERARD <anthony.perard@citrix.com>
wrote:

> On Sun, Jul 10, 2016 at 02:47:31PM +0300, Emil Condrea wrote:
> > Emil Condrea (19):
> >   xen: Create a new file xen_pvdev.c
> >   xen: Create a new file xen_frontend.c
> >   xen: Move xenstore_update to xen_pvdev.c
> >   xen: Move evtchn functions to xen_pvdev.c
> >   xen: Prepare xendev qtail to be shared with frontends
> >   xen: Rename xen_be_printf to xen_pv_printf
> >   xen: Rename xen_be_unbind_evtchn
> >   xen: Rename xen_be_send_notify
> >   xen: Rename xen_be_evtchn_event
> >   xen: Rename xen_be_find_xendev
> >   xen: Rename xen_be_del_xendev
> >   xen: Rename xen_be_frontend_changed
>
> Patches from 1 to 12 looks fine but ./script/checkpatch.pl reveal some
> coding style issue in the code that is moved. Could you fix those issues
> in separate patches?  (Having separate patches for code movement and for
> coding style fix makes it easier to review.)
>
> I'll start reviewing the more complicated patches now.
>
> Thanks,
>
> --
> Anthony PERARD
>

--001a1147c5a8f5f0550538eb85fd
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Thanks Anthony for the feedback.<br></div>I will send=
 v10 containing fixes for patches 1 to 12 + additional patches for<br>fixin=
g code style issues for moved code.<br></div><div class=3D"gmail_extra"><br=
><div class=3D"gmail_quote">On Mon, Jul 25, 2016 at 5:09 PM, Anthony PERARD=
 <span dir=3D"ltr">&lt;<a href=3D"mailto:anthony.perard@citrix.com" target=
=3D"_blank">anthony.perard@citrix.com</a>&gt;</span> wrote:<br><blockquote =
class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid=
;padding-left:1ex"><span class=3D"">On Sun, Jul 10, 2016 at 02:47:31PM +030=
0, Emil Condrea wrote:<br>
&gt; Emil Condrea (19):<br>
&gt;=C2=A0 =C2=A0xen: Create a new file xen_pvdev.c<br>
&gt;=C2=A0 =C2=A0xen: Create a new file xen_frontend.c<br>
&gt;=C2=A0 =C2=A0xen: Move xenstore_update to xen_pvdev.c<br>
&gt;=C2=A0 =C2=A0xen: Move evtchn functions to xen_pvdev.c<br>
&gt;=C2=A0 =C2=A0xen: Prepare xendev qtail to be shared with frontends<br>
&gt;=C2=A0 =C2=A0xen: Rename xen_be_printf to xen_pv_printf<br>
&gt;=C2=A0 =C2=A0xen: Rename xen_be_unbind_evtchn<br>
&gt;=C2=A0 =C2=A0xen: Rename xen_be_send_notify<br>
&gt;=C2=A0 =C2=A0xen: Rename xen_be_evtchn_event<br>
&gt;=C2=A0 =C2=A0xen: Rename xen_be_find_xendev<br>
&gt;=C2=A0 =C2=A0xen: Rename xen_be_del_xendev<br>
&gt;=C2=A0 =C2=A0xen: Rename xen_be_frontend_changed<br>
<br>
</span>Patches from 1 to 12 looks fine but ./script/<a href=3D"http://check=
patch.pl" rel=3D"noreferrer" target=3D"_blank">checkpatch.pl</a> reveal som=
e<br>
coding style issue in the code that is moved. Could you fix those issues<br=
>
in separate patches?=C2=A0 (Having separate patches for code movement and f=
or<br>
coding style fix makes it easier to review.)<br>
<br>
I&#39;ll start reviewing the more complicated patches now.<br>
<br>
Thanks,<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
--<br>
Anthony PERARD<br>
</font></span></blockquote></div><br></div>

--001a1147c5a8f5f0550538eb85fd--


--===============4486410386218729938==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============4486410386218729938==--