From: Tamas K Lengyel <tamas.k.lengyel@gmail.com>
To: "Michał Leszczyński" <michal.leszczynski@cert.pl>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
Tamas K Lengyel <tamas.lengyel@intel.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"Kang, Luwei" <luwei.kang@intel.com>
Subject: Re: [PATCH v3 7/7] tools/proctrace: add proctrace tool
Date: Tue, 23 Jun 2020 03:35:30 -0600 [thread overview]
Message-ID: <CABfawh=uHn1dF5jXc1FpymOLESEJ7tfpxr6SZBrHJMuqeMwsqg@mail.gmail.com> (raw)
In-Reply-To: <1786138246.11444015.1592849576272.JavaMail.zimbra@cert.pl>
> + rc = xenforeignmemory_unmap_resource(fmem, fres);
> +
> + if (rc) {
> + fprintf(stderr, "Failed to unmap resource\n");
> + return 1;
> + }
> +
> + rc = xc_vmtrace_pt_disable(xc, domid, vcpu_id);
> +
> + if (rc) {
> + fprintf(stderr, "Failed to call xc_vmtrace_pt_disable\n");
> + return 1;
> + }
Looks like you are missing an xc_interface_close here.
> +
> + return 0;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> --
> 2.20.1
>
>
next prev parent reply other threads:[~2020-06-23 3:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 18:06 [PATCH v3 0/7] Implement support for external IPT monitoring Michał Leszczyński
2020-06-22 18:10 ` [PATCH v3 1/7] memory: batch processing in acquire_resource() Michał Leszczyński
2020-06-22 18:10 ` [PATCH v3 2/7] x86/vmx: add Intel PT MSR definitions Michał Leszczyński
2020-06-22 18:11 ` [PATCH v3 3/7] x86/vmx: add IPT cpu feature Michał Leszczyński
2020-06-22 18:11 ` [PATCH v3 4/7] x86/vmx: add do_vmtrace_op Michał Leszczyński
2020-06-23 11:54 ` Andrew Cooper
2020-06-29 9:52 ` Michał Leszczyński
2020-06-22 18:12 ` [PATCH v3 5/7] tools/libxc: add xc_vmtrace_* functions Michał Leszczyński
2020-06-26 11:50 ` Wei Liu
2020-06-22 18:12 ` [PATCH v3 6/7] tools/libxl: add vmtrace_pt_size parameter Michał Leszczyński
2020-06-26 11:52 ` Wei Liu
2020-06-22 18:12 ` [PATCH v3 7/7] tools/proctrace: add proctrace tool Michał Leszczyński
2020-06-23 9:35 ` Tamas K Lengyel [this message]
2020-06-26 11:48 ` Wei Liu
2020-06-26 13:24 ` Ian Jackson
2020-06-29 15:27 ` Tamas K Lengyel
2020-07-01 11:01 ` Ian Jackson
2020-06-22 18:19 ` [PATCH v3 0/7] Implement support for external IPT monitoring Michał Leszczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABfawh=uHn1dF5jXc1FpymOLESEJ7tfpxr6SZBrHJMuqeMwsqg@mail.gmail.com' \
--to=tamas.k.lengyel@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=luwei.kang@intel.com \
--cc=michal.leszczynski@cert.pl \
--cc=tamas.lengyel@intel.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).