From: Tamas K Lengyel <tamas@tklengyel.com>
To: Alexandru Stefan ISAILA <aisaila@bitdefender.com>
Cc: Petre Ovidiu PIRCALABU <ppircalabu@bitdefender.com>,
"rcojocaru@bitdefender.com" <rcojocaru@bitdefender.com>,
"wl@xen.org" <wl@xen.org>,
"george.dunlap@eu.citrix.com" <george.dunlap@eu.citrix.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"paul.durrant@citrix.com" <paul.durrant@citrix.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"roger.pau@citrix.com" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v7] x86/emulate: Send vm_event from emulate
Date: Thu, 11 Jul 2019 11:13:37 -0600 [thread overview]
Message-ID: <CABfawhk19LTiO5bDbVMW2u1mmmnexNJS3Df=y6XtUzvKc8APvw@mail.gmail.com> (raw)
In-Reply-To: <20190703105639.23081-1-aisaila@bitdefender.com>
> @@ -629,6 +697,14 @@ static void *hvmemul_map_linear_addr(
>
> ASSERT(p2mt == p2m_ram_logdirty || !p2m_is_readonly(p2mt));
> }
> +
> + if ( curr->arch.vm_event &&
> + curr->arch.vm_event->send_event &&
Why not fold these checks into hvm_emulate_send_vm_event since..
> + hvm_emulate_send_vm_event(addr, gfn, pfec) )
> + {
> + err = ERR_PTR(~X86EMUL_RETRY);
> + goto out;
> + }
> }
>
> /* Entire access within a single frame? */
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index 029eea3b85..783ebc3525 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -3224,6 +3224,14 @@ static enum hvm_translation_result __hvm_copy(
> return HVMTRANS_bad_gfn_to_mfn;
> }
>
> + if ( unlikely(v->arch.vm_event) &&
> + v->arch.vm_event->send_event &&
.. you seem to just repeat them here again?
> + hvm_emulate_send_vm_event(addr, gfn, pfec) )
> + {
> + put_page(page);
> + return HVMTRANS_gfn_paged_out;
> + }
> +
> p = (char *)__map_domain_page(page) + (addr & ~PAGE_MASK);
>
> if ( flags & HVMCOPY_to_guest )
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-07-11 17:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 10:56 [Xen-devel] [PATCH v7] x86/emulate: Send vm_event from emulate Alexandru Stefan ISAILA
2019-07-11 17:13 ` Tamas K Lengyel [this message]
2019-07-12 1:28 ` Jan Beulich
2019-07-15 8:52 ` Alexandru Stefan ISAILA
2019-07-18 12:58 ` Jan Beulich
2019-07-19 12:34 ` Alexandru Stefan ISAILA
2019-07-19 13:18 ` Jan Beulich
2019-07-19 13:30 ` Razvan Cojocaru
2019-07-19 13:38 ` Jan Beulich
2019-07-19 14:23 ` Razvan Cojocaru
2019-07-29 8:12 ` Alexandru Stefan ISAILA
2019-07-29 11:30 ` Jan Beulich
2019-07-22 7:51 ` Alexandru Stefan ISAILA
2019-07-30 12:21 ` Alexandru Stefan ISAILA
2019-07-30 13:27 ` Jan Beulich
2019-07-30 14:12 ` Alexandru Stefan ISAILA
2019-07-30 14:54 ` Jan Beulich
2019-07-30 15:28 ` Alexandru Stefan ISAILA
2019-08-20 20:11 ` Andrew Cooper
2019-08-27 8:26 ` Jan Beulich
2019-09-02 14:36 ` Alexandru Stefan ISAILA
2019-09-02 14:59 ` Jan Beulich
2019-07-23 8:17 ` Alexandru Stefan ISAILA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABfawhk19LTiO5bDbVMW2u1mmmnexNJS3Df=y6XtUzvKc8APvw@mail.gmail.com' \
--to=tamas@tklengyel.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=paul.durrant@citrix.com \
--cc=ppircalabu@bitdefender.com \
--cc=rcojocaru@bitdefender.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).