From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamas K Lengyel Subject: Re: [PATCH v4 4/8] monitor: ARM SMC events Date: Wed, 1 Jun 2016 09:41:54 -0600 Message-ID: References: <1464561430-13465-1-git-send-email-tamas@tklengyel.com> <1464561430-13465-4-git-send-email-tamas@tklengyel.com> <574EC8F4.6090102@arm.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8510741941898013030==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b88HN-00025i-Pz for xen-devel@lists.xenproject.org; Wed, 01 Jun 2016 15:41:57 +0000 Received: by mail-wm0-f50.google.com with SMTP id a20so32546997wma.1 for ; Wed, 01 Jun 2016 08:41:56 -0700 (PDT) Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com. [74.125.82.44]) by smtp.gmail.com with ESMTPSA id l9sm19885780wjm.0.2016.06.01.08.41.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Jun 2016 08:41:55 -0700 (PDT) Received: by mail-wm0-f44.google.com with SMTP id a20so32546002wma.1 for ; Wed, 01 Jun 2016 08:41:54 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Julien Grall Cc: Xen-devel , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org --===============8510741941898013030== Content-Type: multipart/alternative; boundary=e89a8f83a4893a0b45053439544c --e89a8f83a4893a0b45053439544c Content-Type: text/plain; charset=UTF-8 On Jun 1, 2016 05:37, "Julien Grall" wrote: > > Hi Tamas, > > > On 29/05/16 23:37, Tamas K Lengyel wrote: >> >> Add support for monitoring ARM SMC events. This patch only adds the required >> bits to enable/disable monitoring and forwarding the event through vm_event. > > > Couple of questions: > > - How the vm-event app will differentiate a SMC64 vs a SMC32 call? Wouldn't cpsr record the guest state when the smc was executed, telling us whether it was 32bit or 64bit? > - How the vm-event app will know the SMC number (i.e the > > In an AArch64 state, those informations are available from the syndrome register (HSR_EL2.ISS). Good question, it should probably be sent alongside the other registers. At the moment my usecase doesn't care about it as I'm just using SMC for inducing traps to the vmm but other applications may indeed need this. Tamas --e89a8f83a4893a0b45053439544c Content-Type: text/html; charset=UTF-8


On Jun 1, 2016 05:37, "Julien Grall" <julien.grall@arm.com> wrote:
>
> Hi Tamas,
>
>
> On 29/05/16 23:37, Tamas K Lengyel wrote:
>>
>> Add support for monitoring ARM SMC events. This patch only adds the required
>> bits to enable/disable monitoring and forwarding the event through vm_event.
>
>
> Couple of questions:
>
> - How the vm-event app will differentiate a SMC64 vs a SMC32 call?

Wouldn't cpsr record the guest state when the smc was executed, telling us whether it was 32bit or 64bit?

> - How the vm-event app will know the SMC number (i.e the
>
> In an AArch64 state, those informations are available from the syndrome register (HSR_EL2.ISS).

Good question, it should probably be sent alongside the other registers. At the moment my usecase doesn't care about it as I'm just using SMC for inducing traps to the vmm but other applications may indeed need this.

Tamas

--e89a8f83a4893a0b45053439544c-- --===============8510741941898013030== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============8510741941898013030==--