From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 048D0C433DF for ; Thu, 18 Jun 2020 15:50:01 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C64FC206FA for ; Thu, 18 Jun 2020 15:50:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kNjbbLFw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C64FC206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jlwnU-00010N-76; Thu, 18 Jun 2020 15:49:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jlwnT-00010E-G2 for xen-devel@lists.xenproject.org; Thu, 18 Jun 2020 15:49:47 +0000 X-Inumbo-ID: 5592f40a-b17b-11ea-b7bb-bc764e2007e4 Received: from mail-wr1-x441.google.com (unknown [2a00:1450:4864:20::441]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5592f40a-b17b-11ea-b7bb-bc764e2007e4; Thu, 18 Jun 2020 15:49:46 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id r7so6602284wro.1 for ; Thu, 18 Jun 2020 08:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+DWoeFkopjjNX1PbX1m7YzEf1NbfIy2AI/0OrJadQp4=; b=kNjbbLFw4D7RVWzpqM5bEj4Ofjh4f94HgFK4Lt4YtGTcKDny1ugyb3tYKaoNCYg/wU ctutCbAVc2GqUTEOrbtIhGQ3v2j8VD50vsDfIaBfAKYjBjHFLnBSUP8chFs/onSJq6rl 3qTenjqlWHYczvGc9Fx9IxTwKTfPAyBWMMJJXX8kf8RlExpnHFuEMo742vEMxyxfgepZ es5ah/nFDmfHTX5y8oro8rp+VBHRHO6cUOwNSPbL4tnhUzLOwptSa88aRmN8KbayXVce l+por2joOp6QJ/wwh3rOUsKcDksPZlJ1hwxwEls8DlWJsmt7Td68+M/vw3T+qT63Jy/7 Y/cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+DWoeFkopjjNX1PbX1m7YzEf1NbfIy2AI/0OrJadQp4=; b=DTnijGxcN6tS7Lk0k4f5vXSMabNOQY0zeKFHvfmfESD+jLnv2/ycozzcg+Hjw3xx3L B+++s55H0i05gAH15tCd6sZq9D9jFygcIMvvoNvOa9Rj/SfoW8aoryMa7GC6NmXn1IR7 XR61ypMvE7/8xe3s9uMv0bbbVO8CXZg3VNqUzJdA2lqQLBrtEqkGnbkTJXM4ZWn3HTrD VCrM8LqYmahSJK0YUbVZNcSIK564dQytL7JD6VGuQNVSFEGdY8drK6d8gcAZsXck3zDx uT5Xtd+IPsOdWDb4g7UJL3yxYO0+8r9EdL33Z/giJTAklN98ip4cLkqtSjRrXftpeaIU Tytg== X-Gm-Message-State: AOAM533X/LvAM6CIGve7+11Up15pvZZdmrdkYwPPr5fCT6ovJtV5u4Z3 OI1eaihY+Xb6lHi6OsETL7prrejtnCzAisWsSes= X-Google-Smtp-Source: ABdhPJy6xrnztjHjy/7VPTjC89LXE7trX76wXLnB0zidbWIkw0GWWWxCh1ntuJjc9tlpIu9czTODWhogbvDjpUxkSj8= X-Received: by 2002:a5d:490f:: with SMTP id x15mr5151188wrq.259.1592495385898; Thu, 18 Jun 2020 08:49:45 -0700 (PDT) MIME-Version: 1.0 References: <1548605014.8764792.1592320576239.JavaMail.zimbra@cert.pl> <34833328.8766172.1592320926648.JavaMail.zimbra@cert.pl> <20200616172352.GT735@Air-de-Roger> <1599209169.9756264.1592493912556.JavaMail.zimbra@cert.pl> In-Reply-To: From: Tamas K Lengyel Date: Thu, 18 Jun 2020 09:49:10 -0600 Message-ID: Subject: Re: [PATCH v1 4/7] x86/vmx: add do_vmtrace_op To: Jan Beulich Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , =?UTF-8?B?TWljaGHFgiBMZXN6Y3p5xYRza2k=?= , Ian Jackson , George Dunlap , Xen-devel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thu, Jun 18, 2020 at 9:47 AM Tamas K Lengyel wrote: > > On Thu, Jun 18, 2020 at 9:41 AM Jan Beulich wrote: > > > > On 18.06.2020 17:25, Micha=C5=82 Leszczy=C5=84ski wrote: > > > ----- 16 cze 2020 o 19:23, Roger Pau Monn=C3=A9 roger.pau@citrix.com = napisa=C5=82(a): > > >> On Tue, Jun 16, 2020 at 05:22:06PM +0200, Micha=C5=82 Leszczy=C5=84s= ki wrote: > > >>> --- a/xen/include/public/hvm/hvm_op.h > > >>> +++ b/xen/include/public/hvm/hvm_op.h > > >>> @@ -382,6 +382,33 @@ struct xen_hvm_altp2m_op { > > >>> typedef struct xen_hvm_altp2m_op xen_hvm_altp2m_op_t; > > >>> DEFINE_XEN_GUEST_HANDLE(xen_hvm_altp2m_op_t); > > >>> > > >>> +/* HVMOP_vmtrace: Perform VM tracing related operation */ > > >>> +#define HVMOP_vmtrace 26 > > >>> + > > >>> +#define HVMOP_VMTRACE_INTERFACE_VERSION 0x00000001 > > >>> + > > >>> +struct xen_hvm_vmtrace_op { > > >>> + /* IN variable */ > > >>> + uint32_t version; /* HVMOP_VMTRACE_INTERFACE_VERSION */ > > >>> + uint32_t cmd; > > >>> +/* Enable/disable external vmtrace for given domain */ > > >>> +#define HVMOP_vmtrace_ipt_enable 1 > > >>> +#define HVMOP_vmtrace_ipt_disable 2 > > >>> +#define HVMOP_vmtrace_ipt_get_buf 3 > > >>> +#define HVMOP_vmtrace_ipt_get_offset 4 > > >>> + domid_t domain; > > >> > > >> You are missing a padding field here AFAICT. > > > > > > > > > Could you point out what is the purpose of this padding field and wha= t should be the size in this case? It's pretty unclear to me. > > > > In the public interface we aim at making all padding explicit. > > Just to expand a bit on this: this is an ABI meaning the hypervisor > and the tool sending this structure communicate via memory only. Since > the hypervisor and the compiler can be compiled using different ^ meant to write "hypervisor and the toolstack" above Tamas