From: Tamas K Lengyel <tamas@tklengyel.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Petre Pircalabu" <ppircalabu@bitdefender.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Alexandru Isaila" <aisaila@bitdefender.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 3/3] xen/vm_event: Add safe to disable vm_event
Date: Wed, 20 May 2020 09:27:02 -0600 [thread overview]
Message-ID: <CABfawhmsbJJ4-TwCgeVhA7yw+v_YstR3RyyjYJfV17KwYm4=Bg@mail.gmail.com> (raw)
In-Reply-To: <28e50e15-410e-096d-51f1-e304c9ef8cdb@suse.com>
On Wed, May 20, 2020 at 7:45 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 15.05.2020 18:53, Tamas K Lengyel wrote:
> > --- a/xen/arch/x86/hvm/hvm.c
> > +++ b/xen/arch/x86/hvm/hvm.c
> > @@ -563,15 +563,41 @@ void hvm_do_resume(struct vcpu *v)
> > v->arch.hvm.inject_event.vector = HVM_EVENT_VECTOR_UNSET;
> > }
> >
> > - if ( unlikely(v->arch.vm_event) && v->arch.monitor.next_interrupt_enabled )
> > + if ( unlikely(v->arch.vm_event) )
> > {
> > - struct x86_event info;
> > + struct domain *d = v->domain;
>
> const
>
> > + if ( v->arch.monitor.next_interrupt_enabled )
> > + {
> > + struct x86_event info;
> > +
> > + if ( hvm_get_pending_event(v, &info) )
> > + {
> > + hvm_monitor_interrupt(info.vector, info.type, info.error_code,
> > + info.cr2);
> > + v->arch.monitor.next_interrupt_enabled = false;
> > + }
> > + }
> >
> > - if ( hvm_get_pending_event(v, &info) )
> > + if ( d->arch.monitor.safe_to_disable )
> > {
> > - hvm_monitor_interrupt(info.vector, info.type, info.error_code,
> > - info.cr2);
> > - v->arch.monitor.next_interrupt_enabled = false;
> > + struct vcpu *check_vcpu;
>
> const again, requiring a respective adjustment to patch 2.
>
> > + bool pending_op = false;
> > +
> > + for_each_vcpu ( d, check_vcpu )
> > + {
> > + if ( vm_event_check_pending_op(check_vcpu) )
> > + {
> > + pending_op = true;
> > + break;
> > + }
> > + }
> > +
> > + if ( !pending_op )
> > + {
> > + hvm_monitor_safe_to_disable();
>
> This new function returns bool without the caller caring about the
> return value.
Yea, there is actually nothing to be done if the event can't be sent
for whatever reason, I guess I'll just turn it to void.
Tamas
next prev parent reply other threads:[~2020-05-20 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 16:52 [PATCH 0/3] vm_event: fix race-condition when disabling monitor events Tamas K Lengyel
2020-05-15 16:53 ` [PATCH 1/3] xen/monitor: Control register values Tamas K Lengyel
2020-05-20 13:36 ` Jan Beulich
2020-05-20 13:42 ` Tamas K Lengyel
2020-05-20 13:48 ` Jan Beulich
2020-05-21 1:28 ` Tamas K Lengyel
2020-05-15 16:53 ` [PATCH 2/3] xen/vm_event: add vm_event_check_pending_op Tamas K Lengyel
2020-05-15 16:53 ` [PATCH 3/3] xen/vm_event: Add safe to disable vm_event Tamas K Lengyel
2020-05-20 13:45 ` Jan Beulich
2020-05-20 15:27 ` Tamas K Lengyel [this message]
2020-05-21 2:18 ` Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABfawhmsbJJ4-TwCgeVhA7yw+v_YstR3RyyjYJfV17KwYm4=Bg@mail.gmail.com' \
--to=tamas@tklengyel.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=ppircalabu@bitdefender.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).