xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Christopher Clark <christopher.w.clark@gmail.com>
To: Nicholas Tsirakis <niko.tsirakis@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Nicholas Tsirakis <tsirakisn@ainfosec.com>
Subject: Re: [Xen-devel] [PATCH] argo: suppress select logging messages
Date: Wed, 19 Jun 2019 12:49:32 -0700	[thread overview]
Message-ID: <CACMJ4GYPX6Y5ZP9++reFsrhk3sxSokdExkVuLNisf6w_dx0BUQ@mail.gmail.com> (raw)
In-Reply-To: <4b6949fb8d84a255898ca4b285526f6513513371.1560888454.git.tsirakisn@ainfosec.com>

On Tue, Jun 18, 2019 at 1:10 PM Nicholas Tsirakis
<niko.tsirakis@gmail.com> wrote:
>
> Some logging messages made more sense as argo debug
> logs rather than standard Xen logs. Use argo_dprintk
> to only print this info if argo DEBUG is enabled.
>
> Signed-off-by: Nicholas Tsirakis <tsirakisn@ainfosec.com>
Reviewed-by: Christopher Clark <christopher.w.clark@gmail.com>

> ---
>  xen/common/argo.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/xen/common/argo.c b/xen/common/argo.c
> index c8f4302963..59b655f4c8 100644
> --- a/xen/common/argo.c
> +++ b/xen/common/argo.c
> @@ -1456,7 +1456,7 @@ find_ring_mfns(struct domain *d, struct argo_ring_info *ring_info,
>      if ( ring_info->mfns )
>      {
>          /* Ring already existed: drop the previous mapping. */
> -        gprintk(XENLOG_INFO, "argo: vm%u re-register existing ring "
> +        argo_dprintk("argo: vm%u re-register existing ring "
>                  "(vm%u:%x vm%u) clears mapping\n",
>                  d->domain_id, ring_info->id.domain_id,
>                  ring_info->id.aport, ring_info->id.partner_id);
> @@ -1516,7 +1516,7 @@ find_ring_mfns(struct domain *d, struct argo_ring_info *ring_info,
>      {
>          ASSERT(ring_info->nmfns == NPAGES_RING(len));
>
> -        gprintk(XENLOG_DEBUG, "argo: vm%u ring (vm%u:%x vm%u) %p "
> +        argo_dprintk("argo: vm%u ring (vm%u:%x vm%u) %p "
>                  "mfn_mapping %p len %u nmfns %u\n",
>                  d->domain_id, ring_info->id.domain_id,
>                  ring_info->id.aport, ring_info->id.partner_id, ring_info,
> @@ -1730,7 +1730,7 @@ register_ring(struct domain *currd,
>          list_add(&ring_info->node,
>                   &currd->argo->ring_hash[hash_index(&ring_info->id)]);
>
> -        gprintk(XENLOG_DEBUG, "argo: vm%u registering ring (vm%u:%x vm%u)\n",
> +        argo_dprintk("argo: vm%u registering ring (vm%u:%x vm%u)\n",
>                  currd->domain_id, ring_id.domain_id, ring_id.aport,
>                  ring_id.partner_id);
>      }
> @@ -1770,8 +1770,7 @@ register_ring(struct domain *currd,
>              goto out_unlock2;
>          }
>
> -        gprintk(XENLOG_DEBUG,
> -                "argo: vm%u re-registering existing ring (vm%u:%x vm%u)\n",
> +        argo_dprintk("argo: vm%u re-registering existing ring (vm%u:%x vm%u)\n",
>                  currd->domain_id, ring_id.domain_id, ring_id.aport,
>                  ring_id.partner_id);
>      }
> --
> 2.17.1
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

      reply	other threads:[~2019-06-19 19:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18 20:10 [Xen-devel] [PATCH] argo: suppress select logging messages Nicholas Tsirakis
2019-06-19 19:49 ` Christopher Clark [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACMJ4GYPX6Y5ZP9++reFsrhk3sxSokdExkVuLNisf6w_dx0BUQ@mail.gmail.com \
    --to=christopher.w.clark@gmail.com \
    --cc=niko.tsirakis@gmail.com \
    --cc=tsirakisn@ainfosec.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).