From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Lengyel, Tamas" <tlengyel@novetta.com>
Subject: Re: [PATCH v4 15/15] tools/xen-access: altp2m testcases
Date: Thu, 9 Jul 2015 21:35:51 -0400
Message-ID: <CAD33N+5YQWuNNdhNYh-SnjorP78sqrfsOrLOTCDs64ruAH8Ddg@mail.gmail.com>
References: <1436489553-6300-1-git-send-email-edmund.h.white@intel.com>
	<1436489553-6300-16-git-send-email-edmund.h.white@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5275023885820052882=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436489553-6300-16-git-send-email-edmund.h.white@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ed White <edmund.h.white@intel.com>
Cc: Ravi Sahita <ravi.sahita@intel.com>, Wei Liu <wei.liu2@citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

--===============5275023885820052882==
Content-Type: multipart/alternative; boundary=f46d043bdf2a8f2433051a7b657d

--f46d043bdf2a8f2433051a7b657d
Content-Type: text/plain; charset=ISO-8859-1

> @@ -546,6 +652,23 @@ int main(int argc, char *argv[])
>                  }
>
>                  break;
> +            case VM_EVENT_REASON_SINGLESTEP:
> +                printf("Singlestep: rip=%016"PRIx64", vcpu %d\n",
> +                       req.regs.x86.rip,
> +                       req.vcpu_id);
> +
> +                if ( altp2m )
> +                {
> +                    printf("\tSwitching altp2m to view %u!\n",
> altp2m_view_id);
> +
> +                    rsp.reason = VM_EVENT_REASON_MEM_ACCESS;
>

So this was a workaround for v3 of the series that is no longer necessary -
it's probably cleaner to have the same reason set for the response as the
request was. It's not against any rule, so the code is still correct and
works, it's just not best practice. So in case there is another round on
the series, it could be fixed then.

Tamas

--f46d043bdf2a8f2433051a7b657d
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><div class=3D"gmail_quote">=
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
@@ -546,6 +652,23 @@ int main(int argc, char *argv[])<br>
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}<br>
<br>
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break;<br>
+=A0 =A0 =A0 =A0 =A0 =A0 case VM_EVENT_REASON_SINGLESTEP:<br>
+=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 printf(&quot;Singlestep: rip=3D%016&quot;P=
RIx64&quot;, vcpu %d\n&quot;,<br>
+=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0req.regs.x86.rip,<br>
+=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0req.vcpu_id);<br>
+<br>
+=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if ( altp2m )<br>
+=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 {<br>
+=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 printf(&quot;\tSwitching altp2m to=
 view %u!\n&quot;, altp2m_view_id);<br>
+<br>
+=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 rsp.reason =3D VM_EVENT_REASON_MEM=
_ACCESS;<br></blockquote><div><br></div><div>So this was a workaround for v=
3 of the series that is no longer necessary - it&#39;s probably cleaner to =
have the same reason set for the response as the request was. It&#39;s not =
against any rule, so the code is still correct and works, it&#39;s just not=
 best practice. So in case there is another round on the series, it could b=
e fixed then.<br><br></div><div>Tamas<br></div></div></div></div>

--f46d043bdf2a8f2433051a7b657d--


--===============5275023885820052882==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============5275023885820052882==--