xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Fu Wei <fu.wei@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Jon Masters <jcm@redhat.com>,
	Julien Grall <julien.grall@linaro.org>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	Linaro UEFI Mailman List <linaro-uefi@lists.linaro.org>,
	xen-devel <xen-devel@lists.xenproject.org>,
Subject: Re: [PATCH] xen/arm64: check XSM Magic and Signature from the second unknown module.
Date: Fri, 18 Mar 2016 17:48:11 +0800	[thread overview]
Message-ID: <CADyBb7t9W=o9ENaG4a0YuiQ0Wnf8W7Q0UNtwB8a2fOrbWgoGdg@mail.gmail.com> (raw)
In-Reply-To: <56EBC96602000078000DE3AB@prv-mh.provo.novell.com>

Hi Jan,

On 18 March 2016 at 16:24, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 18.03.16 at 08:41, <fu.wei@linaro.org> wrote:
>> --- a/xen/arch/arm/bootfdt.c
>> +++ b/xen/arch/arm/bootfdt.c
>> @@ -163,6 +163,36 @@ static void __init process_memory_node(const void *fdt, int node,
>>      }
>>  }
>> +static bool __init check_xsm_signature(const void *fdt, int node,
>> +                                       const char *name,
>> +                                       u32 address_cells, u32 size_cells)
>> +{
>> +    uint32_t selinux_magic = 0xf97cff8c;
> So this would be the 3rd instance of this literal number in the source
> base. I would have wanted to suggest using one of the two
> constants we already have, but I don't know which one to pick.
> Daniel - why do we have both XSM_MAGIC and FLASK_MAGIC?

Ah, Sorry for that , I didn't know we already have these definition.

OK, I think we should use XSM_MAGIC,
and I think  FLASK_MAGIC should be "XenFlask".
Please correct me if I misunderstand something.

So maybe I should do :

    uint32_t xen_magic = XEN_MAGIC;

> Jan

Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021

Xen-devel mailing list

  reply	other threads:[~2016-03-18  9:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18  7:41 [PATCH] xen/arm64: check XSM Magic and Signature from the second unknown module fu.wei
2016-03-18  8:24 ` Jan Beulich
2016-03-18  9:48   ` Fu Wei [this message]
2016-03-25 21:02     ` Daniel De Graaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADyBb7t9W=o9ENaG4a0YuiQ0Wnf8W7Q0UNtwB8a2fOrbWgoGdg@mail.gmail.com' \
    --to=fu.wei@linaro.org \
    --cc=JBeulich@suse.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=jcm@redhat.com \
    --cc=julien.grall@linaro.org \
    --cc=leif.lindholm@linaro.org \
    --cc=linaro-uefi@lists.linaro.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).