Re: [PATCH v5] xen/arm64: check XSM Magic from the second unknown module.

From: Fu Wei <fu.wei@linaro.org>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xensource.com, Jon Masters <jcm@redhat.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	Julien Grall <julien.grall@arm.com>,
	sstabellini@kernel.org,
	Linaro UEFI Mailman List <linaro-uefi@lists.linaro.org>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v5] xen/arm64: check XSM Magic from the second unknown module.
Date: Tue, 19 Apr 2016 20:32:17 +0800	[thread overview]
Message-ID: <CADyBb7vi1E8qqEUoRynws+7wHB=kCw+8uQj9207k4Ev5XcbkBA@mail.gmail.com> (raw)
In-Reply-To: <20160415094753.GV18652@citrix.com>

Hi Wei Liu

On 15 April 2016 at 17:47, Wei Liu <wei.liu2@citrix.com> wrote:
> On Wed, Apr 13, 2016 at 05:45:27PM +0800, Fu Wei wrote:
>> Hi Julien,
>>
>> On 8 April 2016 at 23:19, Julien Grall <julien.grall@arm.com> wrote:
>> > Hi Wei,
>> >
>> > On 08/04/16 15:58, Wei Liu wrote:
>> >>
>> >> On Fri, Apr 08, 2016 at 03:51:22PM +0100, Julien Grall wrote:
>> >>>
>> >>> Hi Fu Wei,
>> >>>
>> >>> On 05/04/16 17:46, fu.wei@linaro.org wrote:
>> >>>>
>> >>>> From: Fu Wei <fu.wei@linaro.org>
>> >>>>
>> >>>> This patch adds a has_xsm_magic helper function for detecting XSM
>> >>>
>> >>> >from the second unknown module.
>> >>>>
>> >>>>
>> >>>> If Xen can't get the kind of module from compatible, we guess the kind
>> >>>> of
>> >>>> these unknowns respectively:
>> >>>>      (1) The first unknown must be kernel.
>> >>>>      (2) Detect the XSM Magic from the 2nd unknown:
>> >>>>          a. If it's XSM, set the kind as XSM, and that also means we
>> >>>>         won't load ramdisk;
>> >>>>         b. if it's not XSM, set the kind as ramdisk.
>> >>>>         So if user want to load ramdisk, it must be the 2nd unknown.
>> >>>
>> >>>
>> >>> The documentation in docs/misc/arm/device-tree/booting.txt needs to be
>> >>> update.
>> >>>
>> >>> Otherwise, the rest of the patch looks good to me.
>> >>>
>> >>> Regards,
>> >>>
>> >>
>> >> Is this targeting 4.7? Today is the last day for committing stuff. The
>> >> doc can come in later.
>> >
>> >
>> > Yes, it's targeting 4.7. Fu Wei, can you send a follow-up for the doc?
>> >
>>
>> yes, of course, I will do ASAP.
>>
>
> Yes please. Note that the anticipated release date would be the
> beginning of June, so you have five weeks to do that.

I have posted the doc patch:
http://lists.xen.org/archives/html/xen-devel/2016-04/msg02070.html

could some one review it ??

>
> Wei.

-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel