From: Nick Rosbrook <rosbrookn@gmail.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Nick Rosbrook <rosbrookn@ainfosec.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] golang/xenlight: add an empty line after DO NOT EDIT comment
Date: Thu, 21 May 2020 11:45:07 -0400 [thread overview]
Message-ID: <CAEBZRSczH+baW+hV9MVnup4qPauu=uEZGK7EhrkFPy+pfS0Fmg@mail.gmail.com> (raw)
In-Reply-To: <49cc21c24b65ef5e1ce9810397c0fcd9d43f77f4.1590072675.git.rosbrookn@ainfosec.com>
> When generating documentation, pkg.go.dev and godoc.org assume a comment
> that immediately precedes the package declaration is a "package
> comment", and should be shown in the documentation. Add an empty line
> after the DO NOT EDIT comment in generated files to prevent these
> comments from appearing as "package comments."
George,
When I re-generated the code, there were also changes to
types/helpers.gen.go corresponding to recent changes from the linux
stubdom series. How should we make sure the xenlight package is
up-to-date for the 4.14 release?
Thanks,
NR
next prev parent reply other threads:[~2020-05-21 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 14:55 [PATCH] golang/xenlight: add an empty line after DO NOT EDIT comment Nick Rosbrook
2020-05-21 15:45 ` Nick Rosbrook [this message]
2020-05-22 9:14 ` George Dunlap
2020-05-22 9:44 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEBZRSczH+baW+hV9MVnup4qPauu=uEZGK7EhrkFPy+pfS0Fmg@mail.gmail.com' \
--to=rosbrookn@gmail.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rosbrookn@ainfosec.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).