Re: [Xen-devel] [PATCH v2 01/22] golang/xenlight: generate enum types from IDL

From: Nick Rosbrook <rosbrookn@gmail.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: Nick Rosbrook <rosbrookn@ainfosec.com>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	kerriganb@ainfosec.com, Ian Jackson <ian.jackson@eu.citrix.com>,
	Wei Liu <wl@xen.org>
Subject: Re: [Xen-devel] [PATCH v2 01/22] golang/xenlight: generate enum types from IDL
Date: Thu, 5 Dec 2019 12:00:38 -0500	[thread overview]
Message-ID: <CAEBZRSdM18adVPzEB0ijJFbkaJsJ=x0NUVoY-HYx_3gpzUE_YQ@mail.gmail.com> (raw)
In-Reply-To: <6e0e3454-98bf-4762-2fe2-f69f7103d6e1@citrix.com>

> Sorry to come back to this... I think this would be better explicitly
> listing out the files that are needed.  As I said, the current way of
> doing things means gengotypes.py will *always* be re-run; and the
> result, when experimenting with the `typeof` before, was that my local
> changes to helpes.gen.py were being overwritten.
>
> Having this be `xenlight.go types.gen.go helpers.gen.go` instead means
>
> 1) gengotypes is only run when one of its inputs changes
> 2) you can make local changes to the generated files and have them
> copied over
> 3) The copying only happens when one of the above two things happens
> 4) The final compile is slightly faster because the go compiler knows
> that the files hasn't changed.
>
> I can change this on check-in if you're OK with it, and I end up
> checking part of the series in before you send v3.

That all makes sense to me. I have no problem with you making the
change on check-in if you go that route.

Thanks,
-NR

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel