Re: [PATCH v9]xen: sched: convert RTDS from time to event driven model

From: Meng Xu <mengxu@cis.upenn.edu>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Tianyang Chen <tiche@seas.upenn.edu>,
	George Dunlap <george.dunlap@citrix.com>,
	Dagaen Golomb <dgolomb@seas.upenn.edu>
Subject: Re: [PATCH v9]xen: sched: convert RTDS from time to event driven model
Date: Wed, 16 Mar 2016 16:45:32 -0400	[thread overview]
Message-ID: <CAENZ-+mxqpqL2g-oL4MLQjf37AtYMxLXOz0=KDOT2kPj2-xtxg@mail.gmail.com> (raw)
In-Reply-To: <1458138307.3102.901.camel@citrix.com>

>>
>> sched_rt.c TIMER_SOFTIRQ
>>     replenishment_timer_handler()
>>         [spin_lock]
>>         <for_each_vcpu_on_q(i)> {
>>             replenish(i)
>>             runq_tickle(i)
>>         }>
>>         program_timer()
>>         [spin_lock]
>>
> And kill this (or, again, move to cover, wiki, blog, etc.) as well.
>
> Also, trying to apply this gave:
>
> /*
> <stdin>:194: trailing whitespace.
>  * A helper function that only removes a vcpu from a queue
> <stdin>:355: trailing whitespace.
>     /*
> <stdin>:356: trailing whitespace.
>      * The timer initialization will happen later when
> <stdin>:380: trailing whitespace.
>     {
> warning: squelched 10 whitespace errors
> warning: 15 lines add whitespace errors.
>
> And I think there are a couple of long lines as well.
Tianyang,

You can configure the git to mark whitespace in color.
One approach can be found at
http://stackoverflow.com/questions/5257553/coloring-white-space-in-git-diffs-output

Thanks,

Meng

-- 
Meng Xu
PhD Student in Computer and Information Science
University of Pennsylvania
http://www.cis.upenn.edu/~mengxu/

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel