From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Vladimir 'phcoder' Serbinenko" <phcoder@gmail.com>
Subject: Re: [GRUB2 PATCH v3 4/4] multiboot2: Add support for
	relocatable images
Date: Fri, 11 Mar 2016 17:13:19 +0100
Message-ID: <CAEaD8JN7AsoaG+cAdxbRbLN8BgDMS0W5JDU9UpFok081tyxx2A@mail.gmail.com>
References: <1456937500-7855-1-git-send-email-daniel.kiper@oracle.com>
 <1456937500-7855-5-git-send-email-daniel.kiper@oracle.com>
 <CAEaD8JNoFgYTBbptLRf=vu4R9pdsD9U8hrKS5AMMaic9X0-bEg@mail.gmail.com>
 <20160311160635.GB3500@olila.local.net-space.pl>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7899491322800714243=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
 by lists.xen.org with esmtp (Exim 4.84)
 (envelope-from <phcoder@gmail.com>) id 1aePgo-0005OM-Bf
 for xen-devel@lists.xenproject.org; Fri, 11 Mar 2016 16:13:22 +0000
Received: by mail-wm0-f66.google.com with SMTP id n205so3301608wmf.2
 for <xen-devel@lists.xenproject.org>; Fri, 11 Mar 2016 08:13:20 -0800 (PST)
In-Reply-To: <20160311160635.GB3500@olila.local.net-space.pl>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: "jgross@suse.com" <jgross@suse.com>, "grub-devel@gnu.org" <grub-devel@gnu.org>, "eric.snowberg@oracle.com" <eric.snowberg@oracle.com>, "arvidjaar@gmail.com" <arvidjaar@gmail.com>, "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>, "cardoe@cardoe.com" <cardoe@cardoe.com>, "pgnet.dev@gmail.com" <pgnet.dev@gmail.com>, "roy.franz@linaro.org" <roy.franz@linaro.org>, "ning.sun@intel.com" <ning.sun@intel.com>, "david.vrabel@citrix.com" <david.vrabel@citrix.com>, "jbeulich@suse.com" <jbeulich@suse.com>, "stefano.stabellini@eu.citrix.com" <stefano.stabellini@eu.citrix.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "qiaowei.ren@intel.com" <qiaowei.ren@intel.com>, "richard.l.maliszewski@intel.com" <richard.l.maliszewski@intel.com>, "gang.wei@intel.com" <gang.wei@intel.com>, "fu.wei@linaro.org" <fu.wei@linaro.org>, "seth.goldberg@oracle.com" <seth>
List-Id: xen-devel@lists.xenproject.org

--===============7899491322800714243==
Content-Type: multipart/alternative; boundary=001a114228329bb385052dc83511

--001a114228329bb385052dc83511
Content-Type: text/plain; charset=UTF-8

>
>
> > > +  if (relocatable)
> > > +    {
> > > +      if (base_addr > min_addr)
> > > +       grub_multiboot_payload_eip += base_addr - min_addr;
> > > +      else
> > > +       grub_multiboot_payload_eip -= min_addr - base_addr;
> > > +    }
> > > +
> > >
> > Why is it relative to min_addr? Sounds like it should be just an offset
>
> Ugh... IIRC, it has meaning but I forgot what. I will check it.
> However, this means that I must put comment here.
>

Is it possible that you have confused link address and minimal loading
address? How is entry usually specified in ELF? How do you suggest it
should be done in mb headers?

>
> > from base addr. What do ET_DYN files use?
>
> I will take a look.
>
> Daniel
>


-- 
Regards
Vladimir 'phcoder' Serbinenko

--001a114228329bb385052dc83511
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><br>
&gt; &gt; +=C2=A0 if (relocatable)<br>
&gt; &gt; +=C2=A0 =C2=A0 {<br>
&gt; &gt; +=C2=A0 =C2=A0 =C2=A0 if (base_addr &gt; min_addr)<br>
&gt; &gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0grub_multiboot_payload_eip +=3D base_=
addr - min_addr;<br>
&gt; &gt; +=C2=A0 =C2=A0 =C2=A0 else<br>
&gt; &gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0grub_multiboot_payload_eip -=3D min_a=
ddr - base_addr;<br>
&gt; &gt; +=C2=A0 =C2=A0 }<br>
&gt; &gt; +<br>
&gt; &gt;<br>
&gt; Why is it relative to min_addr? Sounds like it should be just an offse=
t<br>
<br>
Ugh... IIRC, it has meaning but I forgot what. I will check it.<br>
However, this means that I must put comment here.<br></blockquote><div>=C2=
=A0</div><div>Is it possible that you have confused link address and minima=
l loading address? How is entry usually specified in ELF? How do you sugges=
t it should be done in mb headers?</div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
&gt; from base addr. What do ET_DYN files use?<br>
<br>
I will take a look.<br>
<br>
Daniel<br>
</blockquote><br><br>-- <br>Regards<br>Vladimir &#39;phcoder&#39; Serbinenk=
o<br><br>

--001a114228329bb385052dc83511--


--===============7899491322800714243==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============7899491322800714243==--