From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Vladimir 'phcoder' Serbinenko" <phcoder@gmail.com>
Subject: Re: [GRUB2 PATCH v4 1/4] i386/relocator: Add
	grub_relocator64_efi relocator
Date: Tue, 15 Mar 2016 17:00:33 +0100
Message-ID: <CAEaD8JO23MkxBVF7ZqL8pDDz_85Nof1kbMo-RtxMam8S2KOeOg__16450.0972176485$1458057704$gmane$org@mail.gmail.com>
References: <1458055562-24950-1-git-send-email-daniel.kiper@oracle.com>
 <1458055562-24950-2-git-send-email-daniel.kiper@oracle.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8204613619863156374=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <phcoder@gmail.com>) id 1afrOd-0006S1-5g
 for xen-devel@lists.xenproject.org; Tue, 15 Mar 2016 16:00:35 +0000
Received: by mail-wm0-f66.google.com with SMTP id l68so4240814wml.3
 for <xen-devel@lists.xenproject.org>; Tue, 15 Mar 2016 09:00:33 -0700 (PDT)
In-Reply-To: <1458055562-24950-2-git-send-email-daniel.kiper@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: "jgross@suse.com" <jgross@suse.com>, "grub-devel@gnu.org" <grub-devel@gnu.org>, "eric.snowberg@oracle.com" <eric.snowberg@oracle.com>, "arvidjaar@gmail.com" <arvidjaar@gmail.com>, "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>, "cardoe@cardoe.com" <cardoe@cardoe.com>, "pgnet.dev@gmail.com" <pgnet.dev@gmail.com>, "roy.franz@linaro.org" <roy.franz@linaro.org>, "ning.sun@intel.com" <ning.sun@intel.com>, "david.vrabel@citrix.com" <david.vrabel@citrix.com>, "jbeulich@suse.com" <jbeulich@suse.com>, "stefano.stabellini@eu.citrix.com" <stefano.stabellini@eu.citrix.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "qiaowei.ren@intel.com" <qiaowei.ren@intel.com>, "richard.l.maliszewski@intel.com" <richard.l.maliszewski@intel.com>, "gang.wei@intel.com" <gang.wei@intel.com>, "fu.wei@linaro.org" <fu.wei@linaro.org>, "seth.goldberg@oracle.com" <seth>
List-Id: xen-devel@lists.xenproject.org

--===============8204613619863156374==
Content-Type: multipart/alternative; boundary=001a11c2870648c026052e187f23

--001a11c2870648c026052e187f23
Content-Type: text/plain; charset=UTF-8

Other than 2 typos (inline). Looks good. Let's give it a day if somebody
wants to object, then I'll commit it

>
>         movq    %rax, %rsp
>
> +       /*
> +        * Here is grub_relocator64_efi_start() entry point.
> +        * Following code is shared between grub_relocator64_efi_start()
> +        * and grub_relocator64_start().
> +        *
> +        * Think twice before changing anything below!!!
> +        */
>
above?

> +       /* Here grub_relocator64_efi_start() ends. Ufff... */
> +VARIABLE(grub_relocator64_efi_end)
> +
>
Probably without _start. Comment probably applies even more here than above.
 Are you ok with me moving ends to the same place when comitting?  This
would make the code less error-prone.


-- 
Regards
Vladimir 'phcoder' Serbinenko

--001a11c2870648c026052e187f23
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Other than 2 typos (inline). Looks good. Let&#39;s give it a day if somebod=
y wants to object, then I&#39;ll commit it<br><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex=
"><br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 movq=C2=A0 =C2=A0 %rax, %rsp<br>
<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0/*<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * Here is grub_relocator64_efi_start() entry p=
oint.<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * Following code is shared between grub_reloca=
tor64_efi_start()<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * and grub_relocator64_start().<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 *<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 * Think twice before changing anything below!!=
!<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 */<br></blockquote><div>above?=C2=A0</div><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #c=
cc solid;padding-left:1ex">+=C2=A0 =C2=A0 =C2=A0 =C2=A0/* Here grub_relocat=
or64_efi_start() ends. Ufff... */<br>
+VARIABLE(grub_relocator64_efi_end)<br>
+<br></blockquote><div>Probably without _start. Comment probably applies ev=
en more here than above.</div><div>=C2=A0Are you ok with me moving ends to =
the same place when comitting?=C2=A0 This would make the code less error-pr=
one.</div><br><br>-- <br>Regards<br>Vladimir &#39;phcoder&#39; Serbinenko<b=
r><br>

--001a11c2870648c026052e187f23--


--===============8204613619863156374==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============8204613619863156374==--