From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] blktap2: Invalid logic detecting unaligned
 buffers in vhd_write_block
Date: Wed, 6 Jul 2016 14:16:57 +0100
Message-ID: <CAFLBxZYccXuXi0s_0YGKHOb=pt++FZEFnGYo5vLecdHEqETgcw@mail.gmail.com>
References: <56EB2B73.3060905@gmail.com> <20160325161106.GB21910@citrix.com>
 <56F56895.6040006@gmail.com>
 <CAFLBxZbdJR2jdEUNiP5iKTR+1o4gwuDCm9ZKYoeS45xdp=C-yg@mail.gmail.com>
 <57053E8B.4070001@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <57053E8B.4070001@gmail.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Ross Philipson <ross.philipson@gmail.com>
Cc: Wei Liu <wei.liu2@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

T24gV2VkLCBBcHIgNiwgMjAxNiBhdCA1OjUxIFBNLCBSb3NzIFBoaWxpcHNvbiA8cm9zcy5waGls
aXBzb25AZ21haWwuY29tPiB3cm90ZToKPiBPbiAwMy8yOS8yMDE2IDA3OjI2IEFNLCBHZW9yZ2Ug
RHVubGFwIHdyb3RlOgo+PiBPbiBGcmksIE1hciAyNSwgMjAxNiBhdCA0OjM0IFBNLCBSb3NzIFBo
aWxpcHNvbgo+PiA8cm9zcy5waGlsaXBzb25AZ21haWwuY29tPiB3cm90ZToKPj4+IE9uIDAzLzI1
LzIwMTYgMTI6MTEgUE0sIFdlaSBMaXUgd3JvdGU6Cj4+Pj4gT24gVGh1LCBNYXIgMTcsIDIwMTYg
YXQgMDY6MTA6NTlQTSAtMDQwMCwgUm9zcyBQaGlsaXBzb24gd3JvdGU6Cj4+Pj4+IEl0IHNlZW1z
IHRoZSBsb2dpYyBpcyBtZWFudCB0byBkZXRlY3Qgc2VjdG9yIHVuYWxpZ25lZCBidWZmZXJzIGZv
ciBibG9jawo+Pj4+PiB3cml0ZXMuIFRoZSBOT1Rpbmcgb2YgdGhlIGxvZ2ljIGluc3RlYWQgbWFz
a3Mgb2ZmIGFueSB1bmFsaWduZWQgYml0cyBhbmQKPj4+Pj4gYWxzbyB3b3VsZCBjYXVzZSB0aGUg
ZnVuY3Rpb24gdG8gYWx3YXlzIGZhaWwuIEl0IHNlZW1zIHRoZSBmdW5jdGlvbiBpcyBub3QKPj4+
Pj4gdXNlZCBpbiBhbnkgb2YgdGhlIHRvb2xzIHNvIHRoYXQgaXMgcHJvYmFibHkgd2h5IHRoZSBw
cm9ibGVtIGlzIG5vdCBzZWVuLgo+Pj4+PiBJbiB0aGUgdmhkX3JlYWRfYmxvY2sgZnVuY3Rpb24g
aXQgaXMgY29ycmVjdC4KPj4+Pj4KPj4+Pj4gU2lnbmVkLW9mZi1ieTogUm9zcyBQaGlsaXBzb24g
PHJvc3MucGhpbGlwc29uQGFpbmZvc2VjLmNvbT4KPj4+Pgo+Pj4+IFRoaXMgc2VlbXMgdG8gZmFs
bCB1bmRlciB0b29scyB1bWJyZWxsYS4gSSd2ZSBsb29rIGF0IGJsa3RhcDIgY29kZSwKPj4+PiB0
aGUgcmVhc29uaW5nIGlzIGNvbnZpbmNpbmcgdG8gbWUgc286Cj4+Pj4KPj4+PiAgIEFja2VkLWJ5
OiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPgo+Pj4+Cj4+Pj4gQnV0IEkndmUgbmV2ZXIg
dXNlZCBibGt0YXAyIGFuZCB3ZSBkb24ndCBub3JtYWxseSB0ZXN0IGl0IHNvIEkgd291bGQKPj4+
PiBhbHNvIHdhaXQgYSBiaXQgbG9uZ2VyIHRvIHNlZSBpZiBhbnlib2R5IG9iamVjdHMgdG8gdGhp
cyBjaGFuZ2UuCj4+Pj4KPj4+PiBPT0kgaWYgbm8gY29kZSB3YXMgdXNpbmcgdGhpcywgaG93IGRp
ZCB5b3UgZGlzY292ZXIgdGhpcyBwcm9ibGVtPwo+Pj4KPj4+IFdlIGhhdmUgYW4gb2xkIGZvcmsg
b2YgYmxrdGFwMiBmcm9tIHdheSBiYWNrIHdoZW4uIEkgd2FzIHdvcmtpbmcgdG8gZXh0cmFjdCBv
dXIKPj4+IGNoYW5nZXMgYW5kIHR1cm4gdGhlbSBpbnRvIHBhdGNoZXMgc28gd2UgY291bGQgcmVi
YXNlIG9uIHVwc3RyZWFtIGJsa3RhcDIuCj4+PiBTb21lb25lIGxvbmcgYWdvIGZvdW5kIHRoYXQg
LSBJIGhhdmUgbm8gaWRlYSBob3cgYnV0IGl0IHdhcyBhIHZhbGlkIGZpeCBzbyBJCj4+PiB1cHN0
cmVhbWVkIGl0Lgo+Pj4KPj4+IFRoZXJlIGFyZSBhIG51bWJlciBvZiBvdGhlciBvbmVzIHRoYXQg
d2VyZSBmb3VuZCB0aGF0IGFyZSBzdGlsbCBpbiB1cHN0cmVhbQo+Pj4gYmxrdGFwMiAtIEkgcGxh
biB0byBzZW5kIHRoZW0gdG9vLgo+Pgo+PiBSb3NzLAo+Pgo+PiBJbnN0ZWFkIG9mIGNyb3NzLXBv
cnRpbmcgZml4ZXMgZnJvbSBYZW5TZXJ2ZXIncyBibGt0YXAzIHRvIHRoZQo+PiBiaXRyb3R0aW5n
IGJsa3RhcDIsIHdvdWxkIHlvdSBjb25zaWRlciB0YWtpbmcgdXAgbXkgd29yayBvbiByZXBsYWNp
bmcKPj4gYmxrdGFwMiB3aXRoIGJ1aWxkaW5nIGJsa3RhcDMgYXMgYW4gZXh0ZXJuYWwgcHJvamVj
dD8KPgo+IEdlb3JnZSwgYSBmZXcgcXVlc3Rpb25zIGJlbG93IHRvIGdldCBzdGFydGVkLi4uCj4K
Pj4KPj4gVGhlIGJhc2ljIHNoYXBlIG9mIHRoaW5ncyB0aGF0IG5lZWQgdG8gaGFwcGVuIGZvciB0
aGF0IGFyZToKPj4KPj4gMS4gQWxsb3cgcWVtdSB0byBwcm92aWRlIGVtdWxhdGVkIGRldmljZXMg
Zm9yIGRpc2tzIHdoaWNoIHVzZSBob3RwbHVnCj4+IHNjcmlwdHMgKGp1c3QgY2hlY2tlZCBpbiBs
YXN0IHdlZWspCj4+Cj4+IDIuIERvIHRoZSB0d2Vha3MgbmVjZXNzYXJ5IHRvIGFsbG93IGJsa3Rh
cDMgdG8gYmUgYnVpbHQgYXMgYW4KPj4gaW5kZXBlbmRlbnQgcHJvamVjdCAob3V0c2lkZSB0aGUg
WGVuU2VydmVyIGJ1aWxkIHN5c3RlbSkKPgo+IEkgYW0gbm90IHN1cmUgd2hlcmUgdGhlIGxhdGVz
dCBhbmQgZ3JlYXRlc3QgYmxrdGFwMyB3b3JrIGNhbiBiZSBmb3VuZC4gSSBoYXZlCj4gZm91bmQg
c29tZSBvbGQgcmVwb3MgdGhhdCBoYXZlIGFjdGl2aXR5IHVwIHVudGlsIHRoZSB3b3JrIHN0b3Bw
ZWQgb24gdGhhdAo+IHByb2plY3QgaW4gMjAxMy4gQ2FuIHlvdSBnaXZlIG1lIHNvbWUgcG9pbnRl
cnMgb24gdGhpcz8KPgo+IEFsc28gaXQgc2VlbXMgdGhlIG92ZXJhbGwgaWRlYSBpcyB0byBub3Qg
aGF2ZSBibGt0YXAzIChvciBhbnkgYmxrdGFwKSBsaXZlIGluCj4gdGhlIFhlbiB0cmVlIGJ1dCBy
YXRoZXIgYmUgZXh0ZXJuYWwuIFdoZXJlIHdvdWxkIGJsa3RhcDMgbGl2ZT8KPgo+Pgo+PiAzLiBT
d2l0Y2ggbGlieGwgdG8gdXNlIHRoZSBhbHJlYWR5LWluLXRyZWUgYmxvY2stdGFwIHNjcmlwdCAo
d2hpY2gKPj4gY2FsbHMgdGFwY3RsKSByYXRoZXIgdGhhbiBsaW5raW5nIGFnYWluc3QgdGhlIGJs
a3RhcCBsaWJyYXJ5Lgo+Cj4gSSBiZWxpZXZlIEkgZm91bmQgdGhpcyB3b3JrOgo+Cj4gaHR0cDov
L2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hpdmVzL2h0bWwveGVuLWRldmVsLzIwMTUtMDcvbXNn
MDA4MDUuaHRtbAo+Cj4gSXQgbG9va3MgbGlrZSA0IG9mIHRoZSBzZXQgbWFkZSBpdCBpbiBhbmQg
cGF0Y2hlcyAzICYgNSBzdGlsbCBuZWVkIHdvcms/IEkgY2FuCj4gcmUtYmFzZSB0aGVtLgoKSGV5
IFJvc3MsCgpTb3JyeSBmb3IgZHJvcHBpbmcgdGhpcyBvbiB0aGUgZmxvb3IgLS0gYXJlIHlvdSBz
dGlsbCBpbnRlcmVzdGVkIGluCnRoaXMgd29yaz8gIElmIHNvIEknbGwgdGFrZSBzb21lIHRpbWUg
dG8gc3VtbWFyaXplIHdoZXJlIEkgZ290IHRvLiA6LSkKCiAtR2VvcmdlCgpfX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0
Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK