From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <George.Dunlap@eu.citrix.com>
Subject: Re: [v9][PATCH 07/16] hvmloader/e820: construct guest
 e820 table
Date: Sat, 18 Jul 2015 13:35:19 +0100
Message-ID: <CAFLBxZYw9UvvFagnESF+nC-u7VjEu7JyMSdx8D7BXrYofei=MQ@mail.gmail.com>
References: <1437093920-11472-1-git-send-email-tiejun.chen@intel.com>
	<1437093920-11472-8-git-send-email-tiejun.chen@intel.com>
	<55A8CD740200007800092545@mail.emea.novell.com>
	<55A8C65C.1020804@intel.com>
	<55A8FA26020000780009269C@mail.emea.novell.com>
	<55A91DAD.7030900@intel.com>
	<55A93BF702000078000928B0@mail.emea.novell.com>
	<55A9254B.2070900@intel.com>
	<55A94418020000780009293E@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55A94418020000780009293E@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Tiejun Chen <tiejun.chen@intel.com>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, Jul 17, 2015 at 5:06 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 17.07.15 at 17:54, <tiejun.chen@intel.com> wrote:
>>> > +    for ( i = nr-1; i > memory_map.nr_map; i-- )
>>>
>>> Before you add memory_map.nr_map, you should be able to iterate
>>> from 0 to (not inclusive) nr. At least as far as I recall the original
>>> patch.
>>>
>>
>> Sorry, I really don't understand what you want.
>>
>> Before we add memory_map.nr_map, e820[0, nr) don't include low/high
>> memory, right?
>
> Why? memory_map is representing the reserved areas only, isn't it?
> If that's not the case, then of course everything is fine.

I'm pretty sure the memory map we get here is an extension of the
original PV-only get_e820 hypercall, which *does* include both the
lowmem and highmem regions.

In any case, it's pretty clear from the patched code that Tiejun is
removing the old code which created the lowmem and highmem regions and
is not replacing it.  Where do you think the highmem region he's
looking for was coming from?

 -George