From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <George.Dunlap@eu.citrix.com>
Subject: Re: [PATCH 4/6] libxl: Use the block-tap script for
	LIBXL_DISK_BACKEND_TAP
Date: Mon, 6 Jul 2015 13:39:43 +0100
Message-ID: <CAFLBxZZ7KnyZnvv5FEOTRw+rLCKHXLkO7O4z4TzXKVQnUsyHwA@mail.gmail.com>
References: <1436179903-449-1-git-send-email-george.dunlap@eu.citrix.com>
	<1436179903-449-5-git-send-email-george.dunlap@eu.citrix.com>
	<559A6001.2010202@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <559A6001.2010202@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Felipe Franciosi <felipe.franciosi@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Wen Congyang <wency@cn.fujitsu.com>, Jonathan Ludlam <Jonathan.Ludlam@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Ian Jackson <ian.jackson@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Dave Scott <Dave.Scott@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, Jul 6, 2015 at 12:01 PM, Andrew Cooper
<andrew.cooper3@citrix.com> wrote:
> On 06/07/15 11:51, George Dunlap wrote:
>> The block-tap script can now do everything needed for libxl; no need
>> to link against the blktap library.
>>
>> To do this:
>>
>> * Set disk->script to "block-tap" and dev to "format:pdev_path" in
>>   device_disk_add for LIBXL_DISK_BACKEND_TAP
>>
>> * Remove libxl_blktap2.o and libxl_noblktap2.o and all code depending
>>   on them
>>
>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>> ---
>> CC: Ian Campbell <ian.campbell@citrix.com>
>> CC: Ian Jackson <ian.jackson@citrix.com>
>> CC: Wei Liu <wei.liu2@citrix.com>
>> CC: Dave Scott <Dave.Scott@eu.citrix.com>
>> CC: Jonathan Ludlam <Jonathan.Ludlam@eu.citrix.com>
>> CC: Wen Congyang <wency@cn.fujitsu.com>
>> CC: Yang Hongyang <yanghy@cn.fujitsu.com>
>> CC: Felipe Franciosi <felipe.franciosi@citrix.com>
>>
>> Note: This is broken for HVM domains at the moment because all block
>> scripts are broken for HVM domains.  That is a bug which should be a
>> blocker for the 4.6 release.  As such, I think there is justification
>> for checking in this "feature" (enabling use of a 'system' blktap)
>> with the assumption that the FIXME will go away before the release.
>>
>> That will technically break bisectability; but only for users of
>> blktap (which does not include osstest).
>> ---
>>  tools/libxl/Makefile          |  5 ---
>>  tools/libxl/libxl.c           | 28 ++++---------
>>  tools/libxl/libxl_blktap2.c   | 93 -------------------------------------------
>>  tools/libxl/libxl_device.c    | 14 -------
>>  tools/libxl/libxl_dm.c        |  5 ++-
>>  tools/libxl/libxl_internal.h  | 26 ------------
>>  tools/libxl/libxl_noblktap2.c | 42 -------------------
>>  7 files changed, 11 insertions(+), 202 deletions(-)
>>
>> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
>> index cc9c152..43ab243 100644
>> --- a/tools/libxl/Makefile
>> +++ b/tools/libxl/Makefile
>> @@ -44,11 +44,6 @@ LIBXL_LIBS += $(LIBXL_LIBS-y)
>>  LIBXLU_LIBS = libxenlight.so
>>
>>  LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o
>> -ifeq ($(LIBXL_BLKTAP),y)
>
> You will also want to remove reference to LIBXL_BLKTAP from Rules.mk

Indeed, there is quite a bit I seem to have missed... I'll add a patch
exising the configure- and make-related bits, separately from both
this patch and the rm -rf tools/blktap2 patch.

 -George