From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v4 08/34] vmap: Make the while loop less fishy. Date: Mon, 21 Mar 2016 12:04:50 +0000 Message-ID: References: <1458064616-23101-1-git-send-email-konrad.wilk@oracle.com> <1458064616-23101-9-git-send-email-konrad.wilk@oracle.com> <22250.54910.735489.888445@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ahyZp-0007kh-Ht for xen-devel@lists.xenproject.org; Mon, 21 Mar 2016 12:04:53 +0000 Received: by mail-ob0-f194.google.com with SMTP id cf7so14477873obc.3 for ; Mon, 21 Mar 2016 05:04:51 -0700 (PDT) In-Reply-To: <22250.54910.735489.888445@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Ian Jackson Cc: Keir Fraser , Andrew Cooper , Tim Deegan , mpohlack@amazon.de, Ross Lagerwall , Jan Beulich , xen-devel , sasha.levin@oracle.com List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBNYXIgMTcsIDIwMTYgYXQgNDowOCBQTSwgSWFuIEphY2tzb24gPElhbi5KYWNrc29u QGV1LmNpdHJpeC5jb20+IHdyb3RlOgo+IEtvbnJhZCBSemVzenV0ZWsgV2lsayB3cml0ZXMgKCJb UEFUQ0ggdjQgMDgvMzRdIHZtYXA6IE1ha2UgdGhlIHdoaWxlIGxvb3AgbGVzcyBmaXNoeS4iKToK Pj4gICBlcnJvcjoKPj4gLSAgICB3aGlsZSAoIGktLSApCj4+IC0gICAgICAgIGZyZWVfZG9taGVh cF9wYWdlKG1mbl90b19wYWdlKG1mbl94KG1mbltpXSkpKTsKPj4gKyAgICB3aGlsZSAoIGkgKQo+ PiArICAgICAgICBmcmVlX2RvbWhlYXBfcGFnZShtZm5fdG9fcGFnZShtZm5feChtZm5bLS1pXSkp KTsKPgo+IEkgcXVpdGUgc3Ryb25nbHkgZGlzbGlrZSB0aGlzLiAgSXQgaXMgZ29vZCBwcmFjdGlj ZSB0byBrZWVwIHRoZSBsb29wCj4gY29udHJvbCBjb2RlIHRvZ2V0aGVyIHdoZXJlIHRoaXMgaXMg cmVhc29uYWJseSBjb252ZW5pZW50Lgo+Cj4gSSB3b3VsZG4ndCBxdWliYmxlIG9uIHN1Y2ggYSBz dHlsaXN0aWMgbWF0dGVyIChwYXJ0aWN1bGFybHkgb3V0c2lkZSBteQo+IGJhaWxpd2ljaykgYnV0 IChhKSBJIHdvdWxkIGxpa2UgdG8gcmVpbmZvcmNlIEphbidzIHBvc2l0aW9uIGFuZAo+IChiKSBp dCBzZWVtcyB3b3J0aCB3cml0aW5nIGFuIGVtYWlsIGFzIHRoZXJlIHdpbGwgYmUgbWFueSBvY2N1 cnJlbmNlcy4KClNpbmNlIHdlJ3JlIHRha2luZyBhYm91dCBnZW5lcmFsIHByaW5jaXBsZSAoYW5k IEkndmUgYmVlbiByZWZlcnJlZCB0bwpoZXJlIGZyb20gYSBzaW1pbGFyIGRpc2N1c3Npb24gZWxz ZXdoZXJlIFsxXSksIGxldCBtZSB3ZWlnaCBpbiBhcwp3ZWxsLgoKSSBjYW4gc2VlIHRoZSBwb2lu dCBvZiBub3Qgd2FudGluZyB0aGUgZGVjcmVtZW50IHRvIGJlIGluIHRoZSBtaWRkbGUKb2YgdGhl IGV4cHJlc3Npb24gaGVyZS4gIEJ1dCBJIGFsc28gZW50aXJlbHkgYWdyZWUgd2l0aCBLb25yYWQn cwphc3Nlc3NtZW50IHRoYXQgdGhpcyBjb2RlIGlzIGxpa2VseSB0byBiZSBjb25mdXNpbmc7IGFu ZCB0aGUgZmFjdCB0aGF0CmEgY29tcHV0ZXIgcHJvZ3JhbSBmb2xsb3dpbmcgYSBsaXN0IG9mIHJ1 bGVzICpkZXZlbG9wZWQgYnkKcHJvZmVzc2lvbmFsIGJ1Zy1maW5kZXJzKiBpcyBjb25mdXNlZCBi eSB0aGlzIGtpbmQgb2Ygc2VtYW50aWNzIEkKdGhpbmsgc3VwcG9ydHMgdGhpcyBhc3Nlc3NtZW50 LiAgQXQgdmVyeSBsZWFzdCBpdCBoYXMgdGhlIHBvdGVudGlhbCB0bwp3YXN0ZSBhIGxvdCBvZiBt ZW50YWwgZW5lcmd5IGZpZ3VyaW5nIG91dCB3aHkgY29kZSB0aGF0IGxvb2tzIHdyb25nCmlzbid0 IHdyb25nOyBhbmQgYXQgd29yc3QgdGhlcmUncyBhIHJpc2sgdGhhdCBhdCBzb21lIHBvaW50IHNv bWVvbmUKd2lsbCAiZml4IiBpdCBpbmNvcnJlY3RseS4KClRoZSBmYWN0IHRoYXQgdGhlcmUgYXJl IGFscmVhZHkgbWFueSBpbnN0YW5jZXMgb2YgdGhpcyBwYXR0ZXJuIGluIHRoZQpzb3VyY2UgdHJl ZSB3b3VsZCBiZSByZWxldmFudCBpZiB3ZSBleHBlY3Qgbm9ib2R5IGJ1dCBwZW9wbGUgY3VycmVu dGx5CmZhbWlsaWFyIHdpdGggdGhlIGNvZGUgdG8gZXZlcnkgdHJ5IHRvIHJlYWQgb3IgbW9kaWZ5 IGl0LiAgQnV0IHNpbmNlCm9uIHRoZSBjb250cmFyeSB3ZSBob3BlIHRoYXQgb3RoZXJzIHdpbGwg Y29udHJpYnV0ZSB0byB0aGUgY29kZWJhc2UsCmFuZCBldmVuIHRoYXQgdGhleSBtYXkgZXZlbnR1 YWxseSBiZWNvbWUgbWFpbnRhaW5lcnMsIEkgdGhpbmsgdGhlcmUgaXMKc2Vuc2UgaW4gYWRkcmVz c2luZyB0aGVtLCBhdCBsZWFzdCBhcyB0aGV5IGNvbWUgdXAuCgpJbiBteSBjYXNlIEkndmUgc3Vn Z2VzdGVkIGFkZGluZyBhIGNvbW1lbnQgdG8gY2x1ZSBwZW9wbGUgaW50byB0aGUKZmFjdCB0aGF0 IHRoZSBwb3N0Zml4IHNlbWFudGljcyBhcmUgaW4gb3BlcmF0aW9uOyBJIHRoaW5rIHRoYXQKYmFs YW5jZXMgInJlZHVjaW5nIGNvZ25pdGl2ZSBsb2FkIiB3aXRoICJhdm9pZHMgdW5uZWNlc3Nhcmls eSB2ZXJib3NlCmNvZGUiLgoKT3RoZXIgb3B0aW9ucyB3b3VsZCBiZSB0aGluZ3MgbGlrZSB0aGlz OgoKZG8gewogaS0tOwogW2NsZWFudXBdCn0gd2hpbGUgKCBpID4gMCApOwoKb3IKCndoaWxlICgg aSA+IDAgKSB7CiBpLS07CiBbY2xlYW51cF0KfQoKVGhlIGZpcnN0IG9uZSBJIHRoaW5rIGlzIHRo ZSBjbGVhcmVzdCwgYnV0IG5laXRoZXIgb25lIGFyZSB2ZXJ5IGNvbmNpc2UuCgogLUdlb3JnZQoK WzFdIG1hcmMuaW5mby8/aT08NTZFQkM1RTEwMjAwMDA3ODAwMERFMzc2QHBydi1taC5wcm92by5u b3ZlbGwuY29tPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8v bGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK