Xen 4.6.1 raisin build error etherboot undeclared

Xen 4.6.1 raisin build error etherboot undeclared

[Holger Schramm]

Hi there,

i receive a build error at rombios.c and etherboot not declared. I have
no idea how to fix this.

One thing i stumbled is this commit:

http://xenbits.xen.org/gitweb/?p=raisin.git;a=commitdiff;h=5fe3855a6cf69c4aaed89c47b7e7937b9c66d07e

Etherboot support requires ipxe download and thus etherboot was
disabled. Perhaps this may cause the problem.

System:
Debian Jessie 64bit

raisin config:
ENABLED_COMPONENTS="seabios ovmf xen qemu grub libvirt"
MAKE="make"
PREFIX="/usr/local"
DESTDIR=dist
XEN_URL="git://xenbits.xen.org/xen.git"
QEMU_URL="git://xenbits.xen.org/qemu-upstream-4.6-testing.git"
QEMU_TRADITIONAL_URL="git://xenbits.xen.org/qemu-xen-4.6-testing.git"
SEABIOS_URL="git://xenbits.xen.org/seabios.git"
GRUB_URL="git://git.savannah.gnu.org/grub.git"
LIBVIRT_URL="git://xenbits.xen.org/libvirt.git"
OVMF_URL="git://xenbits.xen.org/ovmf.git"
LINUX_URL="git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git"
XEN_REVISION="origin/stable-4.6"
QEMU_REVISION="master"
QEMU_TRADITIONAL_REVISION="master"
SEABIOS_REVISION="rel-1.8.2"
GRUB_REVISION="master"
LIBVIRT_REVISION="origin/xen-tested-master"
OVMF_REVISION="cb9a7ebabcd6b8a49dc0854b2f9592d732b5afbd"
LINUX_REVISION="master"
ENABLED_TESTS="busybox-pv busybox-hvm"

Build error:

gcc   -O2 -fomit-frame-pointer -m32 -march=i686 -fno-strict-aliasing
-std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable -Wno-unused-local-typedefs
-D__XEN_TOOLS__ -MMD -MF .rombios.o.d -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -mno-tls-direct-seg-refs  -DNDEBUG -Werror
-fno-stack-protector -fno-exceptions -fno-builtin -msoft-float
-I/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware/hvmloader/../../../tools/include
-U__XEN_TOOLS__
-D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__
-DENABLE_OVMF -DENABLE_ROMBIOS -DENABLE_SEABIOS  -c -o rombios.o rombios.c
rombios.c: In function ‘rombios_load_roms’:
rombios.c:103:39: error: ‘etherboot’ undeclared (first use in this function)
                                       etherboot);
                                       ^
rombios.c:103:39: note: each undeclared identifier is reported only once
for each function it appears in
/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware/hvmloader/../../../tools/Rules.mk:107:
recipe for target 'rombios.o' failed
make[7]: *** [rombios.o] Error 1
make[7]: Leaving directory
'/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware/hvmloader'
Makefile:93: recipe for target 'all' failed
make[6]: *** [all] Error 2
make[6]: Leaving directory
'/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware/hvmloader'
/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware/../../tools/Rules.mk:123:
recipe for target 'subdir-all-hvmloader' failed
make[5]: *** [subdir-all-hvmloader] Error 2
make[5]: Leaving directory
'/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware'
/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware/../../tools/Rules.mk:118:
recipe for target 'subdirs-all' failed
make[4]: *** [subdirs-all] Error 2
make[4]: Leaving directory
'/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware'
Makefile:33: recipe for target 'all' failed
make[3]: *** [all] Error 2
make[3]: Leaving directory
'/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware'
/usr/local/src/xenboil/raisin/xen-dir-remote/tools/../tools/Rules.mk:123:
recipe for target 'subdir-install-firmware' failed
make[2]: *** [subdir-install-firmware] Error 2
make[2]: Leaving directory
'/usr/local/src/xenboil/raisin/xen-dir-remote/tools'
/usr/local/src/xenboil/raisin/xen-dir-remote/tools/../tools/Rules.mk:118:
recipe for target 'subdirs-install' failed
make[1]: *** [subdirs-install] Error 2
make[1]: Leaving directory
'/usr/local/src/xenboil/raisin/xen-dir-remote/tools'
Makefile:102: recipe for target 'install-tools' failed
make: *** [install-tools] Error 2

-- 
Holger

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: Xen 4.6.1 raisin build error etherboot undeclared

[George Dunlap]

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

On Sat, Mar 26, 2016 at 12:46 PM, Holger Schramm <lists@schramm.by> wrote:
> Hi there,
>
> i receive a build error at rombios.c and etherboot not declared. I have
> no idea how to fix this.
>
> One thing i stumbled is this commit:
>
> http://xenbits.xen.org/gitweb/?p=raisin.git;a=commitdiff;h=5fe3855a6cf69c4aaed89c47b7e7937b9c66d07e

It looks like that commit contains a bug -- the patch adds
"--enable-rombios", but the text of the patch seems to indicate that
"--disable-rombios" is what was wanted.

Can you try the attached patch?

 -George

[-- Attachment #2: raisin-disable-rombios.patch --]
[-- Type: text/x-diff, Size: 1897 bytes --]

commit 8f40a9a9a61414ef6146da3524420858115600b1
Author: George Dunlap <george.dunlap@citrix.com>
Commit: George Dunlap <george.dunlap@citrix.com>

    raisin: Actually disable rombios
    
    Commit 5fe3855 meant to disable rombios, but didn't.  This causes the following
    build failure:
    
    gcc   -O2 -fomit-frame-pointer -m32 -march=i686 -fno-strict-aliasing
    -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement
    -Wno-unused-but-set-variable -Wno-unused-local-typedefs
    -D__XEN_TOOLS__ -MMD -MF .rombios.o.d -D_LARGEFILE_SOURCE
    -D_LARGEFILE64_SOURCE -mno-tls-direct-seg-refs  -DNDEBUG -Werror
    -fno-stack-protector -fno-exceptions -fno-builtin -msoft-float
    -I/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware/hvmloader/../../../tools/include
    -U__XEN_TOOLS__
    -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__
    -DENABLE_OVMF -DENABLE_ROMBIOS -DENABLE_SEABIOS  -c -o rombios.o rombios.c
    rombios.c: In function ‘rombios_load_roms’:
    rombios.c:103:39: error: ‘etherboot’ undeclared (first use in this function)
                                           etherboot);
    
    Disable rombios instead.
    
    Reported-by: Holger Schramm <lists@schramm.by>
    Signed-off-by: George Dunlap <george.dunlap@citrix.com>
    ---
    CC: Stefano Stabellini <stefano.stabellini@citrix.com>

diff --git a/components/xen b/components/xen
index 894d119..ea290aa 100644
--- a/components/xen
+++ b/components/xen
@@ -45,7 +45,7 @@ function xen_build() {
     export ETHERBOOT_NICS=""
     ./configure --prefix=$PREFIX --with-system-qemu=$PREFIX/lib/xen/bin/qemu-system-i386 \
         --disable-stubdom --disable-qemu-traditional \
-        --enable-rombios $seabios_opt $ovmf_opt
+        --disable-rombios $seabios_opt $ovmf_opt
     $RAISIN_MAKE
     $RAISIN_MAKE install DESTDIR="$INST_DIR"
     unset ETHERBOOT_NICS

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel