From: George Dunlap <George.Dunlap@eu.citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH for-4.6 2/3] xen: replace non-POSIX error codes
Date: Wed, 22 Jul 2015 10:45:42 +0100 [thread overview]
Message-ID: <CAFLBxZZTioCTooo_W0VPNKEcSQYP75m5z-0Bz+0wwOGKyQZVtA@mail.gmail.com> (raw)
In-Reply-To: <CAFLBxZb28p2W77t7Ra5Cbo65LkCNbDuJYRk3qHmpJiNx8zsDUg@mail.gmail.com>
On Wed, Jul 22, 2015 at 10:43 AM, George Dunlap
<George.Dunlap@eu.citrix.com> wrote:
> On Tue, Jul 21, 2015 at 5:15 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 21.07.15 at 17:56, <roger.pau@citrix.com> wrote:
>>> Some DOMCTLs returned non-POSIX error codes, replace them with POSIX
>>> compilant values instead. EBADRQC and EBADSLT are replaced by EINVAL, while
>>> EUSERS is replaced with EOVERFLOW.
>>
>> Same here basically - I'd appreciate if we could use EINVAL only as
>> a last resort error value, to make errors distinguishable.
>
> What would be more helpful is if you suggested an alternate error code
> for the two EINVAL changes in this patch.
Sorry, I see you did suggest alternates in the other mail. I retract
my complaint...
> In the case of the first one, it looks like this is an "internal"
> hypercall used only to do continuation of paging domctls. Guests
> should never call this directly; -EINVAL seems perfectly suitable
> here.
But still think EINVAL is probably fine for this case.
-George
next prev parent reply other threads:[~2015-07-22 9:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 15:56 [PATCH for-4.6 0/3] Get rid of non-POSIX error codes Roger Pau Monne
2015-07-21 15:56 ` [PATCH for-4.6 1/3] xen/x86/libxl: replace non-POSIX error codes used by PSR code Roger Pau Monne
2015-07-21 16:11 ` Jan Beulich
2015-07-21 16:17 ` Ian Jackson
2015-07-22 9:51 ` Roger Pau Monné
2015-07-21 15:56 ` [PATCH for-4.6 2/3] xen: replace non-POSIX error codes Roger Pau Monne
2015-07-21 16:15 ` Jan Beulich
2015-07-22 9:43 ` George Dunlap
2015-07-22 9:45 ` George Dunlap [this message]
2015-07-21 15:56 ` [PATCH for-4.6 3/3] xen: remove " Roger Pau Monne
2015-07-21 16:19 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLBxZZTioCTooo_W0VPNKEcSQYP75m5z-0Bz+0wwOGKyQZVtA@mail.gmail.com \
--to=george.dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).