From: George Dunlap <george.dunlap@citrix.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@citrix.com>,
Olaf Hering <olaf@aepfle.de>, Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH for-4.7 1/2] hotplug: Fix xendomains lock path for RHEL-based systems
Date: Wed, 25 May 2016 13:55:58 +0100 [thread overview]
Message-ID: <CAFLBxZZUYv9gR8X33L3LrFx2XStgo1ij=4ET3jY1Y8kOAYjH5A@mail.gmail.com> (raw)
In-Reply-To: <1462965285-5299-1-git-send-email-george.dunlap@citrix.com>
On Wed, May 11, 2016 at 12:14 PM, George Dunlap
<george.dunlap@citrix.com> wrote:
> Commit c996572 changed the LOCKFILE path from a check between two
> hardcoded paths (/var/lock/subsys/ or /var/lock) to using the
> XEN_LOCK_DIR variable designated at configure time. Since
> XEN_LOCK_DIR doesn't (and shouldn't) have the 'subsys' postfix, this
> effectively moves all the lock files by default to /var/lock instead.
>
> Unfortunately, this breaks xendomains on RedHat-based SYSV init
> systems. RedHat-based SYSV init systems try to only call "${SERVICE}
> shutdown" on systems which actually have an actively running
> component; and they use the existence of /var/lock/subsys/${SERVICE}
> to determine which systems are running.
>
> Changing XEN_LOCK_DIR to /var/lock/subsys is not suitable, as only
> system services like xendomains should create lockfiles there; other
> locks (such as the console locks) should be created in /var/lock
> instead.
>
> Instead, re-instate the check for the subsys/ subdirectory of the lock
> directory in the xendomains script.
>
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
This should be backported to 4.6.
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-05-25 12:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 11:14 [PATCH for-4.7 1/2] hotplug: Fix xendomains lock path for RHEL-based systems George Dunlap
2016-05-11 11:14 ` [PATCH for-4.7 2/2] tools/xendomains: Create lockfile on start unconditionally George Dunlap
2016-05-11 11:19 ` George Dunlap
2016-05-11 14:31 ` Wei Liu
2016-05-11 14:30 ` Wei Liu
2016-05-11 14:38 ` Olaf Hering
2016-05-25 12:57 ` George Dunlap
2016-05-11 14:31 ` [PATCH for-4.7 1/2] hotplug: Fix xendomains lock path for RHEL-based systems Wei Liu
2016-05-11 14:37 ` Olaf Hering
2016-05-25 12:55 ` George Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFLBxZZUYv9gR8X33L3LrFx2XStgo1ij=4ET3jY1Y8kOAYjH5A@mail.gmail.com' \
--to=george.dunlap@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=olaf@aepfle.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).