xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <George.Dunlap@eu.citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Euan Harris <euan.harris@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Doug Goldstein <cardoe@cardoe.com>, Wei Liu <wei.liu2@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 2/2] tools: detect appropriate debug optimization level
Date: Thu, 31 Mar 2016 09:24:45 +0100	[thread overview]
Message-ID: <CAFLBxZaGe3gHUFxyc9+cqiGoi7FSwcWU_qG7WHr7pgpBrDorGA@mail.gmail.com> (raw)
In-Reply-To: <22267.63547.372145.368852@mariner.uk.xensource.com>

On Wed, Mar 30, 2016 at 5:00 PM, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> Doug Goldstein writes ("Re: [PATCH 2/2] tools: detect appropriate debug optimization level"):
>> On 3/8/16 9:38 AM, Wei Liu wrote:
>> > On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote:
>> >> The build should not use -O0 as that results in miscompilations. There
>> >
>> > This needs some (concrete) references. Is that a known issue in gcc? If
>> > so can you reference the bug number?
>> So its not really a bug in GCC but just the complete lack of
>> optimizations in play. inlines aren't inlined. dead code elimination
>> isn't run so things are much bigger. structures aren't padded the same way.
> My initial reaction is that I any actual problems are bugs either in
> the compiler or in Xen, which should be fixed.
> There should be nothing wrong with lack of inlining or dead code
> elimination.  If you can give an example of structure padding going
> wrong, please do.

I know in the Linux kernel the level of optimization must be -O2,
because there are certain things that rely on dead code elimination to
function properly.  I'm not sure if the Xen hypervisor has similar
requirements, but I'd be rather surprised if it didn't.

It would be nice to know what functionality in the tools relied on
inlining and/or dead code elimination (and under what circumstances),
but we probably have better things to do than make -O0 to work. :-)


Xen-devel mailing list

  parent reply	other threads:[~2016-03-31  8:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  2:23 [PATCH 1/2] libxl: ensure var is inited in libxl__domain_firmware Doug Goldstein
2016-03-08  2:23 ` [PATCH 2/2] tools: detect appropriate debug optimization level Doug Goldstein
2016-03-08 15:38   ` Wei Liu
2016-03-08 16:34     ` Doug Goldstein
2016-03-08 16:50       ` Wei Liu
2016-03-16 19:14         ` Doug Goldstein
2016-03-28 15:01           ` Doug Goldstein
2016-03-29 11:44             ` George Dunlap
2016-03-29 17:21               ` Doug Goldstein
2016-03-30  9:52                 ` George Dunlap
2016-03-30 16:00       ` Ian Jackson
2016-03-30 16:11         ` Ian Jackson
2016-03-30 16:20         ` Doug Goldstein
2016-03-31  8:24         ` George Dunlap [this message]
2016-04-06 14:07   ` Ian Jackson
2016-04-06 14:34     ` George Dunlap
2016-04-06 14:57       ` Ian Jackson
2016-03-08 15:38 ` [PATCH 1/2] libxl: ensure var is inited in libxl__domain_firmware Wei Liu
2016-03-10 15:13   ` Doug Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFLBxZaGe3gHUFxyc9+cqiGoi7FSwcWU_qG7WHr7pgpBrDorGA@mail.gmail.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=euan.harris@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).