From: George Dunlap <george.dunlap@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code
Date: Tue, 5 Apr 2016 10:28:40 +0100 [thread overview]
Message-ID: <CAFLBxZayOoy=tOG-uHh_N-2vFs9qt8Qcyxaav_-nNv3Va8jdaA@mail.gmail.com> (raw)
In-Reply-To: <5702A162.4050200@citrix.com>
On Mon, Apr 4, 2016 at 6:16 PM, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> On 04/04/16 18:11, Andrew Cooper wrote:
>> On 04/04/16 17:59, Ian Jackson wrote:
>>> George Dunlap writes ("Re: [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code"):
>>>> I looked through the patch in the branch provided in your reply to 0/9
>>>> [1], and it looks correct; morever, I tested it and it and the basic
>>>> functionality (using the "dummy" block script) still works.
>>>>
>>>> Reviewed-by: George Dunlap <george.dunlap@citrix.com>
>>>> Tested-by: George Dunlap <george.dunlap@citrix.com>
>>>>
>>>> [1] git://xenbits.xenproject.org/people/iwj/xen.git wip.gwd.hotplug-v3.1
>>> Thanks, I have pushed it (rebased) to staging.
>> New build failure on CentOS 7
>>
>> libxl_dm.c: In function 'libxl__build_device_model_args':
>> libxl_dm.c:1374:27: error: 'target_path' may be used uninitialized in
>> this function [-Werror=maybe-uninitialized]
>> drive = libxl__sprintf(gc, "%s,file=%s,format=%s",
>> ^
>> libxl_dm.c:1310:25: note: 'target_path' was declared here
>> const char *target_path;
>> ^
>> cc1: all warnings being treated as errors
>
> Sorry - sent too early. Specifically, target_path is genuinely
> uninitialised in the case that there is an empty CDROM specified.
Indeed -- what's strange is that I actually tested this on a CentOS 7
image and it didn't complain.
Anyway, a patch will be on its way...
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-05 9:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 17:22 [PATCH v3 0/9] tools: Allow HVM domains emulated access to disks provided by hotplug scripts George Dunlap
2016-03-24 17:22 ` [PATCH v3 1/9] tools/hotplug: Add a "dummy" hotplug script for testing George Dunlap
2016-03-24 17:22 ` [PATCH v3 2/9] libxl: Remove redundant setting of phyical-device George Dunlap
2016-03-24 17:22 ` [PATCH v3 3/9] tools/hotplug: Write physical-device-path in addition to physical-device George Dunlap
2016-04-01 14:15 ` Ian Jackson
2016-03-24 17:22 ` [PATCH v3 4/9] libxl: Move check for local access to a funciton George Dunlap
2016-04-01 14:16 ` Ian Jackson
2016-03-24 17:22 ` [PATCH v3 5/9] libxl: Rearrange qemu upstream disk argument code George Dunlap
2016-04-01 14:18 ` Ian Jackson
2016-04-01 14:31 ` Ian Jackson
2016-04-04 15:11 ` George Dunlap
2016-04-04 16:59 ` Ian Jackson
2016-04-04 17:11 ` Andrew Cooper
2016-04-04 17:16 ` Andrew Cooper
2016-04-05 9:28 ` George Dunlap [this message]
2016-03-24 17:22 ` [PATCH v3 6/9] libxl: Share logic for finding path between qemuu and pygrub George Dunlap
2016-04-01 14:19 ` Ian Jackson
2016-03-24 17:22 ` [PATCH v3 7/9] libxl: Allow local access for block devices with hotplug scripts George Dunlap
2016-04-01 14:20 ` Ian Jackson
2016-03-24 17:22 ` [PATCH v3 8/9] docs: Document block-script protocol George Dunlap
2016-04-01 14:20 ` Ian Jackson
2016-03-24 17:22 ` [PATCH v3 9/9] DO NOT APPLY libxl: Change hotplug script interface to use physical-device-path George Dunlap
2016-04-01 14:36 ` [PATCH v3 0/9] tools: Allow HVM domains emulated access to disks provided by hotplug scripts Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFLBxZayOoy=tOG-uHh_N-2vFs9qt8Qcyxaav_-nNv3Va8jdaA@mail.gmail.com' \
--to=george.dunlap@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).