From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72CF7C5519F for ; Wed, 25 Nov 2020 10:37:57 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03EB82063A for ; Wed, 25 Nov 2020 10:37:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YCtEdyPA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03EB82063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.37527.69928 (Exim 4.92) (envelope-from ) id 1khsB2-0005Ov-2n; Wed, 25 Nov 2020 10:37:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 37527.69928; Wed, 25 Nov 2020 10:37:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khsB1-0005Oo-WA; Wed, 25 Nov 2020 10:37:31 +0000 Received: by outflank-mailman (input) for mailman id 37527; Wed, 25 Nov 2020 10:37:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khsB0-0005Oj-LC for xen-devel@lists.xenproject.org; Wed, 25 Nov 2020 10:37:30 +0000 Received: from mail-pl1-x642.google.com (unknown [2607:f8b0:4864:20::642]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c458a78b-3e5a-4c47-81b9-20085582c7f5; Wed, 25 Nov 2020 10:37:29 +0000 (UTC) Received: by mail-pl1-x642.google.com with SMTP id bj5so914846plb.4 for ; Wed, 25 Nov 2020 02:37:29 -0800 (PST) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khsB0-0005Oj-LC for xen-devel@lists.xenproject.org; Wed, 25 Nov 2020 10:37:30 +0000 X-Inumbo-ID: c458a78b-3e5a-4c47-81b9-20085582c7f5 Received: from mail-pl1-x642.google.com (unknown [2607:f8b0:4864:20::642]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c458a78b-3e5a-4c47-81b9-20085582c7f5; Wed, 25 Nov 2020 10:37:29 +0000 (UTC) Received: by mail-pl1-x642.google.com with SMTP id bj5so914846plb.4 for ; Wed, 25 Nov 2020 02:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lG3+Uwz8lZti6FSb8xjGyaQfdt5OwV03xvf6+L3ZqWc=; b=YCtEdyPA4vCzWZsMjIt3djSgR9gg7vMRhn3I5LT7lEmWHdT3b/jEkR0QdduouORJ7k kiuUl5RijkS3EJmc3PIdIbhuWrYEtLAccN+wdoprBDsU56ruoUGszfH1Sxvuy4WXIhMK 0dDt7R//JtRYOU1+gQ96Rpa2FinP3O1pFccTMutbPTGjvqTac0chojMQO8cZdySzLIim HHsTKo91pUaUTwyxPnWizwDASocTC+n+eyDdN/HKPn9pe4V2vLDA/DOFrCcWbsrVXkvE 5CsjPeXzCB0gF8EvrEVdW+qQjVnUcViOyjSAD57xy0gbwLs+FCHLejwxIxOdH/xJHiTG +NRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lG3+Uwz8lZti6FSb8xjGyaQfdt5OwV03xvf6+L3ZqWc=; b=b0r7y1/0+LDs9OGnXxmtXu8MGgKwS9sZESqtyut8RIlAN4qB/0bwSruDKgviHYtDpS WIBKMFZGGctYBfPJv0sIQA4Drvt23oLHutSTo78/l+1vKyPFaFOP+4O74hphwYksyGwB HPY1hFlIuNwEGgY4rLWnwRYLJHf0O3K5V3mONy2v5VnRq2T5l8gC92zjXRVD6TZfBI8W Td0FFsmGpG3HEHQfZguUcXtDKKa9/CMYaAlwDrAO+kzkcs4bxYJCGHq0he0egW5E1ub9 C2+Aypma95RCebYLBdRhYrGq+ZFjB/CV6ZWq2EwIoAqgFjfRbXdulQSxFy5Ov1ckTNyS Inaw== X-Gm-Message-State: AOAM532fK9zp40dPTZRt79gSEFOMi8PU8lIyYEvP5jCFAOqjBynz8xxs 6hUBpKGxQwzpBBVuAr/SSat6hpoCj3d8D4a0wWM= X-Google-Smtp-Source: ABdhPJzEY8ebPN4xZ4jf0ZFVw9i65L6qlCom+E751HZA34/qY3SkadUuuLf2HukIG4qONDPWI5feIsM1VQGLuSbFYSc= X-Received: by 2002:a17:902:ead2:b029:da:2596:198e with SMTP id p18-20020a170902ead2b02900da2596198emr1937529pld.21.1606300648824; Wed, 25 Nov 2020 02:37:28 -0800 (PST) MIME-Version: 1.0 References: <20201120105344.4345c14e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <202011201129.B13FDB3C@keescook> <20201120115142.292999b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <202011220816.8B6591A@keescook> <9b57fd4914b46f38d54087d75e072d6e947cb56d.camel@HansenPartnership.com> <1c7d7fde126bc0acf825766de64bf2f9b888f216.camel@HansenPartnership.com> <4993259d01a0064f8bb22770503490f9252f3659.camel@HansenPartnership.com> In-Reply-To: <4993259d01a0064f8bb22770503490f9252f3659.camel@HansenPartnership.com> From: Andy Shevchenko Date: Wed, 25 Nov 2020 12:38:17 +0200 Message-ID: Subject: Re: [PATCH 000/141] Fix fall-through warnings for Clang To: James Bottomley Cc: Miguel Ojeda , Kees Cook , Jakub Kicinski , "Gustavo A. R. Silva" , linux-kernel , ALSA Development Mailing List , amd-gfx@lists.freedesktop.org, bridge@lists.linux-foundation.org, ceph-devel@vger.kernel.org, cluster-devel@redhat.com, coreteam@netfilter.org, "open list:STAGING SUBSYSTEM" , device-mapper development , drbd-dev@lists.linbit.com, dri-devel , GR-everest-linux-l2@marvell.com, GR-Linux-NIC-Dev@marvell.com, intel-gfx , intel-wired-lan@lists.osuosl.org, keyrings@vger.kernel.org, linux1394-devel@lists.sourceforge.net, ACPI Devel Maling List , linux-afs@lists.infradead.org, Linux ARM , linux-arm-msm@vger.kernel.org, linux-atm-general@lists.sourceforge.net, linux-block@vger.kernel.org, linux-can@vger.kernel.org, linux-cifs@vger.kernel.org, Linux Crypto Mailing List , linux-decnet-user@lists.sourceforge.net, Ext4 Developers List , "open list:FRAMEBUFFER LAYER" , linux-geode@lists.infradead.org, "open list:GPIO SUBSYSTEM" , linux-hams@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, linux-ide@vger.kernel.org, linux-iio , linux-input , linux-integrity , "moderated list:ARM/Mediatek SoC support" , Linux Media Mailing List , linux-mmc , Linux-MM , "open list:MEMORY TECHNOLOGY..." , linux-nfs@vger.kernel.org, "open list:HFI1 DRIVER" , Linux-Renesas , linux-scsi , linux-sctp@vger.kernel.org, linux-security-module , linux-stm32@st-md-mailman.stormreply.com, USB , linux-watchdog@vger.kernel.org, linux-wireless , Network Development , netfilter-devel@vger.kernel.org, nouveau@lists.freedesktop.org, op-tee@lists.trustedfirmware.org, oss-drivers@netronome.com, patches@opensource.cirrus.com, rds-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, samba-technical@lists.samba.org, selinux@vger.kernel.org, target-devel , tipc-discussion@lists.sourceforge.net, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux-foundation.org, wcn36xx@lists.infradead.org, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , xen-devel@lists.xenproject.org, linux-hardening@vger.kernel.org, Nick Desaulniers , Nathan Chancellor , Miguel Ojeda , Joe Perches Content-Type: text/plain; charset="UTF-8" On Mon, Nov 23, 2020 at 10:39 PM James Bottomley wrote: > On Mon, 2020-11-23 at 19:56 +0100, Miguel Ojeda wrote: > > On Mon, Nov 23, 2020 at 4:58 PM James Bottomley > > wrote: ... > > But if we do the math, for an author, at even 1 minute per line > > change and assuming nothing can be automated at all, it would take 1 > > month of work. For maintainers, a couple of trivial lines is noise > > compared to many other patches. > > So you think a one line patch should take one minute to produce ... I > really don't think that's grounded in reality. I suppose a one line > patch only takes a minute to merge with b4 if no-one reviews or tests > it, but that's not really desirable. In my practice most of the one line patches were either to fix or to introduce quite interesting issues. 1 minute is 2-3 orders less than usually needed for such patches. That's why I don't like churn produced by people who often even didn't compile their useful contributions. -- With Best Regards, Andy Shevchenko