From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Subject: Re: [Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit Date: Wed, 07 Jun 2017 17:20:59 +0000 Message-ID: References: <20170529084546.26500-1-marcandre.lureau@redhat.com> <20170529084546.26500-12-marcandre.lureau@redhat.com> <20170607164115.GE1919@perard.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5085202133926434703==" Return-path: In-Reply-To: <20170607164115.GE1919@perard.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Anthony PERARD Cc: pbonzini@redhat.com, f4bug@amsat.org, qemu-devel@nongnu.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============5085202133926434703== Content-Type: multipart/alternative; boundary="94eb2c06412664aaf1055161f6f8" --94eb2c06412664aaf1055161f6f8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Wed, Jun 7, 2017 at 8:57 PM Anthony PERARD wrote: > On Mon, May 29, 2017 at 12:45:43PM +0400, Marc-Andr=C3=A9 Lureau wrote: > > Move all the fronted struct and methods to a seperate unit. This avoids > > accidentally mixing backend and frontend calls, and helps with > readibilty. > > > > Make qemu_chr_replay() a macro shared by both char and char-fe. > > > > Export qemu_chr_write(), and use a macro for qemu_chr_write_all() > > > > (nb: yes, CharBackend is for char frontend :) > > Hi Marc-Andr=C3=A9, > > Following this patch, we are not able anymore to launch QEMU with > -monitor /dev/null. > > qemu-system-i386: -monitor /dev/null: 'tty' is not a valid char driver > name > > FYI, the full command line used: > /usr/lib/xen/bin/qemu-system-i386 -xen-domid 0 \ > -xen-attach -name dom0 -nographic -M xenpv -daemonize \ > -monitor /dev/null -serial /dev/null -parallel /dev/null \ > -nodefaults -no-user-config \ > -pidfile /var/run/xen/qemu-dom0.pid > > My bad, and the worse is that CI actually gave me some hints of the regression because the ChardevAlias array was empty. I dropped char-serial.h and char-parellel.h in this patch, it shouldn't be. I'll send fixes and add some tests. Thanks for the report! --=20 Marc-Andr=C3=A9 Lureau --94eb2c06412664aaf1055161f6f8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi

On Wed, Jun 7, 2017 at 8:57 PM Anthony PERARD <anthony.perard@citrix.com> wrote:

On Mon, May 29, 2017 at 12:45:43PM +0400, Marc-A= ndr=C3=A9 Lureau wrote:
> Move all the fronted struct and methods to a seperate unit. This avoid= s
> accidentally mixing backend and frontend calls, and helps with readibi= lty.
>
> Make qemu_chr_replay() a macro shared by both char and char-fe.
>
> Export qemu_chr_write(), and use a macro for qemu_chr_write_all()
>
> (nb: yes, CharBackend is for char frontend :)

Hi Marc-Andr=C3=A9,

Following this patch, we are not able anymore to launch QEMU with
-monitor /dev/null.
> qemu-system-i386: -monitor /dev/null: 'tty' is not a valid cha= r driver name

FYI, the full command line used:
/usr/lib/xen/bin/qemu-system-i386 -xen-domid 0 \
=C2=A0 =C2=A0 -xen-attach -name dom0 -nographic -M xenpv -daemonize \
=C2=A0 =C2=A0 -monitor /dev/null -serial /dev/null -parallel /dev/null \ =C2=A0 =C2=A0 -nodefaults -no-user-config \
=C2=A0 =C2=A0 -pidfile /var/run/xen/qemu-dom0.pid

My bad, and the worse is that CI actua= lly gave me some hints of the regression because the ChardevAlias array was= empty.

I dropped char-serial.h and char-parellel.h in th= is patch, it shouldn't be. I'll send fixes and add some tests.
<= br>

Thanks for the report!

--

Mar= c-Andr=C3=A9 Lureau

--94eb2c06412664aaf1055161f6f8-- --===============5085202133926434703== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5085202133926434703==--