From: Jason Andryuk <jandryuk@gmail.com>
To: Juergen Gross <jgross@suse.com>
Cc: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
xen-devel <xen-devel@lists.xenproject.org>,
"Jan Beulich" <jbeulich@suse.com>
Subject: Re: xen-balloon thread using 100% of CPU, regression in 5.4.150
Date: Tue, 5 Oct 2021 09:33:15 -0400 [thread overview]
Message-ID: <CAKf6xpsJT7-6A4CjE6_mvpuNJUhPKY4fBkU4zS9xYry47dWAKw@mail.gmail.com> (raw)
In-Reply-To: <f707c956-6cdc-9b32-5f22-227e0f5a9f10@suse.com>
On Tue, Oct 5, 2021 at 4:05 AM Juergen Gross <jgross@suse.com> wrote:
>
> On 04.10.21 11:14, Marek Marczykowski-Górecki wrote:
> > On Mon, Oct 04, 2021 at 07:31:40AM +0200, Juergen Gross wrote:
> >> On 03.10.21 06:47, Marek Marczykowski-Górecki wrote:
> >>> Hi,
> >>>
> >>> After updating a PVH domU to 5.4.150, I see xen-balloon thread using
> >>> 100% CPU (one thread).
> >>> This is a domain started with memory=maxmem=716800KiB (via libvirt). Then,
> >>> inside, I see:
> >>>
> >>> # cat /sys/devices/system/xen_memory/xen_memory0/target_kb
> >>> 716924
> >>> # cat /sys/devices/system/xen_memory/xen_memory0/info/current_kb
> >>> 716400
> >>>
> >>> Doing `cat info/current_kb > target_kb` "fixes" the issue. But still,
> >>> something is wrong - on earlier kernel (5.4.143 to be precise), it
> >>> wasn't spinning, with exactly the same values reported in sysfs. It
> >>> shouldn't run in circles if it can't get that much memory it wants. I
> >>> strongly suspect "xen/balloon: use a kernel thread instead a workqueue"
> >>> or related commit being responsible, but I haven't verified it.
> >>
> >> I think you are right. I need to handle the BP_ECANCELED case similar to
> >> BP_EAGAIN in the kernel thread (wait until target size changes again).
> >>
> >> One further question: do you see any kernel message in the guest related
> >> to the looping balloon thread?
> >
> > Nothing, only the usual "xen:balloon: Initialising balloon driver", and
> > nothing related to balloon after that.
>
> Could you try the attached patch, please? I've tested it briefly with
> PV and PVH guests.
I was seeing the CPU spinning in dom0 with xen command line:
dom0_mem=min:420M,max:420M,420M
Your patch eliminated the CPU spinning.
Tested-by: Jason Andryuk <jandryuk@gmail.com>
Thanks, Juergen
-Jason
prev parent reply other threads:[~2021-10-05 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 4:47 xen-balloon thread using 100% of CPU, regression in 5.4.150 Marek Marczykowski-Górecki
2021-10-04 5:31 ` Juergen Gross
2021-10-04 9:14 ` Marek Marczykowski-Górecki
2021-10-05 8:05 ` Juergen Gross
2021-10-05 13:31 ` Marek Marczykowski-Górecki
2021-10-05 13:33 ` Jason Andryuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKf6xpsJT7-6A4CjE6_mvpuNJUhPKY4fBkU4zS9xYry47dWAKw@mail.gmail.com \
--to=jandryuk@gmail.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=marmarek@invisiblethingslab.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).