From: Jason Andryuk <jandryuk@gmail.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH 1/2] tools/xl: allow split_string_into_pair() to trim values
Date: Mon, 20 Mar 2023 13:05:13 -0400 [thread overview]
Message-ID: <CAKf6xpsV1Xq0PiK_iqBDV0fpvkA0K6E-cbFXvhS3grjiuAkMGA@mail.gmail.com> (raw)
In-Reply-To: <20230317111546.18061-2-jgross@suse.com>
On Fri, Mar 17, 2023 at 7:16 AM Juergen Gross <jgross@suse.com> wrote:
>
> Most use cases of split_string_into_pair() are requiring the returned
> strings to be white space trimmed.
>
> In order to avoid the same code pattern multiple times, add a predicate
> parameter to split_string_into_pair() which can be specified to call
> trim() with that predicate for the string pair returned. Specifying
> NULL for the predicate will avoid the call of trim().
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Andryuk <jandryuk@gmail.com>
next prev parent reply other threads:[~2023-03-20 17:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 11:15 [PATCH 0/2] tools/xl: small cleanup of parsing code Juergen Gross
2023-03-17 11:15 ` [PATCH 1/2] tools/xl: allow split_string_into_pair() to trim values Juergen Gross
2023-03-20 17:05 ` Jason Andryuk [this message]
2023-03-21 10:24 ` Anthony PERARD
2023-03-17 11:15 ` [PATCH 2/2] tools/xl: rework p9 config parsing Juergen Gross
2023-03-20 17:12 ` Jason Andryuk
2023-03-21 5:45 ` Juergen Gross
2023-03-21 10:44 ` Anthony PERARD
2023-03-21 11:17 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKf6xpsV1Xq0PiK_iqBDV0fpvkA0K6E-cbFXvhS3grjiuAkMGA@mail.gmail.com \
--to=jandryuk@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).