From: Jason Andryuk <jandryuk@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Anthony Perard <anthony.perard@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/5] xen-mfndump: drop dead assignment to "page" from lookup_pte_func()
Date: Mon, 12 Jun 2023 08:47:41 -0400 [thread overview]
Message-ID: <CAKf6xptx4hNCZm6T371VJopUS+4=Fvp2Wd1m+16mAH5B0UHKYA@mail.gmail.com> (raw)
In-Reply-To: <fc7b72ce-2426-4452-bff6-f98b07b5a41c@suse.com>
On Mon, Jun 12, 2023 at 7:45 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> The variable isn't used past the loop, and its value also isn't
> meaningful across iterations. Reduce its scope to make this more
> obvious.
>
> Coverity ID: 1532310
> Fixes: ae763e422430 ("tools/misc: introduce xen-mfndump")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Jason Andryuk <jandryuk@gmail.com>
Thanks,
Jason
next prev parent reply other threads:[~2023-06-12 12:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 11:43 [PATCH 0/5] tools: address Coverity UNUSED issues Jan Beulich
2023-06-12 11:45 ` [PATCH 1/5] xen-mfndump: drop dead assignment to "page" from lookup_pte_func() Jan Beulich
2023-06-12 12:47 ` Jason Andryuk [this message]
2023-06-13 15:43 ` Anthony PERARD
2023-06-12 11:46 ` [PATCH 2/5] libxl: drop dead assignments to "ret" from libxl__domain_config_setdefault() Jan Beulich
2023-06-12 12:14 ` Juergen Gross
2023-06-12 19:44 ` Daniel P. Smith
2023-06-12 20:21 ` Daniel P. Smith
2023-06-13 6:33 ` Jan Beulich
2023-06-13 9:21 ` Daniel P. Smith
2023-06-13 9:40 ` Jan Beulich
2023-06-13 9:57 ` Daniel P. Smith
2023-06-13 10:15 ` Jan Beulich
2023-06-13 10:40 ` Daniel P. Smith
2023-06-13 15:51 ` Anthony PERARD
2023-06-12 11:46 ` [PATCH 3/5] libxg: drop dead assignment to "ptes" from xc_core_arch_map_p2m_list_rw() Jan Beulich
2023-06-12 12:16 ` Juergen Gross
2023-06-13 16:03 ` Anthony PERARD
2023-06-13 16:08 ` Jan Beulich
2023-06-13 16:40 ` Anthony PERARD
2023-06-14 6:34 ` Jan Beulich
2023-06-12 11:47 ` [PATCH 4/5] libxg: drop dead assignment to "rc" from xc_cpuid_apply_policy() Jan Beulich
2023-06-12 12:17 ` Juergen Gross
2023-06-13 16:08 ` Anthony PERARD
2023-06-12 11:47 ` [PATCH 5/5] libxl: drop dead assignment to transaction variable from libxl__domain_make() Jan Beulich
2023-06-12 12:19 ` Juergen Gross
2023-06-13 16:10 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKf6xptx4hNCZm6T371VJopUS+4=Fvp2Wd1m+16mAH5B0UHKYA@mail.gmail.com' \
--to=jandryuk@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=jbeulich@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).